Re: [tpmdd-devel] [RFC PATCH] tpm: msleep() delays - replace with usleep_range() in i2c nuvoton driver

2017-02-23 Thread Jason Gunthorpe
On Thu, Feb 23, 2017 at 06:46:18PM -0500, Mimi Zohar wrote: > Commit 500462a9de65 "timers: Switch to a non-cascading wheel" replaced > the 'classic' timer wheel, which aimed for near 'exact' expiry of the > timers. Their analysis was that the vast majority of timeout timers > are used as

[tpmdd-devel] [PATCH] tpm: Use the right clean up after cdev_add completes

2017-02-23 Thread Jason Gunthorpe
Once cdev_add is done the device node is visible to user space and could have been opened. Thus we have to go through the locking process in tpm_del_char_device if device_add fails. Fixes: 2c91ce8523a ("tpm: fix the rollback in tpm_chip_register()") Signed-off-by: Jason Gunthorpe

Re: [tpmdd-devel] [PATCH v2 6/7] tpm: expose spaces via a device link /dev/tpms

2017-02-23 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 09:25:19PM +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Currently the tpm spaces are not exposed to userspace. Make this > exposure via a separate device, which can now be opened multiple times > because each read/write

Re: [tpmdd-devel] [PATCH v2 7/7] tpm2: add session handle context saving and restoring to the space code

2017-02-23 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 09:25:20PM +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Sessions are different from transient objects in that their handles > may not be virtualized (because they're used for some hmac > calculations). Additionally when

Re: [tpmdd-devel] [PATCH v2 5/7] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

2017-02-23 Thread Jarkko Sakkinen
On Thu, Feb 16, 2017 at 09:25:18PM +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Signed-off-by: James Bottomley Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen