Re: [tpmdd-devel] [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error

2017-03-22 Thread Colin Ian King
On 22/03/17 11:42, Jarkko Sakkinen wrote: > On Mon, Mar 20, 2017 at 02:23:36PM +, Colin King wrote: >> From: Colin Ian King >> >> The comparison of an out of range index into space->context_tbl is >> off-by-one and should be using >= rather than >

[tpmdd-devel] NACK: [PATCH] tpm_tis: unconstify array cmd_getticks

2017-09-07 Thread Colin Ian King
On 07/09/17 09:42, Colin King wrote: > From: Colin Ian King > > Remove const from cmd_getticks, fixes build warnings: > > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of > 'tpm_tis_send_data' discards 'const' qualifier from pointer