Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-24 Thread Dmitry Torokhov
On Tue, Oct 24, 2017 at 11:37:57AM -0600, Jason Gunthorpe wrote: > On Tue, Oct 24, 2017 at 10:02:00AM -0700, Dmitry Torokhov wrote: > > tpm-rng is abomination that should be kicked out as soon as possible. > > It wrecks havoc with the power management (TPM chip drivers may go &

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-24 Thread Dmitry Torokhov
On Tue, Oct 24, 2017 at 9:11 AM, Jason Gunthorpe wrote: > On Tue, Oct 24, 2017 at 09:37:33PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Jason, >> >> On 24 October 2017 at 21:25, Jason Gunthorpe >> wrote: >> > On Tue, Oct 24,

Re: [tpmdd-devel] [PATCH 01/14] chardev: add helper function to register char devs with a struct device

2017-02-20 Thread Dmitry Torokhov
On Mon, Feb 20, 2017 at 10:00:40PM -0700, Logan Gunthorpe wrote: > Credit for this patch goes entirely to Dan Williams [1]. I've just > fleshed out the comments and created the patch, but the premise > remains exactly the same. > > There's a common pattern in the kernel whereby a struct cdev is

Re: [tpmdd-devel] [PATCH v3 2/2] tpm: add driver for cr50 on SPI

2016-08-09 Thread Dmitry Torokhov
On Wed, Jul 27, 2016 at 09:25:17PM -0700, Andrey Pronin wrote: > Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 > firmware. The firmware running on the currently supported H1 > Secure Microcontroller requires a special driver to handle its > specifics: > - need to ensure a

Re: [tpmdd-devel] [PATCH v3 2/2] tpm_tis_spi: add max xfer size

2016-08-09 Thread Dmitry Torokhov
ro...@chromium.org> Reviewed-by: Dmitry Torokhov <d...@chromium.org> > --- > drivers/char/tpm/tpm_tis_spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c > index dbaad9c..b103373 100644 > --- a/dri

Re: [tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-08-09 Thread Dmitry Torokhov
On Tue, Aug 9, 2016 at 8:01 AM, Jarkko Sakkinen < jarkko.sakki...@linux.intel.com> wrote: > On Tue, Aug 09, 2016 at 12:46:10PM +0300, Jarkko Sakkinen wrote: > > On Fri, Jul 29, 2016 at 10:30:22AM -0700, Dmitry Torokhov wrote: > > >On Fri, Jul 29, 2016 at 1

Re: [tpmdd-devel] [PATCH v3 1/2] tpm_tis_core: add optional max xfer size check

2016-08-09 Thread Dmitry Torokhov
> + (burstcnt > priv->phy_ops->max_xfer_size)) { This does not actually need parentheses, otehrwise: Reviewed-by: Dmitry Torokhov <d...@chromium.org> > + dev_warn(>dev, > +