[tpmdd-devel] [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible"

2017-08-07 Thread SZ Lin
ERROR: code indent should use tabs where possible +^I^I "Need to wait for TPM to finish\n");$ Signed-off-by: SZ Lin <sz@moxa.com> --- drivers/char/tpm/tpm_ibmvtpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/

[tpmdd-devel] [PATCH 3/5] Fix 'void function return statements are not generally useful' warning

2017-08-07 Thread SZ Lin
WARNING: void function return statements are not generally useful + return; +} Signed-off-by: SZ Lin <sz@moxa.com> --- drivers/char/tpm/tpm_ibmvtpm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c index 23913f

[tpmdd-devel] [PATCH 1/5] Fix packed and aligned attribute warnings.

2017-08-07 Thread SZ Lin
WARNING: __packed is preferred over __attribute__((packed)) +} __attribute__((packed, aligned(8))); WARNING: __aligned(size) is preferred over __attribute__((aligned(size))) +} __attribute__((packed, aligned(8))); Signed-off-by: SZ Lin <sz@moxa.com> --- drivers/char/tpm/tpm_ibmvtpm

[tpmdd-devel] [PATCH 4/5] Remove unneccessary 'out of memory' message

2017-08-07 Thread SZ Lin
if (!ibmvtpm) { + dev_err(dev, "kzalloc for ibmvtpm failed\n"); Signed-off-by: SZ Lin <sz@moxa.com> --- drivers/char/tpm/tpm_ibmvtpm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c

[tpmdd-devel] [PATCH 5/5] Use __func__ instead of function name

2017-08-07 Thread SZ Lin
Fix following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using the function's name, in a string Signed-off-by: SZ Lin <sz@moxa.com> --- drivers/char/tpm/tpm_ibmvtpm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/