Re: [tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-08-10 Thread Jarkko Sakkinen
On Tue, Aug 09, 2016 at 08:18:00AM -0700, Dmitry Torokhov wrote: >On Tue, Aug 9, 2016 at 8:01 AM, Jarkko Sakkinen > wrote: > > On Tue, Aug 09, 2016 at 12:46:10PM +0300, Jarkko Sakkinen wrote: > > On Fri, Jul 29, 2016 at 10:30:22AM -0700, Dmitry

Re: [tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-08-09 Thread Jason Gunthorpe
On Tue, Aug 09, 2016 at 08:18:00AM -0700, Dmitry Torokhov wrote: >Well, the main reason was simplicity and invasiveness of the >change. Well, it isn't simple, because the proposed patches have had subtle problems with DMA. Simple is to use a guaranteed dma-able allocation for DMA memory

Re: [tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-08-09 Thread Dmitry Torokhov
On Tue, Aug 9, 2016 at 8:01 AM, Jarkko Sakkinen < jarkko.sakki...@linux.intel.com> wrote: > On Tue, Aug 09, 2016 at 12:46:10PM +0300, Jarkko Sakkinen wrote: > > On Fri, Jul 29, 2016 at 10:30:22AM -0700, Dmitry Torokhov wrote: > > >On Fri, Jul 29, 2016 at 10:27 AM, Jason Gunthorpe > > >

Re: [tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-08-09 Thread Jarkko Sakkinen
On Fri, Jul 29, 2016 at 10:30:22AM -0700, Dmitry Torokhov wrote: >On Fri, Jul 29, 2016 at 10:27 AM, Jason Gunthorpe > wrote: > > On Thu, Jul 28, 2016 at 07:59:13PM -0700, Andrey Pronin wrote: > > Annotate buffers used in spi transactions as

Re: [tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-07-29 Thread Jason Gunthorpe
On Thu, Jul 28, 2016 at 07:59:13PM -0700, Andrey Pronin wrote: > Annotate buffers used in spi transactions as cacheline_aligned > to use in DMA transfers. > > Signed-off-by: Andrey Pronin > drivers/char/tpm/st33zp24/spi.c | 4 ++-- > drivers/char/tpm/tpm_tis_spi.c | 4

[tpmdd-devel] [PATCH] tpm: fix cacheline alignment for DMA-able buffers

2016-07-28 Thread Andrey Pronin
Annotate buffers used in spi transactions as cacheline_aligned to use in DMA transfers. Signed-off-by: Andrey Pronin --- drivers/char/tpm/st33zp24/spi.c | 4 ++-- drivers/char/tpm/tpm_tis_spi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git