Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-03-02 Thread Wolfram Sang
> If the command is larger than the supported adapter limit the command the > only viable option is to return an error. > For this the tpm layer would need the adapter limit. There is no single value for a limit. This is why the quirks struct is complex and we need a function to determine the

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-03-02 Thread Wolfram Sang
> TPMs are a not the best devices when it comes to i2c :/ BTW I blame the quirky I2C HW of the adapters, so far. signature.asc Description: PGP signature -- Check out the vibrant tech community on one of the world's

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-27 Thread Enric Balletbo Serra
2017-02-27 20:12 GMT+01:00 Wolfram Sang : > Hi, > >> >> > Rather than trying small and smaller transfers, would it not be better >> >> > to get the i2c core to expose the quirk info about transfer limits? >> >> > >> >> >> >> Sounds a good idea to me, I guess the quirk info can

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-27 Thread Enric Balletbo Serra
Bounce to Wolfram Sang 2017-02-22 15:01 GMT+01:00 Andrew Lunn : > On Wed, Feb 22, 2017 at 12:16:08PM +0100, Enric Balletbo i Serra wrote: >> Hi Andrew, >> >> Removing Bryan Freed from the loop as seems his email is not valid anymore. >> I already CC'ied Andrey which is doing the

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-27 Thread Wolfram Sang
Hi, > >> > Rather than trying small and smaller transfers, would it not be better > >> > to get the i2c core to expose the quirk info about transfer limits? > >> > > >> > >> Sounds a good idea to me, I guess the quirk info can be accessed with > >> > >>

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-22 Thread Andrew Lunn
On Wed, Feb 22, 2017 at 12:16:08PM +0100, Enric Balletbo i Serra wrote: > Hi Andrew, > > Removing Bryan Freed from the loop as seems his email is not valid anymore. I > already CC'ied Andrey which is doing the TPM bit in chromeos kernel. > > On 21/02/17 17:29, Andrew Lunn wrote: > > On Tue, Feb

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-22 Thread Peter Huewe
Am 21. Februar 2017 17:29:48 MEZ schrieb Andrew Lunn : >On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote: >> From: Bryan Freed >> >> When the I2C Infineon part is attached to an I2C adapter that imposes >> a size limitation, large

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-22 Thread Enric Balletbo i Serra
Hi Andrew, Removing Bryan Freed from the loop as seems his email is not valid anymore. I already CC'ied Andrey which is doing the TPM bit in chromeos kernel. On 21/02/17 17:29, Andrew Lunn wrote: > On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote: >> From: Bryan Freed

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

2017-02-21 Thread Andrew Lunn
On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote: > From: Bryan Freed > > When the I2C Infineon part is attached to an I2C adapter that imposes > a size limitation, large requests will fail -EINVAL. > Retry them with size backoff without re-issuing the