Re: [tpmdd-devel] [PATCH v3 4/7] tpm: Redefine the read_log method to check for ACPI/OF properties sequentially

2016-09-06 Thread Jason Gunthorpe
On Thu, Sep 01, 2016 at 12:39:46AM +0530, Nayna wrote: > >>+int read_log_of(struct tpm_chip *chip); > >>+#else > >>+static inline int read_log_of(struct tpm_chip *chip) > >>+{ > >>+ return -1; > >>+} > >>+#endif > > > >Though shouldn't these two be ERRNOs of some kind? -ENODEV? > > Sure.. > Was

Re: [tpmdd-devel] [PATCH v3 4/7] tpm: Redefine the read_log method to check for ACPI/OF properties sequentially

2016-08-31 Thread Nayna
On 08/30/2016 11:24 PM, Jason Gunthorpe wrote: > On Tue, Aug 30, 2016 at 12:50:16AM -0400, Nayna Jain wrote: >> Currently, the difference in read_log method for ACPI/OF based platforms >> is handled by defining respective read_log method and handing >> them using CONFIG based #ifdef condition in

Re: [tpmdd-devel] [PATCH v3 4/7] tpm: Redefine the read_log method to check for ACPI/OF properties sequentially

2016-08-30 Thread Jason Gunthorpe
On Tue, Aug 30, 2016 at 12:50:16AM -0400, Nayna Jain wrote: > Currently, the difference in read_log method for ACPI/OF based platforms > is handled by defining respective read_log method and handing > them using CONFIG based #ifdef condition in Makefile which is not > the recommended approach. >

[tpmdd-devel] [PATCH v3 4/7] tpm: Redefine the read_log method to check for ACPI/OF properties sequentially

2016-08-29 Thread Nayna Jain
Currently, the difference in read_log method for ACPI/OF based platforms is handled by defining respective read_log method and handing them using CONFIG based #ifdef condition in Makefile which is not the recommended approach. This patch cleans up the ifdef condition in Makefile by defining