Re: [tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-11-03 Thread Jarkko Sakkinen
On Tue, Oct 18, 2016 at 08:49:43PM -0400, Nayna Jain wrote: > Currently, read_log() has two implementations: one for ACPI platforms > and the other for device tree(OF) based platforms. The proper one is > selected at compile time using Kconfig and #ifdef in the Makefile, > which is not the

Re: [tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-10-20 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 11:26:25AM -0600, Jason Gunthorpe wrote: > On Wed, Oct 19, 2016 at 07:17:40PM +0300, Jarkko Sakkinen wrote: > > > Suggested-by: Jason Gunthorpe > > > Signed-off-by: Nayna Jain > > > Reviewed-by: Jason Gunthorpe

Re: [tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-10-19 Thread Jarkko Sakkinen
On Tue, Oct 18, 2016 at 08:49:43PM -0400, Nayna Jain wrote: > Currently, read_log() has two implementations: one for ACPI platforms > and the other for device tree(OF) based platforms. The proper one is > selected at compile time using Kconfig and #ifdef in the Makefile, > which is not the

[tpmdd-devel] [PATCH v5 5/7] tpm: redefine read_log() to handle ACPI/OF at runtime

2016-10-18 Thread Nayna Jain
Currently, read_log() has two implementations: one for ACPI platforms and the other for device tree(OF) based platforms. The proper one is selected at compile time using Kconfig and #ifdef in the Makefile, which is not the recommended approach. This patch removes the #ifdef in the Makefile by