Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support, for TPM 2.0 firmware event log

2017-01-31 Thread Jarkko Sakkinen
On Wed, Jan 25, 2017 at 04:22:45PM -0500, Ken Goldman wrote: > > You do not need to send a new patch set version as long as this > > one gets peer tested. And it needs to be tested without hacks > > like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to > > be peer tested to be more

Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support, for TPM 2.0 firmware event log

2017-01-30 Thread Ken Goldman
> You do not need to send a new patch set version as long as this > one gets peer tested. And it needs to be tested without hacks > like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to > be peer tested to be more specific. > > For me the code itself looks good but I simply cannot take

Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support, for TPM 2.0 firmware event log

2017-01-25 Thread Jarkko Sakkinen
On Wed, Jan 25, 2017 at 04:22:45PM -0500, Ken Goldman wrote: > > You do not need to send a new patch set version as long as this > > one gets peer tested. And it needs to be tested without hacks > > like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to > > be peer tested to be more

Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

2017-01-25 Thread Jarkko Sakkinen
On Tue, Jan 24, 2017 at 03:41:22PM +0530, Nayna wrote: > > > On 01/23/2017 08:43 PM, Jarkko Sakkinen wrote: > > On Mon, Jan 23, 2017 at 02:26:27AM -0500, Nayna Jain wrote: > > > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > > > not support the securityfs pseudo files for

Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

2017-01-24 Thread Nayna
On 01/23/2017 08:43 PM, Jarkko Sakkinen wrote: > On Mon, Jan 23, 2017 at 02:26:27AM -0500, Nayna Jain wrote: >> Unlike the device driver support for TPM 1.2, the TPM 2.0 does >> not support the securityfs pseudo files for displaying the >> firmware event log. >> >> This patch enables support for

Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

2017-01-23 Thread Jarkko Sakkinen
On Mon, Jan 23, 2017 at 02:26:27AM -0500, Nayna Jain wrote: > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > not support the securityfs pseudo files for displaying the > firmware event log. > > This patch enables support for providing the TPM 2.0 event log in > binary form. TPM

[tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

2017-01-22 Thread Nayna Jain
Unlike the device driver support for TPM 1.2, the TPM 2.0 does not support the securityfs pseudo files for displaying the firmware event log. This patch enables support for providing the TPM 2.0 event log in binary form. TPM 2.0 event log supports a crypto agile format that records multiple