Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-08-25 Thread Jarkko Sakkinen
On Tue, Jul 26, 2016 at 02:17:11PM -0600, Jason Gunthorpe wrote: > On Tue, Jul 26, 2016 at 11:44:43PM +0530, Nayna wrote: > > I got these questions while testing some TPM2.0 stuff using the kernel > > code from repo having this patch and am using Nuvoton TPM. > > > > #1. It seems that support is

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-29 Thread Nayna
Thanks everyone for discussion and clarifying the design points. This helps and we can now test by changing our device-tree entries. Also, we are assuming that just updating .compatible device tree entry should do the fix. We don't have to add any additional .data property. And driver will

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-27 Thread George Wilson
On Wed, Jul 27, 2016 at 10:31:52AM -0600, Jason Gunthorpe wrote: > On Wed, Jul 27, 2016 at 11:05:14AM -0500, George Wilson wrote: > > > > Yes, generally Linux expects DT to be set correctly by the boot > > > firmware. Early firmware needs to know the TPM type anyhow to do the > > > TPM setup, so

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-27 Thread Dave Heller
On 07/27/2016 12:24 PM, Jason Gunthorpe wrote: > On Wed, Jul 27, 2016 at 10:30:09AM -0400, Dave Heller wrote: >>> So you might do >>> >>>compatible = "nuvoton,npct650", "nuvoton,npct601" >>> >>> Andrew, is 601 even the right name? >> >> Hi Jason, I'm not sure I'm understanding your answer

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-27 Thread Jason Gunthorpe
On Wed, Jul 27, 2016 at 11:05:14AM -0500, George Wilson wrote: > > Yes, generally Linux expects DT to be set correctly by the boot > > firmware. Early firmware needs to know the TPM type anyhow to do the > > TPM setup, so this doesn't seem like a realistic scenario. > > A reset is required after

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-27 Thread Jason Gunthorpe
On Wed, Jul 27, 2016 at 10:30:09AM -0400, Dave Heller wrote: > > So you might do > > > > compatible = "nuvoton,npct650", "nuvoton,npct601" > > > > Andrew, is 601 even the right name? > > Hi Jason, I'm not sure I'm understanding your answer here. Looks like > we will have to add a couple of

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-27 Thread George Wilson
On Tue, Jul 26, 2016 at 03:03:44PM -0600, Jason Gunthorpe wrote: > On Tue, Jul 26, 2016 at 03:39:02PM -0500, George Wilson wrote: > > > Generally speaking probing is somewhat discouraged, currently we only > > > probe for PC platform tis (and even that might be a mistake), all > > > other drivers

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-27 Thread Dave Heller
On 07/26/2016 04:17 PM, Jason Gunthorpe wrote: > On Tue, Jul 26, 2016 at 11:44:43PM +0530, Nayna wrote: >> I got these questions while testing some TPM2.0 stuff using the kernel >> code from repo having this patch and am using Nuvoton TPM. >> >> #1. It seems that support is added only for

Re: [tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-26 Thread George Wilson
On Tue, Jul 26, 2016 at 02:17:11PM -0600, Jason Gunthorpe wrote: > On Tue, Jul 26, 2016 at 11:44:43PM +0530, Nayna wrote: > > I got these questions while testing some TPM2.0 stuff using the kernel > > code from repo having this patch and am using Nuvoton TPM. > > > > #1. It seems that support is

[tpmdd-devel] Regarding recently Added TPM2.0 support to the Nuvoton i2c driver

2016-07-26 Thread Nayna
Hi I might not be aware of some background related to TPM device driver design and so have got few questions regarding recently added support in Nuvoton i2c driver for TPM2.0 (http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/82cc1a49b6358394938e759dc4c22b2be773bbad). I got these