Re: [tpmdd-devel] Intel NUC and fTPM issue on 4.9.2

2017-02-17 Thread Davide Guerri
Hey,sorry fro the delayed reply.Jason's patch works. I had no doubt it would, because I tried a qnd patch with manually cropped sizes. I have cleaned it up a little bit, removing printks.Thanks again!D.  NUC-fw-fix.patch Description: Binary data On 17 Feb 2017, at 7:01 pm, Jason Gunthorpe

Re: [tpmdd-devel] Intel NUC and fTPM issue on 4.9.2

2017-02-17 Thread Sakkinen, Jarkko
On Fri, 2017-02-17 at 09:43 -0700, Jason Gunthorpe wrote: > On Thu, Feb 16, 2017 at 10:36:40PM +, Winkler, Tomas wrote: > >    This is a BIOS issue + kernel ACPI platform driver refusing to > > handle > >    overlapping memory space. The issue here is that the ACPI > > platform > >    driver

Re: [tpmdd-devel] tpmdd-devel Digest, Vol 110, Issue 19

2017-02-17 Thread Benoit HOUYERE
Hi Jarko, For your information : 1. [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes (Peter Huewe) Tested-by: Benoit Houyere 2. [PATCH 0/5] Fix whole native SPI TPM driver (Peter Huewe) Tested-by: Benoit

Re: [tpmdd-devel] [PATCH] tpm: Fix expected number of response bytes of TPM1.2 PCR Extend

2017-02-17 Thread Mimi Zohar
On Fri, 2017-02-17 at 20:45 +0200, Jarkko Sakkinen wrote: > On Fri, Feb 17, 2017 at 07:46:38AM -0500, Mimi Zohar wrote: > > Hi James, > > > > On Wed, 2017-02-15 at 20:09 +0200, Jarkko Sakkinen wrote: > > > On Wed, Feb 15, 2017 at 11:56:23AM -0500, Stefan Berger wrote: > > > > The TPM1.2 PCR

Re: [tpmdd-devel] Intel NUC and fTPM issue on 4.9.2

2017-02-17 Thread Jason Gunthorpe
> I would rather review a patch with proper commit message than just pick > from an email thread in all cases with a proper explanation what the > patch does and why it is the right way to fix the issue. Of course, but I am waiting for Davide to say the approach even works .. Jason

Re: [tpmdd-devel] Intel NUC and fTPM issue on 4.9.2

2017-02-17 Thread Jason Gunthorpe
On Thu, Feb 16, 2017 at 10:36:40PM +, Winkler, Tomas wrote: >This is a BIOS issue + kernel ACPI platform driver refusing to handle >overlapping memory space. The issue here is that the ACPI platform >driver is not created, however this should not prevent the tpm_crb >driver

Re: [tpmdd-devel] [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-17 Thread Jarkko Sakkinen
On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > There's no need to export tpm2_get_pcr_alloation() because it is only > a helper function for tpm2_auto_startup(). For the same reason it does > not make much sense to maintain documentation for it. > > Signed-off-by: Jarkko

Re: [tpmdd-devel] [RFC] tpm2-space: add handling for global session exhaustion

2017-02-17 Thread Jarkko Sakkinen
On Fri, Feb 17, 2017 at 03:56:26AM -0600, Dr. Greg Wettstein wrote: > On Thu, Feb 16, 2017 at 10:33:04PM +0200, Jarkko Sakkinen wrote: > > Good morning to everyone. > > > On Thu, Feb 16, 2017 at 02:06:42PM -0600, Dr. Greg Wettstein wrote: > > > Just as an aside, has anyone given any thought

Re: [tpmdd-devel] [PATCH] tpm: Fix expected number of response bytes of TPM1.2 PCR Extend

2017-02-17 Thread Mimi Zohar
Hi James, On Wed, 2017-02-15 at 20:09 +0200, Jarkko Sakkinen wrote: > On Wed, Feb 15, 2017 at 11:56:23AM -0500, Stefan Berger wrote: > > The TPM1.2 PCR Extend operation only returns 20 bytes in the body, > > which is the size of the PCR state. > > > > This fixes a problem where IMA gets errors