Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

2017-08-09 Thread Ken Goldman
On 8/8/2017 3:11 PM, Jarkko Sakkinen wrote: On Mon, Aug 07, 2017 at 01:52:34PM +0200, Peter Huewe wrote: Imho: NACK from my side. After these viewpoints definitive NACK from my side too... I responded to the thread comments separately. However, assuming NACK is the final response, I have

[tpmdd-devel] [PATCH] Do not disable driver and bus shutdown hook when class shutdown hook is set.

2017-08-09 Thread Michal Suchanek
Disabling the driver hook by setting class hook is totally sound design not prone to error as evidenced by the single implementation of the class hook. Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.") Fixes: f77af1516584 ("Add "shutdown" to "struct class".") Signed-off-by:

Re: [tpmdd-devel] [PATCH] Do not disable driver and bus shutdown hook when class shutdown hook is set.

2017-08-09 Thread Jason Gunthorpe
On Wed, Aug 09, 2017 at 11:34:20PM +0200, Michal Suchanek wrote: > Disabling the driver hook by setting class hook is totally sound design > not prone to error as evidenced by the single implementation of the > class hook. It was done this was for consistency, if you look at the full code: