On Mon, Mar 20, 2017 at 10:17:19AM +0100, Arnd Bergmann wrote:
> When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions:
>
> drivers/char/tpm/tpm_crb.c:551:12: error: 'crb_pm_resume' defined but not
> used [-Werror=unused-function]
> drivers/char/tpm/tpm_crb.c:540:12: error:
>
> On Mon, Mar 20, 2017 at 11:01:36PM +, Winkler, Tomas wrote:
>
> > I believe that in this case the #ifdefs can be done correctly quite
> > easily, but now I'm not against your solution as well, just maybe put
> > some of this info to the commit message.
>
> I perfer fewer ifdefs, it
On Mon, Mar 20, 2017 at 11:01:36PM +, Winkler, Tomas wrote:
> I believe that in this case the #ifdefs can be done correctly quite
> easily, but now I'm not against your solution as well, just maybe
> put some of this info to the commit message.
I perfer fewer ifdefs, it makes it more
> On Mon, Mar 20, 2017 at 1:11 PM, Winkler, Tomas
> wrote:
> >>
> >> When CONFIG_PM_SLEEP is disabled, we get a warning about unused
> >> functions:
> >>
> >> drivers/char/tpm/tpm_crb.c:551:12: error: 'crb_pm_resume' defined but
> >> not used [-Werror=unused-function]
>
When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions:
drivers/char/tpm/tpm_crb.c:551:12: error: 'crb_pm_resume' defined but not used
[-Werror=unused-function]
drivers/char/tpm/tpm_crb.c:540:12: error: 'crb_pm_suspend' defined but not used
[-Werror=unused-function]
We could