Re: [tpmdd-devel] [PATCH 2/2] TPM2.0:Adds securityfs support for TPM2.0 eventlog

2016-08-29 Thread Ken Goldman
On 7/29/2016 1:14 PM, Jason Gunthorpe wrote: > > The bios log is defined to be host endian? > > Please reference the standard in a comment that these structs are > coming from. The BIOS log is little endian. That is, all multi-byte values are little endian. Examples are the pcrIndex,

Re: [tpmdd-devel] [PATCH 2/2] TPM2.0:Adds securityfs support for TPM2.0 eventlog

2016-08-01 Thread Nayna
Hi Jason, Thanks for review, Please find my responses inline. On 07/29/2016 10:44 PM, Jason Gunthorpe wrote: > On Fri, Jul 29, 2016 at 02:44:39AM -0400, Nayna Jain wrote: > >> +chip->bios_dir = tpm_bios_log_setup(chip); >> + > > And the next somewhat pre-existing issue is that we call >

Re: [tpmdd-devel] [PATCH 2/2] TPM2.0:Adds securityfs support for TPM2.0 eventlog

2016-07-29 Thread Jason Gunthorpe
On Fri, Jul 29, 2016 at 02:44:39AM -0400, Nayna Jain wrote: > + chip->bios_dir = tpm_bios_log_setup(chip); > + And the next somewhat pre-existing issue is that we call tpm_bios_log_setup even if we don't have access to a bios log. Does the bios log ever change or is it static at boot? Can