Re: [tpmdd-devel] [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support
On Sun, Nov 20, 2016 at 09:58:48AM +, Jarkko Sakkinen wrote: > On Sat, Nov 19, 2016 at 11:36:27AM -0700, Jason Gunthorpe wrote: > > On Tue, Nov 15, 2016 at 10:54:53AM -0800, Jarkko Sakkinen wrote: > > > On Tue, Nov 15, 2016 at 11:06:10AM -0700, Jason Gunthorpe wrote: > > > > On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote: > > > > > > > > > I applied fix from Colin. I for OF specific patches in this patch set > > > > > I do not have means to test the code paths that exercise OF specific > > > > > functionality. This is what worries me a bit. If I had tested-by from > > > > > someone running a system that can exercise those code paths, I would > > > > > be less worried. > > > > > > > > I can probably check it next week on my OF systems that do not use > > > > event log > > > > > > Thanks Jason. I'll apppend your Tested-by's to the commits when you're > > > done. Probably doing pull request in the latter part of next week. > > > > What are we testing? Your master now? It will need the patch I just > > sent or it will fail for me. Your TOT works for me (60632de288aac485b328e0863f0c987062ca9b49) There is one tiny regression, I'll send a patch for it.. Jason -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support
On Sat, Nov 19, 2016 at 11:36:27AM -0700, Jason Gunthorpe wrote: > On Tue, Nov 15, 2016 at 10:54:53AM -0800, Jarkko Sakkinen wrote: > > On Tue, Nov 15, 2016 at 11:06:10AM -0700, Jason Gunthorpe wrote: > > > On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote: > > > > > > > I applied fix from Colin. I for OF specific patches in this patch set > > > > I do not have means to test the code paths that exercise OF specific > > > > functionality. This is what worries me a bit. If I had tested-by from > > > > someone running a system that can exercise those code paths, I would > > > > be less worried. > > > > > > I can probably check it next week on my OF systems that do not use event > > > log > > > > Thanks Jason. I'll apppend your Tested-by's to the commits when you're > > done. Probably doing pull request in the latter part of next week. > > What are we testing? Your master now? It will need the patch I just > sent or it will fail for me. $ git am -3 ~/Desktop/foo.txt Patch is empty. Was it split wrong? When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". I'm at the Heathrow airport boarding. Look it more properly later on /Jarkko -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support
On 11/15/2016 07:45 AM, Jarkko Sakkinen wrote: > On Mon, Nov 14, 2016 at 04:25:14PM -0800, Jarkko Sakkinen wrote: >> On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote: >>> On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote: This patch set includes the cleanup and bug fixes patches, previously part of the "tpm: add the securityfs pseudo files support for TPM 2.0 firmware event log" patch set, in order to upstream them more quickly. >>> >>> I applied the patches. I'm not yet sure whether these are part of the >>> 4.10 pull request or whether I postpone to 4.11 (my preference would be >>> 4.10 but I do not want to close that right now). I'll do testing next >>> week before doing pull request. >>> >>> I hope that the commits gets some reviews and testing now that they are >>> easily testable in my master branch. >> >> Event log still works and they do not seem to break TPM 2.0 (tried both >> machine with tpm_crb and tpm_tis). >> >> Stefan: would you mind check that these do not break your TPM 1.2 >> environment? I already tried wih TPM 1.2 machine but probably would >> make sense to peer test. > > I'm dropping commits 8/9 and 9/9 from my tree and *will not* include > them to my 4.10 pull request. Will fix this and resend the patch 8/9 and 9/9 again. Thanks & Regards, - Nayna > > /Jarkko > -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support
On Mon, Nov 14, 2016 at 04:25:14PM -0800, Jarkko Sakkinen wrote: > On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote: > > On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote: > > > This patch set includes the cleanup and bug fixes patches, previously > > > part of the "tpm: add the securityfs pseudo files support for TPM 2.0 > > > firmware event log" patch set, in order to upstream them more quickly. > > > > I applied the patches. I'm not yet sure whether these are part of the > > 4.10 pull request or whether I postpone to 4.11 (my preference would be > > 4.10 but I do not want to close that right now). I'll do testing next > > week before doing pull request. > > > > I hope that the commits gets some reviews and testing now that they are > > easily testable in my master branch. > > Event log still works and they do not seem to break TPM 2.0 (tried both > machine with tpm_crb and tpm_tis). > > Stefan: would you mind check that these do not break your TPM 1.2 > environment? I already tried wih TPM 1.2 machine but probably would > make sense to peer test. I'm dropping commits 8/9 and 9/9 from my tree and *will not* include them to my 4.10 pull request. /Jarkko -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support
On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote: > On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote: > > This patch set includes the cleanup and bug fixes patches, previously > > part of the "tpm: add the securityfs pseudo files support for TPM 2.0 > > firmware event log" patch set, in order to upstream them more quickly. > > I applied the patches. I'm not yet sure whether these are part of the > 4.10 pull request or whether I postpone to 4.11 (my preference would be > 4.10 but I do not want to close that right now). I'll do testing next > week before doing pull request. > > I hope that the commits gets some reviews and testing now that they are > easily testable in my master branch. Event log still works and they do not seem to break TPM 2.0 (tried both machine with tpm_crb and tpm_tis). Stefan: would you mind check that these do not break your TPM 1.2 environment? I already tried wih TPM 1.2 machine but probably would make sense to peer test. /Jarkko -- ___ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Re: [tpmdd-devel] [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support
On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote: > This patch set includes the cleanup and bug fixes patches, previously > part of the "tpm: add the securityfs pseudo files support for TPM 2.0 > firmware event log" patch set, in order to upstream them more quickly. I applied the patches. I'm not yet sure whether these are part of the 4.10 pull request or whether I postpone to 4.11 (my preference would be 4.10 but I do not want to close that right now). I'll do testing next week before doing pull request. I hope that the commits gets some reviews and testing now that they are easily testable in my master branch. /Jarkko > > Changelog History: > > v6: > > - Patch "tpm: replace symbolic permission with octal for securityfs files" > - New Patch. > - Patch "tpm: have event log use the tpm_chip" > - Changed commit description as per Jason's suggestion. > - Fixed bug related to kfree() for bios_event_log. > - Moved inode_unlock() just after get_device() in open(). > - Returned -ENODEV for read_log() ENOMEM error and other errors as it is. > - Added comment in tpm_bios_log_teardown() to explain inode_lock()/unlock > reasoning. > - Splitted .owner into different patch. > - Patch "tpm: fix the missing .owner in tpm_bios_measurements_ops" > - New Patch. > - Patch "tpm: cleanup of printk error messages" > - Replaced dev_info() with dev_warn(). > - Updated commit description subject line. > > v5: > > - Moved cleanup/fixes patches into this patch set. > - Patch "fix the race condition between event log access and chip > getting unregistered" > - updated subject line and commit description. > - modified fops code to use chip kref. > - modified fops to lock inode before accessing inode private data. > - renamed tpm_securityfs_data to tpm_chip_seqops, as it no more > holds bios log, but associates seqops with respective chip. For > the same reason, moved it to tpm.h > - Patch "replace or remove printk error messages" > - cleaned up dev_dbg and used dev_info as applicable. > > v4: > > - Includes feedbacks from Jarkko and Jason. > - Patch "tpm: define a generic open() method for ascii & bios > measurements". > - Fix indentation issue. > - Patch "tpm: replace the dynamically allocated bios_dir as > struct dentry array". > - Continue to use bios_dir_count variable to use is_bad() checks and > to maintain correct order for securityfs_remove() during teardown. > - Reset chip->bios_dir_count in teardown() function. > - Patch "tpm: validate the event log access before tpm_bios_log_setup". > - Retain TPM2 check which was removed in previous patch. > - Add tpm_bios_log_setup failure handling. > - Remove use of private data from v3 version of patch. Add a new > member to struct tpm_chip to achieve the same purpose. > - Patch "tpm: redefine the read_log method to check for ACPI/OF > properties sequentially". > - Move replacement of CONFIG_TCG_IBMVTPM with CONFIG_OF to > this patch from patch 3. > - Replace -1 error code with -ENODEV. > - Patch "tpm: replace the of_find_node_by_name() with dev of_node > property". > - Uses chip->dev.parent->of_node. > - Created separate patch for cleanup of pr_err messages. > - Patch "tpm: remove printk error messages". > - New Patch. > - Patch "tpm: add the securityfs file support for TPM 2.0 event log". > - Parses event digests using event alg_id rather than event log header > alg_id. > - Uses of_property_match_string to differentiate tpm/vtpm compatible > property. > - Adds the comment for difference in tpm/vtpm endianness. > > v3: > > - Includes the review feedbacks as suggested by Jason. > - Split of patches into one patch per idea. > - Generic open() method for ascii/bios measurements. > - Replacement of of **bios_dir with *bios_dir[3]. > - Verifying readlog() is successful before creating securityfs entries. > - Generic readlog() to check for ACPI/OF in sequence. > - read_log_of() method now uses of_node propertry rather than > calling find_device_by_name. > - read_log differentiates vtpm/tpm using its compatible property. > - Cleans pr_err with dev_dbg. > - Commit msgs subject line prefixed with tpm. > > v2: > > - Fixes issues as given in feedback by Jason. > - Adds documentation for device tree. > > Nayna Jain (9): > tpm: define a generic open() method for ascii & bios measurements > tpm: replace symbolic permission with octal for securityfs files > tpm: replace dynamically allocated bios_dir with a static array > tpm: drop tpm1_chip_register(/unregister) > tpm: have event log use the tpm_chip > tpm: fix the missing .owner in tpm_bios_measurements_ops > tpm: redefine read_log() to handle ACPI/OF at runtime > tpm: replace of_find_node_by_name() with dev of_node property > tpm: cleanup of printk error messages > > drivers/char/tpm/Makefile | 14 +-- > drivers/char/tpm/tpm-chip.c | 33 ++ > drivers/char/tpm/tpm-sysfs.c| 3 + > drivers/char/tpm/tpm.h