[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

2017-03-17 Thread Brett C.
Brett C. added the comment: First, don't worry about the x-github-signature missing. It's the last line of the headers shown in the GitHub UI and so it's quite possible i just botched my copy-and-paste. And I will upload the headers, 400 response, and JSON body of the most recently failed

[Tracker-discuss] [issue619] Use author's name if committer is set to GitHub on commit notifications

2017-03-17 Thread Maciej Szulik
Maciej Szulik added the comment: I've created alternate solution in this patch: http://psf.upfronthosting.co.za/roundup/meta/file459/issue613.patch -- nosy: +maciej.szulik ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

2017-03-17 Thread Maciej Szulik
Maciej Szulik added the comment: Brett, can I ask you to send me directly (or attach here) some of those rejected requests? Based on the current one I don't see anything suspicious, but maybe I'm overlooking something... ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

2017-03-17 Thread Maciej Szulik
Maciej Szulik added the comment: Brett, the most worrying thing is missing `X-Hub-Signature` header in the request from http://psf.upfronthosting.co.za/roundup/meta/msg3281. I've uploaded tweaked patch from Berker but I've mostly switched to logging, we don't want to simplify hacking our

[Tracker-discuss] [issue619] Use author's name if committer is set to GitHub on commit notifications

2017-03-17 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch. ___ PSF Meta Tracker ___diff --git

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

2017-03-17 Thread Berker Peksag
Berker Peksag added the comment: I converted Brett's payload example to a test case and I couldn't be able to create a failing test case. Here is a patch with a test. ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

2017-03-17 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch that tweaks some exception messages and adds logging.error() calls in GitHubHandler class. ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

2017-03-17 Thread Berker Peksag
Berker Peksag added the comment: I believe the 400 status code comes from one of the "raise Reject()" lines in roundup/github.py. I will try to add some descriptive messages to them to help debug the issue. ___ PSF Meta Tracker