Anish Shah added the comment:
I can work on this! :)
--
nosy: +anish.shah, maciej.szulik
status: unread -> chatting
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/m
Anish Shah added the comment:
Hi Ezio, can you tell me which webhook was triggered? Was it pull request
event?
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
I tested the latest patch on the my repository and it is working properly.
:)
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
Hi, on this link http://bugs.python.org/pull_request, I am getting a textbox
where I can delete/edit entries. Do we want this? I am not sure.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
Anish Shah added the comment:
I have updated the patch.
> We do need proper error handling, still.
The problem is "err" variable has stdout of that process. So, even if we
change/push branch, it will be non-empty. Any idea how to solve this problem?
One more thing, if we create
Anish Shah added the comment:
Great! :)
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
I have updated the patch :)
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue592>
_
Anish Shah added the comment:
> It would be nice to have the user configurable, not admin hardcoded.
By configurable, do you mean creating an env var?
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za&
Anish Shah added the comment:
I have updated the patch.
now, GitHub name, comment and link to the PR will be posted on b.p.o
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
I have updated the patch so that it applies cleanly.
I will add the suggestions in a few days.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
I have updated the patch with all three changes
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
Oops. Got it now. I will include the changes.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
new tests:
- secret key missing
- Github event missing in header
- non json body
- multiple references in PR body
- CREATE_ISSUE is not set and no issue is reference in PR
- if github field of user is set, then PR/issue is assigned to that user or
else anonymous
Anish Shah added the comment:
> * multiple fixes both in title like you have in pullrequestevent3.txt
but also in title
Sorry. I didn't get you. You mean, same tests for PR body, right?
> Is vulnerable to other exceptions, I'm a lazy person and I test your code
with following
>
Anish Shah added the comment:
Should I throw Reject exception if 'SECRET_KEY' is not set as an environment
variable too?
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
I have updated the patch
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Anish Shah added the comment:
I have added few things to this updated patch:
- load JSON while extracting
- user who creates GitHub PR will be assigned as PR author on bpo if we find
github name on bpo or else "anonymous"
- if issue is not referenced in PR title or body and an e
Anish Shah added the comment:
Description about this patch:
This patch has a handler to handle GitHub PR review/diff comments event.
First, it checks if any b.p.o issue is linked to this PR or not. Then, it
checks when was the last time a "GitHub" msg was added. If there are no G
Anish Shah added the comment:
> Maybe put the code in with a switch so we can turn it on and off? I'm
pretty sure we're going to want it, but not positive.
Sorry. I didn't get you. What do you want to turn on and off?
___
PSF Meta Trac
Anish Shah added the comment:
Thank you for the review. I will update the patch.
@David
I can create a new issue if there's no issue number mentioned.
But as Brett said that someone might forget to add issue number. I'm
currently checking for issue id in PR title, body and issue comments. So
<pre>
Anish Shah added the comment:
I have updated the patch. :)
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<<a rel="nofollow" href="http://psf.upfronthosting.co.za/roundup/meta/issue587
Anish Shah added the comment:
I have updated the patch according to reviews suggested by @maciej.szulik and
@berker.peksag
Description:-
This patch adds a new table "pull_request" which is used to save GitHub PR URLs.
URL can be added manually using "GitHub PR" f
Anish Shah added the comment:
@berker.peksag
Thank you for the review. I will make those changes.
> Also, I'm not fan of such a manual work. I would prefer to have a JSON
> endpoint > which queries open pull requests on python/cpython and match if
> the title of a > pull r
New submission from Anish Shah:
This is an initial patch to convert .patch/.diff files to GitHub Pull Requests.
--
files: patch-to-pr.diff
messages: 3055
nosy: anish.shah, maciej.szulik
priority: feature
status: in-progress
title: Convert patches to GitHub Pull Request
24 matches
Mail list logo
