[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Anish Shah added the comment: Great! :) ___ PSF Meta Tracker ___

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Maciej Szulik added the comment: LGTM ___ PSF Meta Tracker ___

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Anish Shah added the comment: I have updated the patch :) ___ PSF Meta Tracker ___diff --git

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Anish Shah added the comment: > It would be nice to have the user configurable, not admin hardcoded. By configurable, do you mean creating an env var? ___ PSF Meta Tracker

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Anish Shah added the comment: I have updated the patch. now, GitHub name, comment and link to the PR will be posted on b.p.o ___ PSF Meta Tracker

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Anish Shah added the comment: I have updated the patch so that it applies cleanly. I will add the suggestions in a few days. ___ PSF Meta Tracker

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o (depends on issue590)

Maciej Szulik added the comment: Anish, can you please update the roundup part so that it applies cleanly and apply all the suggestions discussed on core-workflow mailing list? ___ PSF Meta Tracker

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

Anish Shah added the comment: Description about this patch: This patch has a handler to handle GitHub PR review/diff comments event. First, it checks if any b.p.o issue is linked to this PR or not. Then, it checks when was the last time a "GitHub" msg was added. If there are no GitHub msg for

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

Berker Peksag added the comment: Maciej, that sounds good to me but I agree with David. This needs to be discussed on the core-workflow list. It would be nice to have a some sort of mockup or flowchart to see what kind of information will be displayed in these combined comments. It's a bit

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

Maciej Szulik added the comment: @David, @Berker the original idea of this patch is to entirely ignore gh notifications and have that information available in bpo. Moreover, instead of a bunch of comments you should get one combined information that the review has be posted with a link to the

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

R David Murray added the comment: If github batched the review comments, what we would want (what we've wanted for a long time from reitveld) is a note posted to b.p.o that there *are* review comments. But since github does *not* batch review comments, posting every comment (especially

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

R David Murray added the comment: But, really, this level of discussion should take place on the workflow mailing list, not in the context of the patch. ___ PSF Meta Tracker

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

New submission from Berker Peksag: Thanks for the patches! :) GitHub already spams every single comment made on a pull request and this will make it worse. I'm -1 on this. It's fine if other core developers want to backup review comments, but it shouldn't be shown on bugs.python.org by