Eric Snow added the comment:
The main goal here is to make it easier for folks to move patches to GitHub.
So there are a number of things we can do to help, which mostly build on one
another:
1. determine a git commit hash on which a patch applies cleanly
* best guess based on date (i.e.
Maciej Szulik added the comment:
> I have updated the patch.
Thank you, the patch itself LGTM.
> > We do need proper error handling, still.
> The problem is "err" variable has stdout of that process. So, even if we
> change/push branch, it will be non-empty. Any idea how to solve this
Anish Shah added the comment:
I have updated the patch.
> We do need proper error handling, still.
The problem is "err" variable has stdout of that process. So, even if we
change/push branch, it will be non-empty. Any idea how to solve this problem?
One more thing, if we create PR using API,