[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Nick Coghlan added the comment: Awesome, thank you all! ___ PSF Meta Tracker ___ ___ Tracke

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ned Deily added the comment: Thanks, Ezio! Having those messages there really makes a big difference! ___ PSF Meta Tracker ___ ___

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: I successfully redelivered all the requests, so all known bugs should be fixed now. -- assignedto: -> ezio.melotti status: in-progress -> resolved ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: Other bug fixed: https://hg.python.org/tracker/roundup/rev/1da702d3cf41 Maciej also fixed https://hg.python.org/tracker/roundup/rev/8c49b7b2bc8f and https://hg.python.org/tracker/roundup/rev/e58c841100f8 I'm still going through all the failed requests and sending

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: While going through the other failed request, I found and fixed another bug: https://hg.python.org/tracker/roundup/rev/f04116acd3d8 While fixing that bug and reading the code I also noticed another unrelated bug -- Maciej is taking care of it. There's also anothe

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: I agree with Ned. Thanks, Ezio! ___ PSF Meta Tracker ___ _

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ned Deily added the comment: My instinct would be to deliver them. Having a reasonably accurate record of pushes/commits in a b.p.o has proven to be crucially important to me over the years when I have to go back and investigate the history of some problem. ___

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: I asked for access, and looked at the payloads. The 4 errors mentioned in the previous message are just push messages that don't reference any bpo issue, so they are not really errors (and they were delivered correctly). I found older payloads that failed with

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: I think you need to be an administrator on that repo to see the payloads. ___ PSF Meta Tracker ___ ___

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: I've been looking at the logs overnight and these are the few errors I got so far (timestamps should be UTC): [24/Mar/2017 08:23:44] "POST /tracker/pull_request HTTP/1.1" 200 - ERROR:root:zero messages created for 31bb6800-106b-11e7-91cd-85bcd980655d [24/Mar/201

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Maciej Szulik added the comment: I've added more logging: https://hg.python.org/tracker/roundup/rev/b5c6f372b227 ___ PSF Meta Tracker ___

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Brett C. added the comment: First, don't worry about the x-github-signature missing. It's the last line of the headers shown in the GitHub UI and so it's quite possible i just botched my copy-and-paste. And I will upload the headers, 400 response, and JSON body of the most recently failed mes

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: Note that there is an open issue for the committer name thing: http://psf.upfronthosting.co.za/roundup/meta/issue619 ___ PSF Meta Tracker ___

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Maciej Szulik added the comment: Brett, can I ask you to send me directly (or attach here) some of those rejected requests? Based on the current one I don't see anything suspicious, but maybe I'm overlooking something... ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Maciej Szulik added the comment: Brett, the most worrying thing is missing `X-Hub-Signature` header in the request from http://psf.upfronthosting.co.za/roundup/meta/msg3281. I've uploaded tweaked patch from Berker but I've mostly switched to logging, we don't want to simplify hacking our track

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: I converted Brett's payload example to a test case and I couldn't be able to create a failing test case. Here is a patch with a test. ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: Here is a patch that tweaks some exception messages and adds logging.error() calls in GitHubHandler class. ___ PSF Meta Tracker _

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: I believe the 400 status code comes from one of the "raise Reject()" lines in roundup/github.py. I will try to add some descriptive messages to them to help debug the issue. ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ned Deily added the comment: Anything we can do to expedite this? It's a real problem with merge/commit information not making it into the bpo issues (other than the list of PR requests). -- nosy: +ned.deily priority: bug -> critical __

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Nick Coghlan added the comment: https://github.com/python/cpython/pull/169 is another case where the "merged" status updated appeared on http://bugs.python.org/issue29537, but there was no notification comment. -- nosy: +ncoghlan ___

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Brett C. added the comment: No notifications for two PRs on https://bugs.python.org/issue29455. I checked the webhook payload for the 3.6 commit and GitHub got a 400: Connection: close Content-Length: 0 Content-Type: text/html; charset=utf-8 Date: Fri, 03 Mar 2017 20:58:19 GMT Server: BaseHTTP/

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: Update: It looks like it sometimes works for 3.6 branch: * http://bugs.python.org/issue28893#msg288853 (2017-03-03 06:16) But not for master branch: * https://bugs.python.org/issue9303#msg288877 (2017-03-03 13:11) __

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: See https://github.com/python/cpython/commit/0dadf56737f591c83d18db5e445960d39448583e for example. The commit message contains bpo-29655 and there should be a comment similar to http://psf.upfronthosting.co.za/roundup/meta/msg3247 at https://bugs.python.org/is

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: I can reproduce this again, reopening. -- status: done-cbb -> chatting ___ PSF Meta Tracker _

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Maciej Szulik added the comment: Yeah, as soon as I fix the local testing of those things I'll get back to having 4-digit requirement for bpo issues, that should additionally save us from unnecessary errors, like the one above. ___ PSF Meta T

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: ISTM that best way to fix this is to just ignore all the (#NNN) at the end of the commit message. The try/except should also stay to avoid failures in case of typos or other extraneous ids. If the commit message references other PRs directly, it might cause fal

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Brett C. added the comment: It's delivery ID 6d377980-f2ea-11e6-8db5-e3e11d869c19 and a re-delivery worked! ___ PSF Meta Tracker ___ __

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: I pushed the try/except fix in https://hg.python.org/tracker/roundup/rev/1e58dddad971 I don't have a delivery_id, but the event was pushed almost 3h ago, around 19:18:56 UTC. See https://mail.python.org/pipermail/python-bugs-list/2017-February/326183.html If yo

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: > Is the PR id always automatically added at the end of the commit message, > between (...)? Yes, but backport PRs can have titles like Fix some sphinx warnings (#9) (#81) #9 is the original PR number and #81 is the backport PR number. See: https://github

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Ezio Melotti added the comment: The commit message includes the pull request id, and it got accidentally captured by the regex that looks for issue numbers. The code doesn't check if the issue id exists, and that caused the failure. An easy fix is to add a try/except, but once we reach PR #10

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Brett C. added the comment: Re-sending a webhook event is easy ... if I can figure out which one to resend. :) There are tons of events going on so I need to know the delivery_id to easily find the event to resend. ___ PSF Meta Tracker

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: > Note that "Mark Dickinson added the comment" should be "Roundup Robot added > the comment". Ezio told me that this was an intentional change. Sorry for the noise. Brett, is there an easy way to resend payloads so we can debug this? -- nosy: +brett.ca

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

Berker Peksag added the comment: I got an email for http://bugs.python.org/issue29534 Mark Dickinson added the comment: New changeset 6d1dece06d13a7d40637e07b2c79f34aab368766 by Mark Dickinson in branch 'master': Fixed #29534 - _decimal difference with _pydecimal (#65) https://github.com/pyth

[Tracker-discuss] [issue613] Commits notifications don't show up on bugs.p.o

New submission from Berker Peksag: See http://bugs.python.org/issue29438#msg287733 for example. All PRs have been correctly set bpo- in the ir commit messages. -- messages: 3246 nosy: berker.peksag, ezio.melotti, maciej.szulik priority: bug status: unread title: Commits notification