Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Martyn Russell
Jamie McCracken wrote: On Tue, 2008-09-02 at 12:23 +0100, Martyn Russell wrote: Jamie McCracken wrote: Could we also reduce memory usage by not statically linking to the private libs libtracker-common and libtracker-db? Those libraries should not be available for public use. Before doing so,

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Martyn Russell
Jamie McCracken wrote: On Tue, 2008-09-02 at 12:23 +0100, Martyn Russell wrote: Jamie McCracken wrote: Could we also reduce memory usage by not statically linking to the private libs libtracker-common and libtracker-db? Those libraries should not be available for public use. Before doing so,

Re: [Tracker] tracker-indexer does not index all files

2008-09-03 Thread Martyn Russell
Jamie McCracken wrote: On Tue, 2008-09-02 at 12:14 +0100, Martyn Russell wrote: Jamie McCracken wrote: Another potential crasher - unlike trunk get_file_content does no utf-8 validation and also if file is bigger than MAX_TEXT cuts it off which is likely to not land on a valid utf-8 word

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Martyn Russell
Jamie McCracken wrote: trunk only checks directories (If a file in a directory is modified then the directories mtime is also altered so no need to check every file) hence startup is much faster. Note: the mtime of the parent directory ONLY is updated. This is not recursive. So if you have

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Martyn Russell
Hi, So I have been reading up on the things that are remaining for merging. This is the list I have so far which I will be working on: * Check the move files/directories issue. I *think* it works. * Fix the get_file_contents() function so it checks for #13 in the first 64Kb. * Make private

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Jamie McCracken
On Wed, 2008-09-03 at 12:34 +0100, Martyn Russell wrote: Jamie McCracken wrote: trunk only checks directories (If a file in a directory is modified then the directories mtime is also altered so no need to check every file) hence startup is much faster. Note: the mtime of the parent

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Jamie McCracken
On Wed, 2008-09-03 at 12:34 +0100, Martyn Russell wrote: Hi, So I have been reading up on the things that are remaining for merging. This is the list I have so far which I will be working on: * Check the move files/directories issue. I *think* it works. check the new directory name can be

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Martyn Russell
Jamie McCracken wrote: trackerd should just pass directories at startup and let the indexer work out what to process. Dbus is not optimised for passing large number of strings. Can the current design easily accommodate this? DBus' optimisation is not an issue here. I can send ALL of my files

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Jamie McCracken
On Wed, 2008-09-03 at 10:32 -0400, Jamie McCracken wrote: On Wed, 2008-09-03 at 12:34 +0100, Martyn Russell wrote: Hi, So I have been reading up on the things that are remaining for merging. This is the list I have so far which I will be working on: * Check the move

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Philip Van Hoof
On Wed, 2008-09-03 at 15:31 +0100, Martyn Russell wrote: Jamie McCracken wrote: trackerd should just pass directories at startup and let the indexer work out what to process. Dbus is not optimised for passing large number of strings. Can the current design easily accommodate this? DBus'

Re: [Tracker] more issues with indexer-split

2008-09-03 Thread Jamie McCracken
On Wed, 2008-09-03 at 16:35 +0200, Philip Van Hoof wrote: On Wed, 2008-09-03 at 15:31 +0100, Martyn Russell wrote: Jamie McCracken wrote: trackerd should just pass directories at startup and let the indexer work out what to process. Dbus is not optimised for passing large number of