Re: [SDO] questions about support for Enumeration facet

2008-01-10 Thread Amita Vadhavkar
Please see the 2 patches attached to JIRA-1360 and give comments. Regards, Amita On Jan 1, 2008 4:11 PM, Amita Vadhavkar [EMAIL PROTECTED] wrote: Hi Kelvin, Yes , below is the change I tried to see to make a Property of type Strings, in DataObjectUtil - protected static Property

Re: [SDO] questions about support for Enumeration facet

2008-01-10 Thread kelvin goodson
Amita, thanks for the patches. I've had a good look, but still haven't made up my mind which way to go. First off is I think that you should not have different test cases in your patches. I believe the test case should always test for 3 enumerations, and the patch using the

Re: [SDO] questions about support for Enumeration facet

2008-01-01 Thread Amita Vadhavkar
Hi Kelvin, Yes , below is the change I tried to see to make a Property of type Strings, in DataObjectUtil - protected static Property getGlobalProperty(HelperContext hc, String uri, String name) { Property property; if (ExtendedMetaData.ANNOTATION_URI.equals(uri)) { if

Re: [SDO] questions about support for Enumeration facet

2007-12-21 Thread Amita Vadhavkar
This looks quite easy with one small difference in the behavior - For enum like below - simpleType name=ExampleRating restriction base=string enumeration value=/ enumeration value=Good/ enumeration value=Bad/ /restriction /simpleType 1) below returns size as 3

Re: [SDO] questions about support for Enumeration facet

2007-12-21 Thread kelvin goodson
Amita, I'm a little unclear what you have changed. Have you altered the enumeration facet Property type to commonj.sdo.{Strings}? Regards, Kelvin. On 21/12/2007, Amita Vadhavkar [EMAIL PROTECTED] wrote: This looks quite easy with one small difference in the behavior - For enum like below -

Re: [SDO] questions about support for Enumeration facet

2007-12-17 Thread kelvin goodson
Amita, I think Frank's note in this thread is key to the solution, in that the line ... return SDOUtil.createFromString(property.getType(), value); will create a List if the type of the Property is set to commonj.sdo{Strings} Regards, Kelvin. On 14/12/2007, Amita Vadhavkar [EMAIL

Re: [SDO] questions about support for Enumeration facet

2007-12-12 Thread kelvin goodson
It occurred to me that there's a bit of a knack to debugging into EMF code, so I just wrote an FAQ to describe how to do this. Comments are welcome on its clarity or accuracy. Regards, Kelvin. On 11/12/2007, kelvin goodson [EMAIL PROTECTED] wrote: Amita, It feels like option 1 is the easy

Re: [SDO] questions about support for Enumeration facet

2007-12-12 Thread kelvin goodson
By the way, until the wiki has been used to update the websitre then the FAQ can be seen at http://cwiki.apache.org/confluence/display/TUSCANY/Tuscany+SDO+Java+-+FAQ Kelvin. On 12/12/2007, kelvin goodson [EMAIL PROTECTED] wrote: It occurred to me that there's a bit of a knack to debugging

[SDO] questions about support for Enumeration facet

2007-12-11 Thread Amita Vadhavkar
Hi, I tried TUSCANY-1360 related to enumeration facet. Below is the summary of what was discussed so far and a few questions. - 1) One way to do this is - public

Re: [SDO] questions about support for Enumeration facet

2007-12-11 Thread kelvin goodson
Hi Amita, thanks for looking at this. I'm a bit surprised, on digging a little way in, that the enumeration Property is isMany==false. I'll dig a bit further, but I had expected to be able to find the Property named enumeration and get a list of entries. Kelvin. On 11/12/2007, Amita

Re: [SDO] questions about support for Enumeration facet

2007-12-11 Thread Frank Budinsky
I think it should be isMany=false but of type commonj.sdo{Strings}. Then get() or getList() would return ListString. Only getString() would convert to the space-separated value we're returning today. Frank. [EMAIL PROTECTED] wrote on 12/11/2007 06:44:22 AM: Hi Amita, thanks for looking

Re: [SDO] questions about support for Enumeration facet

2007-12-11 Thread kelvin goodson
Amita, It feels like option 1 is the easy way to do things, and option 2 is the right way given the introduction of instance properties on metadata provided for this purpose (but doesn't currently work). Here's the results of my digging around. Let's start with what I found last since it might