A few times recently (most recently in my email on Github) I have mentioned
that I am more interested in getting more people to review Twisted tickets than
in getting more people to write new patches to Twisted.
Based on some feedback that other contributors have sent me privately, I'm
afraid t
> So when the code is ready, the feature branch including any accumulated
commits (history) will
> get merged - and not a clean diff against the main repo?
I'm very far from being a git expert. In fact, I'm kind of the opposite -
git and I have a stormy relationship and everyone has to tell me wha
Terry,
thanks alot for your detailed explanation of a workflow. For me, that sounds
reasonable and workable.
>At some point everyone who's interested will have contributed to the
>discussion, to the code, and signed off. Then you merge it, using the web UI
So when the code is ready, the feat
Hi,
I think moving to github will be a huge win for the Twisted project,
and all the migration/integration issues are manageable.
I would recommend you keep two things in mind:
(1) I am a member of the FreeBSD project, and am mentoring a Google Summer
of Code student.
I pushed the student
The general workflow that's being described is:
- You open an issue for all bugs, enhancements, etc.
- When someone starts working on one of these, they create a branch (we
use descriptive branch names and put - at the end, with the issue
number).
- When the branch reaches the point where t
in general: +1 for this
> Finally, my own minor concern: Github has no notion of a "code review" as a
> unit of work. A pull request is just "open" until it is "closed".
>
I _think_ the following is true (if so, I find that strange) - pls correct me
if I'm wrong:
A pull request is not tied t
Thanks for working on this!
Here are the points where I can help:
1. We'd need some consensus (hence this message).
I am still new to Twisted and only sent a few patched, but I am
looking forward for sending reviews in GitHub or BitButcket, any or
them is better than the current read-only SVN b
