Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-22 Thread Amber Brown
Worth noting that the converted hybrid classes are opt in - by default they are a no-op. This means you can run under TWISTED_NEWSTYLE=1 for your tests to ensure that when all the classes go natively new style, everything works, but leave it off in prod. Then in a later release, all of these

Re: [Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-22 Thread Glyph
> On Mar 22, 2016, at 12:33 PM, L. Daniel Burr wrote: > > Hi all, Hi Daniel, > I tried to comment on the ticket, but SpamBayes rejected it as spam. The spam-monitoring queue is empty, which means another admin probably got to this before I did. But when I plugged the

Re: [Twisted-Python] Sending disconnect messages to clients

2016-03-22 Thread Chris Norman
OK... ignore me. I made your test program and it worked fine. So I tried connecting to my server with telnet and saw the expected message... So I checked the error function which should have been called on the client with the particular message to see it was as good as pass... Sorry for all

Re: [Twisted-Python] Sending disconnect messages to clients

2016-03-22 Thread L. Daniel Burr
Hi Chris, On March 22, 2016 at 3:09:08 PM, Chris Norman (chris.norm...@googlemail.com) wrote: Hi Daniel, [SNIP] Actually it's been added to the callback. I think my mail client wrapped the lines, but issue self.transport.LoseConnection() is the comment, so self.deferred_disconnect is added

Re: [Twisted-Python] Sending disconnect messages to clients

2016-03-22 Thread Chris Norman
Hi Daniel, On 22/03/2016 19:49, L. Daniel Burr wrote: Hi Chris, On March 22, 2016 at 2:42:14 PM, Chris Norman (chris.norm...@googlemail.com ) wrote: Hi all, I'm sure I asked this question before, but I can't find any answers on google, and I've changed

Re: [Twisted-Python] Sending disconnect messages to clients

2016-03-22 Thread L. Daniel Burr
Hi Chris, On March 22, 2016 at 2:42:14 PM, Chris Norman (chris.norm...@googlemail.com) wrote: Hi all,  I'm sure I asked this question before, but I can't find any answers on  google, and I've changed my work flow a bit now, so thought it was worth  re-asking.  So on my server's protocol, I

[Twisted-Python] Sending disconnect messages to clients

2016-03-22 Thread Chris Norman
Hi all, I'm sure I asked this question before, but I can't find any answers on google, and I've changed my work flow a bit now, so thought it was worth re-asking. So on my server's protocol, I have a send method. This allows me to pass arguments which get sent off to the client in the right

[Twisted-Python] Ticket #8244 (old-style decorator)

2016-03-22 Thread L. Daniel Burr
Hi all, I tried to comment on the ticket, but SpamBayes rejected it as spam. As a person who runs twisted apps via Pypy whenever possible, I wanted to point out that this ticket may result in a performance regression: according to  http://pypy.org/performance.html, "Classes that inherit from