[Twisted-Python] Captcha warnings preventing me from submitting changes to Trac ticket

2016-06-30 Thread Craig Rodrigues
Hi, I tried to modify a Trac ticket, but when I tried to submit the changes, I got a Captcha warning that prevented it. When I clicked on the checkbox, "I am not a robot" and tried to re-submit, the Captcha warning re-appeared and blocked the submission. Can someone please fix this? -- Craig

Re: [Twisted-Python] Coverage exceptions

2016-06-30 Thread Craig Rodrigues
Hi, The conversation about coverage exceptions came up due to this: https://github.com/twisted/twisted/pull/261 I have that up to 97.87% of patch coverage. I cannot merge it because the codecov integration with GitHub is currently configured to not accept patches which don't have 100% patch

Re: [Twisted-Python] Coverage exceptions

2016-06-30 Thread Jean-Paul Calderone
On Thu, Jun 30, 2016 at 6:25 PM, Glyph Lefkowitz wrote: > > On Jun 30, 2016, at 04:13, Jean-Paul Calderone > wrote: > > On Thu, Jun 30, 2016 at 6:43 AM, Adi Roiban wrote: > >> Hi, >> >> Recently we have introduced a hard check

Re: [Twisted-Python] Fwd: More tests running on Python 3

2016-06-30 Thread Glyph Lefkowitz
> On Jun 30, 2016, at 17:09, Craig Rodrigues wrote: > > Hi, > > I looked at these two Travis builds on Linux > > DATE BUILD > = > June 3, 2016https://travis-ci.org/twisted/twisted/builds/135219940 >

[Twisted-Python] Fwd: More tests running on Python 3

2016-06-30 Thread Craig Rodrigues
Hi, I looked at these two Travis builds on Linux DATE BUILD = June 3, 2016https://travis-ci.org/twisted/twisted/builds/135219940 June 30, 2016https://travis-ci.org/twisted/twisted/builds/141426367 I noticed: DATE Tests on Python 2.7

Re: [Twisted-Python] qt5 and twisted, reactor already installed, python 2.x

2016-06-30 Thread meejah
Glyph Lefkowitz writes: > Yes. Unfortunately, lots of places do import the reactor directly > today, but we have long since decided that this is a bad way to do > things. This is why e.g. react >

[Twisted-Python] FreeBSD buildbots down?

2016-06-30 Thread Craig Rodrigues
Hi, The FreeBSD buildbots seem to be down since May 26. https://buildbot.twistedmatrix.com/boxes-all Any ideas as to what is wrong? -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com

Re: [Twisted-Python] Coverage exceptions

2016-06-30 Thread Glyph Lefkowitz
> On Jun 30, 2016, at 04:13, Jean-Paul Calderone > wrote: > > On Thu, Jun 30, 2016 at 6:43 AM, Adi Roiban > wrote: > Hi, > > Recently we have introduced a hard check of 100% coverage for all changes. > This is done via

Re: [Twisted-Python] qt5 and twisted, reactor already installed, python 2.x

2016-06-30 Thread Glyph Lefkowitz
> On Jun 30, 2016, at 03:49, steven meier wrote: > > >> You have to put the qt5reactor installation at the very top of the >> very first file that you run. What's happened here is that you >> imported some Twisted code that did 'from twisted.internet import >> reactor'

Re: [Twisted-Python] Coverage exceptions

2016-06-30 Thread Jean-Paul Calderone
On Thu, Jun 30, 2016 at 6:43 AM, Adi Roiban wrote: > Hi, > > Recently we have introduced a hard check of 100% coverage for all changes. > This is done via coverage + codecov + github protected branches. > > Now, if your patch is not 100% covered github will not let you merge it.

Re: [Twisted-Python] qt5 and twisted, reactor already installed, python 2.x

2016-06-30 Thread steven meier
> You have to put the qt5reactor installation at the very top of the > very first file that you run. What's happened here is that you > imported some Twisted code that did 'from twisted.internet import > reactor' at the top level, which unfortunately far too many modules > do, before you

[Twisted-Python] Coverage exceptions

2016-06-30 Thread Adi Roiban
Hi, Recently we have introduced a hard check of 100% coverage for all changes. This is done via coverage + codecov + github protected branches. Now, if your patch is not 100% covered github will not let you merge it. See for example this change:

Re: [Twisted-Python] qt5 and twisted, reactor already installed, python 2.x

2016-06-30 Thread steven meier
On Wed, 2016-06-29 at 16:01 -0700, Glyph wrote: > > > On Jun 29, 2016, at 15:39, steven meier > > wrote: > > > > > > here is my code: > > when importing get_main_page i get the error above... > > > > import sys > > from PyQt5 import QtWidgets > > from untitled import