[Twisted-Python] Python 3 code coverage not working?

Hi, I submitted this pull request: https://github.com/twisted/twisted/pull/224 and codecov is saying that only 66.67% of the patch is covered because it is not hitting the Python 3 specific block:

Re: [Twisted-Python] Script which uploads coverage results to codecov failed, but reported success?

> On Jul 3, 2016, at 00:27, Adi Roiban wrote: > > I no longer have access to the Win7 VNC as it looks like the password was > changed. The password hasn't been changed, so I'm not sure why you're having trouble accessing it.

Re: [Twisted-Python] Coverage exceptions

On Sun, Jul 3, 2016 at 9:10 AM, Glyph Lefkowitz wrote: > > For now, let's just bite the bullet and require 100% patch coverage from > here on out. If we hit a really nasty case where it really *is* a > significant investment of effort, then maybe we can revisit this

Re: [Twisted-Python] Script which uploads coverage results to codecov failed, but reported success?

A bit of an aside... but both personally and in several businesses I work with, I've use Lastpass to manage passwords. Because the passwords are shared at the server, updated passwords are propagated to all users. It also has a really nice 2-factor option where your phone just offers you an

Re: [Twisted-Python] Coverage exceptions

On 3 July 2016 at 09:53, Tristan Seligmann wrote: > The tests directories can simply be excluded in coverage.py (or codecov), > I don't think there's any need to do something more complicated than that. > > That is, don't report coverage at all for the test code? I

Re: [Twisted-Python] Twisted 16.3.0 Prerelease 2 Announcement

> AFAIK this is a known issue : Ah thanks, that's ok. One other thing I noticed a propos HTTP 2 is that it seems that reading relatively large file results in error: "priority.priority.MissingStreamError: 'Stream 1 not in tree'". I created simple gist to recreate this issue see here:

Re: [Twisted-Python] Twisted 16.3.0 Prerelease 2 Announcement

HTTP2 support sounds really exciting. > Please let me know if you have any issues, as well as if you don't! If everything works well, that's a good thing for me to know :) I played around with this today and found out that the command you recommend: > pip install -U

Re: [Twisted-Python] Coverage exceptions

The tests directories can simply be excluded in coverage.py (or codecov), I don't think there's any need to do something more complicated than that. While I agree that 100% test coverage is an ideal worth aspiring to, I think getting there from the current state is going to be a large amount of

Re: [Twisted-Python] Coverage exceptions

Hi, What decision should be made based on the feedback sent so far? Should we disabled the codecov coverage enforcement for 100% coverage for a patch as it also blocks missing coverage in a test? If we want to enforce only implementation code, then we need to update the tests to send separate