Re: [Twisted-Python] Coverage exceptions

2016-07-04 Thread Tom Prince
On Sun, Jul 3, 2016 at 8:13 AM, Adi Roiban wrote: > I would prefer to see the coverage reports for tests, even if we don't > enforce 100% coverage. Is a quick way to check that the test is executed on > at least one builder. I think this is definitely desirable. > We are

Re: [Twisted-Python] Twisted 16.3.0 Prerelease 2 Announcement

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 3:15 AM, Paweł Miech wrote: > HTTP2 support sounds really exciting. > > > Please let me know if you have any issues, as well as if you don't! If > everything works well, that's a good thing for me to know :) > > I played around with this today and found

Re: [Twisted-Python] Buildbot upgrade to latest eight branch

2016-07-04 Thread Adi Roiban
On 4 July 2016 at 11:06, Cory Benfield wrote: > > > On 2 Jul 2016, at 23:42, Adi Roiban wrote: > > > > With this change, Buildbot should have a closer behavior to Travis-CI. > That is, it will automatically start the builders and will report the build >

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Adi Roiban
On 4 July 2016 at 12:27, Craig Rodrigues wrote: > On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > >> >> >> Only the modules (including the test modules) from dist3.py are executed >> on Python3 >>

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > > > Only the modules (including the test modules) from dist3.py are executed > on Python3 > https://github.com/twisted/twisted/blob/trunk/twisted/python/dist3.py > > In the header of that file you can see > > # -*-

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Mon, Jul 4, 2016 at 3:30 AM, Adi Roiban wrote: > > > Is it possible to add the actual invocation of setup.py to coverage? >> > > > That seems like a hole that the actual invocation of setup.py that does >> the build and install >> > > is not part of the coverage reporting.

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Adi Roiban
On 4 July 2016 at 08:00, Craig Rodrigues wrote: > > > On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > >> >> >> >> On 4 July 2016 at 00:43, Craig Rodrigues wrote: >> >>> Hi, >>> >>> I submitted this pull request: >>>

Re: [Twisted-Python] Twisted 16.3.0 Prerelease 2 Announcement

2016-07-04 Thread Cory Benfield
Good catch Paweł. I have opened this issue as Twisted issue #8558: https://twistedmatrix.com/trac/ticket/8558 . I believe I know what the fix is and it’s fairly simple, so I’ll try to address this quickly and see if we can ship the fix in either the

Re: [Twisted-Python] Buildbot upgrade to latest eight branch

2016-07-04 Thread Cory Benfield
> On 2 Jul 2016, at 23:42, Adi Roiban wrote: > > With this change, Buildbot should have a closer behavior to Travis-CI. That > is, it will automatically start the builders and will report the build > results in GitHub PR. I spotted this in action today before I’d read this

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > > > > On 4 July 2016 at 00:43, Craig Rodrigues wrote: > >> Hi, >> >> I submitted this pull request: >> https://github.com/twisted/twisted/pull/224 >> >> and codecov is saying that only 66.67% of the

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Adi Roiban
On 4 July 2016 at 00:43, Craig Rodrigues wrote: > Hi, > > I submitted this pull request: > https://github.com/twisted/twisted/pull/224 > > and codecov is saying that only 66.67% of the patch is covered because it > is not hitting the Python 3 specific block: > >