Re: [Twisted-Python] Developer docs should be updated on wiki when steps changed in code?

2021-03-03 Thread Glyph
> On Mar 1, 2021, at 5:30 AM, Adi Roiban wrote: > > > > On Wed, 3 Feb 2021 at 18:09, Glyph > wrote: > > [snip] > > I can't quickly find the place where we agreed to this, but I think several > years ago at this point we had a discussion about moving all

Re: [Twisted-Python] Klein?

2021-03-03 Thread Glyph
> On Mar 1, 2021, at 12:51 PM, Robert DiFalco wrote: > > Is this the right place to ask klein questions? Absolutely, it's a Twisted org project. > I'm writing a metrics plugin for Klein and I can't figure out how to inject a > metrics handler so that I can get route, path, duration, and

Re: [Twisted-Python] [Twisted-web] Twisted 21.2.0 Release Announcement

2021-03-03 Thread Glyph
> On Feb 28, 2021, at 2:27 AM, Craig Rodrigues wrote: > > On behalf of Twisted Matrix Laboratories, I am honored to announce the > release of Twisted 21.2.0! Thank you so much for shepherding this release to completion, Craig. It's so good to have a recent release out in the world again!

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

2021-03-03 Thread Craig Rodrigues
On Wed, Mar 3, 2021 at 7:18 AM Maarten ter Huurne wrote: > > Yes, as far as I know the intention is to reduce the amount of > infrastructure that has to be maintained by Twisted developers. > > Adi is doing the actual work for the migration; I only contribute > indirectly by reviewing PRs that

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Tobias Oberstein
but we have had enough difficulty keeping our CI configuration current based on what cloud provider is falling over this month ;-). Yes, CI seems to be universally one of those things that is conceptually simple but somehow takes hours and hours to maintain. Absolutely agreed, glad that it's

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Tobias Oberstein
on their end.  If initially, say, crossbar and matrix would like to work with us to set up some kind of repeatable pattern we can suggest to others, that would be great. ok, I'll take that to the team: https://github.com/crossbario/crossbar/issues/1867 tldr: we could run our CI in 2 sets,

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Richard van der Hoff
On 03/03/2021 18:47, Glyph wrote: I'll take this to the Synapse team to discuss further, but we could probably easily arrange for one of our CI runs to install Twisted trunk from git instead of pypi, which might be a good start. This is specifically the approach I'd really rather /not/ take

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Glyph
> On Mar 3, 2021, at 4:58 AM, Jean-Paul Calderone > wrote: > > Broadly, I agree. But not with this part. It seems like there is clearly a > trade-off that is better for everyone. The trade-off represented by #1298: > Breaks application code without providing any new functionality or fixing

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Glyph
> On Mar 3, 2021, at 8:25 AM, Richard van der Hoff wrote: > > > On 03/03/2021 08:07, Glyph wrote: >> >> If dependencies could start testing against Twisted trunk in some capacity, >> we could get notified close to when unintentionally breaking changes occur, >> and dependencies can let us

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Richard van der Hoff
On 03/03/2021 08:07, Glyph wrote: If dependencies could start testing against Twisted trunk in some capacity, we could get notified close to when unintentionally breaking changes occur, and dependencies can let us know well before the release happens, and we can either revert or they can

Re: [Twisted-Python] Release blocker: Use latest pydoctor release ?

2021-03-03 Thread Maarten ter Huurne
On Sunday, 28 February 2021 23:04:49 CET Craig Rodrigues wrote: > With respect to API docs, I am not as familiar with the whole process, > with how they are generated > and what are doing with readthedocs vs. docs on twistedmatrix.com. > API docs are generated and don't live in the source tree. >

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Jean-Paul Calderone
On Wed, Mar 3, 2021 at 3:08 AM Glyph wrote: > > On Mar 2, 2021, at 6:10 PM, Jean-Paul Calderone > wrote: > > Policy aside, this change doesn't seem like much of an improvement to me. > If I were to guess, I would guess the change was made to satisfy some check > Mypy is now being asked to make

Re: [Twisted-Python] Twisted v21.2.0 breaks Crossbar.io

2021-03-03 Thread Glyph
> On Mar 2, 2021, at 6:10 PM, Jean-Paul Calderone > wrote: > > Policy aside, this change doesn't seem like much of an improvement to me. If > I were to guess, I would guess the change was made to satisfy some check Mypy > is now being asked to make about Twisted. If that's the case, it