On Mon, Jun 14, 2021 at 05:25:42PM +0100, Peter Westlake wrote:
> Do we have any idea when the fix for "RecursionError with synchronous
> deferreds (#1549)" will appear in a release?
It's been merged to trunk, so it'll be in the next release... whenever
that is. Twisted tends to release about
On Saturday, May 1, 2021 1:58:45 AM PDT, Adi Roiban wrote:
We now have a fix for Twisted, but I think that this is a bug in PYPY 7.3.4
FYI I have reported this bug upstream.
https://foss.heptapod.net/pypy/pypy/-/issues/3451
Looks like we weren't the only project to run into this problem!
On Thursday, April 8, 2021 8:43:35 AM PDT, Barry Scott wrote:
We just added a patch to our twisted to prevent twisted from
doing idna validation.
_idnaBytes and _idnaText not convert from bytes to unicode
based on the type of
the provided arg.
We had to do this because there are domain names
TLDR: Twisted appears broken on PyPy 7.3.4 (aka "3.7.10")?
I don't have time right now to set up a PyPy-capable environment and try
to reproduce this, but perhaps someone does?
Long version:
Trunk has been broken since the last merge a week or so ago, but I
don't think the breakage is due to
at `Union`
type changes in the future.
Wim Lewis / w...@.org
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
There are a couple of Windows-specific PRs that I think could use a
review and merge. I don't have access to Windows or really know much
about it, or I'd do it.
The one I think is most pressing is Trac 9446 / PR 1025, which is a data
corruption bug when using the IOCP reactor:
I was just working on the documentation to fix Trac bug #5533, but I
have a question about intent. Right now, prepath and postpath are
undocumented; as best as I can tell, though, they are intended to be
public. Question is, are they part of the IRequest interface, or only of
the Request
Every project seems to have its own norms around this. When I have some code in
a
reviewable state, I will sometimes look for someone who has recently worked on
that piece of code or similar features and request a review from them, just to
get
the ball rolling. Is this a reasonable thing to
On Wed Oct 17 08:56:46 MDT 2018, Barry Scott wrote:
> Do you want a pull request for this fix or will you make this small
> change?
Twisted's contribution process is kind of rigid: every PR needs an
accompanying Trac ticket. If you file Trac tickets for these two issues
I'll make the PRs (or you
Scott, Barry wrote:
We are seeing a problem with poll being called very often and think that the
problem is in the timeout calculation.
I think you're right and that changing that line to use ceil() is a good
fix. It does mean that some timeouts might happen up to a millisecond
later than
Evilham writes:
Also, I recall this PR from early summer, which appears to have been
OK'd but is blocked by some failure in appveyor + buildbot:
https://github.com/twisted/twisted/pull/954
That one's mine. I've finally figured out the Twisted CI infrastructure
well enough to get things marked
On Sat, 7 Jul 2018 00:08:51 -0700, Glyph wrote:
> Can you include a link to to the issue in question?
Sorry, it was trac 9413 / github 991, which Tom Most helpfully merged
after I wrote. (Thanks Tom!)
> Speaking of which, it seems like you've been a fairly stalwart and
> patient external
I have a minor PR that was reviewed and labeled "cleared to land" a
while back, but three months have passed since then and it's still
unmerged. Is there something else I need to do to move this along, or
did it just fall through the cracks?
Wim.
___
On Mon, 18 Jun 2018 00:38:27 -0700, Glyph wrote:
> someone has availability, fewer tickets are in the queue waiting for their
> attention. Personally I can say that I'll have a look at this when my own
> availability permits (I'll try to get to it when I next do a review, but I'm
> not
> sure
Last year I submitted a bug+PR for a few new RR types for which I needed
support in Twisted. I got a lot of good review feedback from Adi Roiban, but he
eventually decided that someone more familiar with twisted.names should review
it, so the PR has just been sitting in github for the last
In PR 949 ("Remove “terrible hack” in t.c.ssh.filetransfer.FileTransferClient",
trac bug 9362) I'm removing an attribute of FileTransferClient which I'm pretty
sure was never intended to be public. Adi Roiban points out that this is
technically a compatibility-breaking change, though, and so it
16 matches
Mail list logo
