Re: [Twisted-Python] [BACKWARDS INCOMPATIBILITY] Making twisted.python.dist3 private

2016-08-16 Thread Glyph Lefkowitz
+1 from me as well. It's just weird that we ever made that module public in the first place. This change will make a lot harder to accidentally add some new code and make it python2 only (which we should not be doing at this point!). It will be encouraging progress-wise to visibly see this list

Re: [Twisted-Python] [BACKWARDS INCOMPATIBILITY] Making twisted.python.dist3 private

2016-08-16 Thread Adi Roiban
+1 for the change. Thanks! On 16 August 2016 at 08:20, Amber "Hawkie" Brown wrote: > Hi everyone, > > I am moving the dist3 from a whitelist to a blacklist, and that requires > changing the whole module's interface, which shouldn't be public anyway. > > You can get

[Twisted-Python] [BACKWARDS INCOMPATIBILITY] Making twisted.python.dist3 private

2016-08-16 Thread Amber "Hawkie" Brown
Hi everyone, I am moving the dist3 from a whitelist to a blacklist, and that requires changing the whole module's interface, which shouldn't be public anyway. You can get the branch here: https://github.com/twisted/twisted/pull/501 , it'll be available for a further week. The only concern for