Re: [Twisted-Python] Responding to PRs

2016-06-22 Thread Glyph
> On Jun 22, 2016, at 08:28, Adi Roiban wrote: > > > > On 14 June 2016 at 05:24, Glyph > wrote: > >> >> I'm the owner of txghbot. I hope it ends up being useful for Twisted! > > I strongly suspect that it will be

Re: [Twisted-Python] Responding to PRs

2016-06-22 Thread Adi Roiban
On 14 June 2016 at 05:24, Glyph wrote: > > > I'm the owner of txghbot. I hope it ends up being useful for Twisted! > > > I strongly suspect that it will be the official solution. Thanks so much > for doing this - the existence of this code is a structural expression of

Re: [Twisted-Python] Responding to PRs

2016-06-15 Thread Adi Roiban
On 12 June 2016 at 21:32, Itamar Turner-Trauring wrote: [snip] > So, maybe instead of telling new contribtutors "PRs won't be reviewed > without an issue, see contributor guidelines" it would be better to say > "Thanks for the PR! I opened an issue for this PR here

Re: [Twisted-Python] Responding to PRs

2016-06-14 Thread Adi Roiban
On 13 June 2016 at 22:35, Glyph wrote: > > On Jun 13, 2016, at 4:20 AM, Adi Roiban wrote: > > Is there a wiki page, a ticket or some place where switching to the > 'review queue' as GitHub PR list is discussed or brainstormed? > > > Thus far all

Re: [Twisted-Python] Responding to PRs

2016-06-13 Thread Glyph
> On Jun 13, 2016, at 8:33 PM, Mark Williams wrote: > > On Mon, Jun 13, 2016 at 02:35:01PM -0700, Glyph wrote: >> >> Thus far all discussion has been on the mailing list. I feel like putting >> it on the wiki would not be that useful, though; hopefully the discussion

Re: [Twisted-Python] Responding to PRs

2016-06-13 Thread Mark Williams
On Mon, Jun 13, 2016 at 02:35:01PM -0700, Glyph wrote: > > Thus far all discussion has been on the mailing list. I feel like putting it > on the wiki would not be that useful, though; hopefully the discussion will > continue for at most another month or two, and it's mostly just a question of

Re: [Twisted-Python] Responding to PRs

2016-06-13 Thread Glyph
> On Jun 13, 2016, at 4:20 AM, Adi Roiban wrote: > > Is there a wiki page, a ticket or some place where switching to the 'review > queue' as GitHub PR list is discussed or brainstormed? > Thus far all discussion has been on the mailing list. I feel like putting it on the

Re: [Twisted-Python] Responding to PRs

2016-06-13 Thread Adi Roiban
On 13 June 2016 at 03:09, Glyph wrote: [snip] I don't have any interest in teaching people the intricacies of this > somewhat janky process :-). The sooner we can switch to the "review queue" > simply being open PRs, the better; so thanks for volunteering to manage the

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Glyph
> On Jun 12, 2016, at 13:32, Itamar Turner-Trauring wrote: > > Hi all, > > Since we're starting to get PRs from random people it's worth trying to make > the process as friendly as possible. > > So, maybe instead of telling new contribtutors "PRs won't be reviewed

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Adi Roiban
On 12 June 2016 at 21:32, Itamar Turner-Trauring wrote: > Hi all, > > Since we're starting to get PRs from random people it's worth trying to > make the process as friendly as possible. > > So, maybe instead of telling new contribtutors "PRs won't be reviewed > without an

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Craig Rodrigues
Hi, I support this approach. I have a few small suggestions. (1) Give the exact link of some reasonable text that you want people to read. The contributor guidelines are accurate, but the text is verbose. It takes a while to get to the text that gives you the actual steps to follow.