Hello all,
Thank you.
Just submitted my first PR into the Twisted repo. Hopefully it is all good.
Here's the relevant ticket:
https://twistedmatrix.com/trac/ticket/9951
Cheers,
Boris.
On Mon, Sep 14, 2020 at 1:49 PM Glyph wrote:
>
>
> On Sep 14, 2020, at 10:11 AM, Boris Epstein wrote:
>
>
> On Sep 14, 2020, at 10:11 AM, Boris Epstein wrote:
>
> Hello Craig,
>
> Thanks. So basically you just work on the main Git repo, not on a clone - and
> you do the pull directly, not submit a pull request?
>
> Boris.
Hi Boris,
No, not at all. Work on your clone, and submit a PR as normal
Hello Craig,
Thanks. So basically you just work on the main Git repo, not on a clone -
and you do the pull directly, not submit a pull request?
Boris.
On Sat, Sep 5, 2020 at 2:19 PM Craig Rodrigues
wrote:
>
>
> On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein
> wrote:
>
>>
>> Now how do I procee
On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein wrote:
>
> Now how do I proceed? What is the convention for Git brach names, etc?
>
>
This document should give you the steps to create a Git branch and proceed
with a PR:
https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch
--
Cr
Hello all,
Thanks again for your help.
OK, so I think I have taken the first step:
https://twistedmatrix.com/trac/ticket/9951
Now how do I proceed? What is the convention for Git brach names, etc?
Cheers,
Boris.
On Sat, Aug 29, 2020 at 9:39 AM Boris Epstein wrote:
> Hi Glyph,
>
> Thanks.
Hi Glyph,
Thanks.
So I presume I should just follow the procedures delineated below, right?
It makes sense - you identify an issue, document it and then work on it.
Regards,
Boris.
On Sat, Aug 22, 2020 at 1:54 AM Glyph wrote:
> Welcome, Boris!
>
> If you're looking for stuff to work on, pl
Welcome, Boris!
If you're looking for stuff to work on, please feel free to discuss on this
list. We absolutely could use more volunteers to maintain stuff, particularly
improving the documentation!
-glyph
> On Aug 21, 2020, at 12:04 PM, Colin Dunklau wrote:
>
> Hi Boris,
>
> Probably the
Hi Boris,
Probably the best starting point is
https://twistedmatrix.com/trac/wiki/FrequentlyAskedQuestions#RequestsandContributing
and specifically
https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs and
https://twistedmatrix.com/trac/wiki/TwistedDevelopment
There are a lot of little de
Hi all,
I have started working with Twisted and found it to be a very powerful
package. That said, some modules are not documented very thoroughly (big
surprise in the world of software, right?) and I also found some
questionable code, too.
If I were to contribute fixes/improvements, what is the
