Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

On Thu, 15 Jul 2021 at 15:36, Jean-Paul Calderone wrote: > On Thu, Jul 15, 2021 at 10:26 AM Adi Roiban wrote: > >> Hi, >> >> As part of this PR https://github.com/twisted/twisted/pull/1619 Thomas >> has requested to enable the https://pre-commit.ci service for >> twisted/twisted repository >>

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

>> I am +0 on this change due to security reasons...but I do think that it will >> reduce a bit of the frustration for first time contributors. >> > > I'm +1; we've accepted a lot of cloud risk already, and this seems like a lot > of benefit for minimal additional risk. Is this asottile

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

> On Jul 15, 2021, at 7:35 AM, Jean-Paul Calderone > wrote: > > Can you elaborate on this a little bit? First time contributors won't be > able to push a branch to twisted/twisted. Does giving pre-commit.ci > write access to twisted/twisted also give it write >

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

> On Jul 15, 2021, at 7:25 AM, Adi Roiban wrote: > > I am +0 on this change due to security reasons...but I do think that it will > reduce a bit of the frustration for first time contributors. > I'm +1; we've accepted a lot of cloud risk already, and this seems like a lot of benefit for

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

On Thu, Jul 15, 2021 at 10:26 AM Adi Roiban wrote: > Hi, > > As part of this PR https://github.com/twisted/twisted/pull/1619 Thomas > has requested to enable the https://pre-commit.ci service for > twisted/twisted repository > > The pre-commit.ci is kind of an auto-pilot for our pre-commit >