Re: [Twisted-Python] Twisted Names strings

2013-01-22 Thread exarkun
On 03:37 pm, angelo.della...@gmail.com wrote: > >Hi, >I didn't have the possibility to test the fix during the last days >(hopefully will do >in the next hours) but taking a look at the fix proposed by ralphm > >http://twistedmatrix.com/trac/changeset/36867 > >it seems like the patch is not comple

Re: [Twisted-Python] Twisted Names strings

2013-01-22 Thread Angelo Dell'Aera
On Thu, 17 Jan 2013 17:19:01 - exar...@twistedmatrix.com wrote: > Absolutely. This issue has been reported in connection to Wokkel > already: > > http://twistedmatrix.com/trac/ticket/6245 > > There is currently a fix proposed and waiting review, and there has > been some discussion about

Re: [Twisted-Python] Twisted Names strings

2013-01-18 Thread Glyph
On Jan 18, 2013, at 6:23 AM, Angelo Dell'Aera wrote: > On Thu, 17 Jan 2013 12:15:03 -0800 > Glyph wrote: > >> >> On Jan 17, 2013, at 9:19 AM, exar...@twistedmatrix.com wrote: >> >>> (although testing during the /pre/-release period would have saved >>> everyone some trouble :). >> >> This b

Re: [Twisted-Python] Twisted Names strings

2013-01-18 Thread Angelo Dell'Aera
On Thu, 17 Jan 2013 12:15:03 -0800 Glyph wrote: > > On Jan 17, 2013, at 9:19 AM, exar...@twistedmatrix.com wrote: > > > (although testing during the /pre/-release period would have saved > > everyone some trouble :). > > This bears repeating! Not to harass you, Angelo - dealing with a > regre

Re: [Twisted-Python] Twisted Names strings

2013-01-18 Thread Angelo Dell'Aera
On Thu, 17 Jan 2013 17:19:01 - exar...@twistedmatrix.com wrote: > Absolutely. This issue has been reported in connection to Wokkel > already: > > http://twistedmatrix.com/trac/ticket/6245 > > There is currently a fix proposed and waiting review, and there has > been some discussion about

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread Ralph Meijer
On 2013-01-17 23:09, Ralph Meijer wrote: > David Reid wrote: > > Honestly, if you have comprehensive automated testing and plan to > upgrade Twisted regularly or to try and support the latest release > it is worth the effort to setup testing against Twisted trunk. > > https://githu

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread Ralph Meijer
David Reid wrote: >Honestly, if you have comprehensive automated testing and plan to >upgrade >Twisted regularly or to try and support the latest release it is worth >the >effort to setup testing against Twisted trunk. > >https://github.com/dreid/treq/blob/master/.travis.yml shows how I do >this

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread Glyph
On Jan 17, 2013, at 12:57 PM, David Reid wrote: > Honestly, if you have comprehensive automated testing and plan to upgrade > Twisted regularly or to try and support the latest release it is worth the > effort to setup testing against Twisted trunk. > > https://github.com/dreid/treq/blob/mast

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread David Reid
Honestly, if you have comprehensive automated testing and plan to upgrade Twisted regularly or to try and support the latest release it is worth the effort to setup testing against Twisted trunk. https://github.com/dreid/treq/blob/master/.travis.yml shows how I do this with travis-ci. -David On

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread Glyph
On Jan 17, 2013, at 9:19 AM, exar...@twistedmatrix.com wrote: > (although testing during the /pre/-release period would have saved everyone > some > trouble :). This bears repeating! Not to harass you, Angelo - dealing with a regression in Twisted that breaks your app is punishment enough :)

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread Laurens Van Houtven
FYI, this change also broke wokkel, too, so at least you're not alone, it seems... https://twistedmatrix.com/trac/ticket/6245 On Thu, Jan 17, 2013 at 5:22 PM, Angelo Dell'Aera wrote: > > After updating Twisted to 12.3.0 I started getting errors like the > following one > > 2013-01-17 14:38:23+

Re: [Twisted-Python] Twisted Names strings

2013-01-17 Thread exarkun
On 04:22 pm, angelo.della...@gmail.com wrote: > >After updating Twisted to 12.3.0 I started getting errors like the >following one > >2013-01-17 14:38:23+0100 [-] File "/usr/lib64/python2.7/site- >packages/twisted/names/common.py", line 93, in lookupAddress >2013-01-17 14:38:23+0100 [-] ret