Re: [Twisted-Python] Twisted at PyConUK 2013

On Sep 18, 2013, at 9:02 AM, Phil Mayers wrote: > Hope this is useful. I probably am overstating how painful it was - I did get > it done after all, and it'll be easier 2nd time around - but you guys keep > saying you want more reviewers ;o) Definitely useful to get some perspective on this,

Re: [Twisted-Python] Twisted at PyConUK 2013

On 17/09/13 19:08, Glyph wrote: On Sep 17, 2013, at 10:43 AM, Phil Mayers mailto:p.may...@imperial.ac.uk>> wrote: On 17/09/13 17:05, exar...@twistedmatrix.com wrote: p.s. the "How to review" docs on Trac are AWFUL if you've never done one before. It assumes

Re: [Twisted-Python] Twisted at PyConUK 2013

On Sep 17, 2013, at 10:43 AM, Phil Mayers wrote: > On 17/09/13 17:05, exar...@twistedmatrix.com wrote: > >>> p.s. the "How to review" docs on Trac are AWFUL if you've never done >>> one before. It assumes a *hell* of a lot of prior knowledge. There >>> needs to be a single page checklist for fir

Re: [Twisted-Python] Twisted at PyConUK 2013

On 17/09/13 17:05, exar...@twistedmatrix.com wrote: p.s. the "How to review" docs on Trac are AWFUL if you've never done one before. It assumes a *hell* of a lot of prior knowledge. There needs to be a single page checklist for first-time reviewers. This is in progress. Awesome; would it be

Re: [Twisted-Python] Twisted at PyConUK 2013

On 17/09/13 15:29, Richard Wall wrote: PS. I'd love to merge https://tm.tl/5675 before the conference, so if you're familiar with the DNS RFCs, I'd really appreciate a code review. I'm rwall on #twisted-dev and #twisted if you want to discuss it Deep breath... I'll give this a go. p.s. the "H

Re: [Twisted-Python] Twisted at PyConUK 2013

On 03:34 pm, p.may...@imperial.ac.uk wrote: On 17/09/13 15:29, Richard Wall wrote: PS. I'd love to merge https://tm.tl/5675 before the conference, so if you're familiar with the DNS RFCs, I'd really appreciate a code review. I'm rwall on #twisted-dev and #twisted if you want to discuss it Deep