[Twisted-Python] Question regarding patch submission

2017-06-25 Thread Jason Litzinger
Hello, Quick question regarding #15 of https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch. The step indicates that history shouldn't be re-written and the branch should be rebased over trunk. Pretty straightforward, introduce new commits, don't mess with the old ones. Howeve

[Twisted-Python] Twisted ( 17.1.0 ) exception

2017-06-25 Thread 莊冠世
Hi, I use Buildbot ( 0.9.7 ) and Twisted (==17.1.0) to run git poller, Config is below. c['change_source'].append(changes.GitPoller( repourl='git@172.23.45.81:/home/git/201701_postrack_swfw_app', branch='master',pollinterval=300, pollAtLaunch=True,

Re: [Twisted-Python] Twisted ( 17.1.0 ) exception

2017-06-25 Thread Craig Rodrigues
On Sunday, June 25, 2017, Jacky Chuang (莊冠世) wrote: > > File "d:\jacky\buildbot_virtualenv\ > buildbot\lib\site-packages\twisted\internet\_dumbwin32proc.py", line 214, > in doCreate > > command, cmdline, None, None, 1, flags, env, path, > StartupInfo) > >

Re: [Twisted-Python] Question regarding patch submission

2017-06-25 Thread Tristan Seligmann
On Mon, 26 Jun 2017 at 05:34 Jason Litzinger wrote: > However, after incorporating review comments in new commits and, > force-pushing the feature branch, is it expected that the review comments > may > be damaged? > I think this is expected; this is just an unfortunate shortcoming of GitHub PR

Re: [Twisted-Python] Twisted ( 17.1.0 ) exception

2017-06-25 Thread 莊冠世
I have tried : Buildbot: 0.9.8 and Python 3.6.1. But the result is the same. Jacky From: Twisted-Python [mailto:twisted-python-boun...@twistedmatrix.com] On Behalf Of Craig Rodrigues Sent: Monday, June 26, 2017 12:09 PM To: Twisted general discussion Subject: Re: [Twisted-Python] Twisted ( 17.1.