On Wednesday, 25 March 2020 07:02:46 GMT Glyph wrote: > > On Mar 24, 2020, at 4:05 PM, Tom Most <t...@freecog.net> wrote: > > > > I'll offer a dissenting opinion: > > > > I've worked on systems where the reactor is patched to use monotonic time. > > (This is essential on embedded systems that lack a real-time clock.) I'm > > not aware of this causing any issues, and it fixed real problems. > I am curious to know the problems that were fixed here, but, this is a > violation of the IReactorTime contract, implicit as it may be. > > The reactor should have a monotonic-time interface, and maybe we should even > use it to implement callLater. But .seconds() is wall-clock time. > > HTTPFactory is quite unusual in assuming that it is epoch time. Most parts > > of Twisted that require wall time call `time.time()` or equivalent > > directly. IMO HTTPFactory is in error here, and this is simply a bug. We > > should change HTTPFactory to use `time.time()` directly. > Nope. This breaks a whole class of testing strategies, which are explicitly > documented in > https://twistedmatrix.com/documents/20.3.0/core/howto/trial.html#testing-sc > heduling > <https://twistedmatrix.com/documents/20.3.0/core/howto/trial.html#testing-s > cheduling> . > > However, I can definitely see the need for monotonic time. `IReactorTimeEx` > should probably include methods for getting monotonic time, getting civil > times, scheduling callables at future civil times explicitly rather than > using relative timestamps, etc. Possibly some of these should be different > interfaces. > > Since the time base of IReactorTime.seconds() hasn't ever been clearly > > defined, I think that we should really go the other way: use > > `time.monotonic()` by default where possible. (Or, more realistically, > > make it an option and maybe the default.) > Definitely not. Huge huge swathes of Twisted code would break, not least of > which would be Twisted's own HTTP access logs which rely on .seconds() to > be wall clock.
Why does Twisted need to duplicate the built in python time features? What was wrong with using time.time() for the access logs? Surely reactors must be use monotonic time to avoid breaking protocol timing across wall-clock time being adjusted by ntp etc. Barry > > ---Tom > > > > On Mon, Mar 23, 2020, at 1:24 PM, Amber Brown (hawkowl) wrote: > >> On 24/3/20 6:45 am, Richard van der Hoff wrote: > >>> HTTPFactory seems to think that `reactor.seconds` is reliably an epoch > >>> time (see > >>> https://github.com/twisted/twisted/blob/trunk/src/twisted/web/http.py#L3 > >>> 110, etc). > >>> > >>> On the other hand. AsyncioSelectorReactor.seconds() returns a monotonic > >>> time: > >>> > >>> python3 -c 'from twisted.internet import asyncioreactor; > >>> print(asyncioreactor.AsyncioSelectorReactor().seconds())' > >>> 41116.763594412 > >>> > >>> One of these is wrong... I think it's HTTPFactory making bad > >>> assumptions, but can anyone confirm the intention here? > >> > >> It's a bug in asyncioreactor. IReactorTime defines it as "current time > >> in seconds", which _probably_ should be defined nicer > >> (https://twistedmatrix.com/documents/current/api/twisted.internet.interfa > >> ces.IReactorTime.html#seconds) but is generally epoch time. > >> > >> asyncioreactor does have a few problems with time: > >> > >> https://twistedmatrix.com/trac/ticket/9611 > >> https://twistedmatrix.com/trac/ticket/9780 > >> > >> I can't find a bug for this issue, though, although I'm almost sure I've > >> seen it before... so, if you could file one (and maybe a patch to fix > >> it!) then that would be appreciated. > >> > >> - Amber > >> > >> _______________________________________________ > >> Twisted-Python mailing list > >> Twisted-Python@twistedmatrix.com > >> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > > > > _______________________________________________ > > Twisted-Python mailing list > > Twisted-Python@twistedmatrix.com > > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
