Re: [Twisted-Python] pypy3 builds passing?

2018-04-13 Thread Amber Brown 
I'll also note that very soon, pypy2.7 should also be supported.

On Fri, 13 Apr 2018, 16:00 Mark Williams,  wrote:

> On Thu, Apr 12, 2018, at 10:53 PM, Craig Rodrigues wrote:
> >
> >
> > On Thu, Apr 12, 2018 at 10:35 PM, Amber Brown 
> wrote:
> >> It does on master, i think, but unsupported doesn't run on PRs.
> >>
> >> I'm happy to move it to supported if we're happy with it! I think since
> it runs all the main reactors plus asyncio, we can be relatively trusting
> of it being green now...
> >>
> >
> > That build runs select, poll, epoll, and asyncio reactors.  So since
> there are about 12,000 tests, running 4 times, that is about 48,000 tests
> > for this builder.  That took 39 minutes.
> > That's a bit long, but maybe that's OK.
>
> Thanks for checking the build time! I agree that 40 minutes is long, and
> I'd rather not add it onto our already lengthy CI cycle.
>
> > I don't know if it is worth figuring out any ways to optimize this run
> by maybe using "trial -j", or splitting
> > the run of each reactor into a new builder.
>
> trial -j fails on some of our tests, and I wouldn't be surprised if it's
> less reliable under PyPy.  We should fix that, but until we do, I think
> adding additional builders for each PyPy3 reactor is a good idea.
>
> > --
> > Craig
> > _
> > Twisted-Python mailing list
> > Twisted-Python@twistedmatrix.com
> > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
> --
>   Mark Williams
>   m...@enotuniq.org
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-13 Thread Amber Brown 
No, it does not. May be worth it for just select, tho, considering we have
pypy specific checks.

On Fri, 13 Apr 2018, 15:58 Hynek Schlawack,  wrote:

> It does on master, i think, but unsupported doesn't run on PRs.
>>
>> I'm happy to move it to supported if we're happy with it! I think since
>> it runs all the main reactors plus asyncio, we can be relatively trusting
>> of it being green now...
>>
>>
> That build runs select, poll, epoll, and asyncio reactors.  So since there
> are about 12,000 tests, running 4 times, that is about 48,000 tests
> for this builder.  That took 39 minutes.
>
>
> Does it run under Coverage? attrs’ test suite took almost 20 minutes when
> running under PyPy3 and coverage so we switched it off for everything
> except py27 and py36.
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-13 Thread Mark Williams 
On Thu, Apr 12, 2018, at 10:53 PM, Craig Rodrigues wrote:
> 
> 
> On Thu, Apr 12, 2018 at 10:35 PM, Amber Brown  
> wrote:
>> It does on master, i think, but unsupported doesn't run on PRs.
>> 
>> I'm happy to move it to supported if we're happy with it! I think since it 
>> runs all the main reactors plus asyncio, we can be relatively trusting of it 
>> being green now...
>> 
> 
> That build runs select, poll, epoll, and asyncio reactors.  So since there 
> are about 12,000 tests, running 4 times, that is about 48,000 tests
> for this builder.  That took 39 minutes.
> That's a bit long, but maybe that's OK.

Thanks for checking the build time! I agree that 40 minutes is long, and I'd 
rather not add it onto our already lengthy CI cycle.

> I don't know if it is worth figuring out any ways to optimize this run by 
> maybe using "trial -j", or splitting 
> the run of each reactor into a new builder.

trial -j fails on some of our tests, and I wouldn't be surprised if it's less 
reliable under PyPy.  We should fix that, but until we do, I think adding 
additional builders for each PyPy3 reactor is a good idea.

> --
> Craig
> _
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

--
  Mark Williams
  m...@enotuniq.org

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Hynek Schlawack 
> It does on master, i think, but unsupported doesn't run on PRs.
> 
> I'm happy to move it to supported if we're happy with it! I think since it 
> runs all the main reactors plus asyncio, we can be relatively trusting of it 
> being green now...
> 
> 
> That build runs select, poll, epoll, and asyncio reactors.  So since there 
> are about 12,000 tests, running 4 times, that is about 48,000 tests
> for this builder.  That took 39 minutes.

Does it run under Coverage? attrs’ test suite took almost 20 minutes when 
running under PyPy3 and coverage so we switched it off for everything except 
py27 and py36.___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Craig Rodrigues 
On Thu, Apr 12, 2018 at 10:35 PM, Amber Brown 
wrote:

> It does on master, i think, but unsupported doesn't run on PRs.
>
> I'm happy to move it to supported if we're happy with it! I think since it
> runs all the main reactors plus asyncio, we can be relatively trusting of
> it being green now...
>
>
That build runs select, poll, epoll, and asyncio reactors.  So since there
are about 12,000 tests, running 4 times, that is about 48,000 tests
for this builder.  That took 39 minutes.
That's a bit long, but maybe that's OK.
I don't know if it is worth figuring out any ways to optimize this run by
maybe using "trial -j", or splitting
the run of each reactor into a new builder.

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Amber Brown 
It does on master, i think, but unsupported doesn't run on PRs.

I'm happy to move it to supported if we're happy with it! I think since it
runs all the main reactors plus asyncio, we can be relatively trusting of
it being green now...

On Fri, 13 Apr 2018, 15:08 Glyph,  wrote:

>
>
> > On Apr 12, 2018, at 9:59 PM, Amber Brown 
> wrote:
> >
> > My work is paying off... :)
>
> So I think we can call pypy3 a supported platform now?
>
> Does it report build status to Github yet?
>
> -g
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Craig Rodrigues 
On Thursday, April 12, 2018, Amber Brown  wrote:

> My work is paying off... :)
>


Thank you!!

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Glyph 


> On Apr 12, 2018, at 9:59 PM, Amber Brown  wrote:
> 
> My work is paying off... :)

So I think we can call pypy3 a supported platform now?

Does it report build status to Github yet?

-g

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Amber Brown 
My work is paying off... :)

On Fri, 13 Apr 2018, 14:24 Glyph,  wrote:

> On Apr 12, 2018, at 9:22 PM, Craig Rodrigues 
> wrote:
>
>
> Hi,
>
> I just took a look at this:
>
> https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy3/builds/27
>
> running with:
>
> Python 3.5.3 (3f6eaa010fce, Jan 11 2018, 04:44:35)
> [PyPy 5.10.1 with GCC 6.2.0 20160901]
>
>
> Ran 12268 tests in 455.535s
>
> PASSED (skips=2240, successes=10028)
>
>
> Is that a fluke, or have we made good progress with pypy?
>
>
> Woah!
>
> Failing tests might be a fluke, but I have a hard time imagining how
> passing tests could be :)
>
> This is great news!
>
> -glyph
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Glyph 
On Apr 12, 2018, at 9:22 PM, Craig Rodrigues  wrote:
> 
> Hi,
> 
> I just took a look at this:
> 
> https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy3/builds/27 
> 
> 
> running with:
> 
> Python 3.5.3 (3f6eaa010fce, Jan 11 2018, 04:44:35)
> [PyPy 5.10.1 with GCC 6.2.0 20160901]
> 
> 
> Ran 12268 tests in 455.535s
> 
> PASSED (skips=2240, successes=10028)
> 
> 
> Is that a fluke, or have we made good progress with pypy?

Woah!

Failing tests might be a fluke, but I have a hard time imagining how passing 
tests could be :)

This is great news!

-glyph

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] pypy3 builds passing?

2018-04-12 Thread Craig Rodrigues 
Hi,

I just took a look at this:

https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy3/builds/27

running with:

Python 3.5.3 (3f6eaa010fce, Jan 11 2018, 04:44:35)
[PyPy 5.10.1 with GCC 6.2.0 20160901]


Ran 12268 tests in 455.535s

PASSED (skips=2240, successes=10028)


Is that a fluke, or have we made good progress with pypy?

--
Craig
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python