Re: [twsocket] IcsExtractLastDir

2009-06-20 Thread Angus Robertson - Magenta Systems Ltd
> No problem.
> However it is realy necessary to test any change at least twice, 
> once with Delphi 7 and once with Delphi 2009. Even if you are very 
> sure that everything is OK. 

If there were 36 hours in a day, I'd do that.  My alternate choice is not
to submit changes to ICS.  

Or the people that actually want to use Delphi 2009 could help by testing
ICS for those of us that actually improve the code in D7 and D2007, as
Jon Robertson kindly did.  

Angus

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] IcsExtractLastDir

2009-06-20 Thread Arno Garrels
Angus Robertson - Magenta Systems Ltd wrote:
>> In D2009, I get "E2004 Identifier redeclared: 'IcsExtractLastDir'"
> 
> Thanks, I'll fix it later today.  I don't have a proper license for
> D2009, so I don't use it for any projects.

No problem.
However it is realy necessary to test any change at least twice, once 
with Delphi 7 and once with Delphi 2009. Even if you are very sure that
everything is OK. I stupidly repeat this procedure before each commit,
and find bugs that way frequently.

--
Arno
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] IcsExtractLastDir

2009-06-20 Thread Angus Robertson - Magenta Systems Ltd
> In D2009, I get "E2004 Identifier redeclared: 'IcsExtractLastDir'"

Thanks, I'll fix it later today.  I don't have a proper license for D2009,
so I don't use it for any projects.  

Angus

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


[twsocket] IcsExtractLastDir

2009-06-19 Thread Jon Robertson
Angus,

You added two overloaded versions of IcsExtractLastDir to
OcverbyteIcsUtils.pas on 6/4/2009:
  function IcsExtractLastDir (const Path: String): String; overload;
*  *function IcsExtractLastDir (const Path: UnicodeString): UnicodeString;
overload;

In D2009, I get "E2004 Identifier redeclared: 'IcsExtractLastDir'"

I haven't paid attention to recent ICS development, and I'm just now getting
into converting D6 projects to D2009 (& associated Unicode issues).
However, I believe the error is because String is aliased to UnicodeString
in D2009, so these are basically the same function.  Other OverbyteIcsUtils
functions that are overloaded use UTF8String, not String.  With the UTF8
version calling the UnicodeString version, like this:
function IcsExtractLastDir (const Path: UTF8String): UTF8String;
begin
  Result := IcsExtractLastDir(AnsiToUnicode(Path, CP_UTF8));
end;

I've made this change to the code I just grabbed from SVN and it now
compiles.  But I'm not sure that is what you intended to do.  :)

Thanks


-- 
Jon Robertson
Borland Certified Advanced Delphi 7 Developer
Good programming is 40% experience, 30% skill, 20% RTFM, 10% caffeine, and
5% attention to detail.
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be