Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Angus Robertson - Magenta Systems Ltd
 There's missing part in DoHighLevelAsync - it can't handle 
 ftpFctSyst request. Here's what should be added:

In what way can it not 'handle' the request.  The code you provided is
already in the component, lines 3534 to 3539 is the current V7 version. 

Angus

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Anton Sviridov
Sorry, I've messed things up. The missing request is FEAT.

-- 
Anton
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Angus Robertson - Magenta Systems Ltd
 Sorry, I've messed things up. The missing request is FEAT.

Sync FEAT works as well, I use it hundreds of times per day.

Angus

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Anton Sviridov
Sync FEAT works as well, I use it hundreds of times per day.
Yes, I know, but I do async operations, and implemented my own Login method 
which executes all initialization stuff, including SYST and FEAT so that all of 
these commands are packed into single request. Anyway, I think the code should 
be added anyway, because it's likely a forgotten piece.

I'd also like to suggest to add virtual TriggerResponse method which will 
launch OnResponse by default, but allow overriding in descendants. It will be 
very convenient for custom response processing, leaving event for end-users to 
assign.

--
Anton
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Angus Robertson - Magenta Systems Ltd
 Anyway, I think the code should be added anyway, because it's
 likely a forgotten piece.

What code is forgotten?  FEAT sync and async both work fine. 

 I'd also like to suggest to add virtual TriggerResponse method

If you think new methods are needed, you need to add them to the latest
SVN copy of the component, thoroughly test the code in all the relevant
ICS demos to ensure it's 100% backward compatible, and in your own
applications, then submit the complete changed zipped unit to Francois,
Arno and myself via email (not just changed lines).  We'll evaluate the
changes and update SVN, if they are beneficial to other ICS users and
don't impact the unit functionality.  

Angus
 

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Anton Sviridov
What code is forgotten?  FEAT sync and async both work fine. 
I mean code in DoHighLevelAsync, that is, pushing ftpFctFeat into 
HighLevelAsync does no matter.

If you think new methods are needed, you need ...
Hmm, quite complicated. Okay, I'll do it some time later.

-- 
Anton
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Angus Robertson - Magenta Systems Ltd
If you think new methods are needed, you need ...
 Hmm, quite complicated. Okay, I'll do it some time later.

Not complicated atall, it's exactly what Francois, Arno and myself have
to do when making additions and fixes to ICS.  

Angus

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Graham Powell
As we are in the mode for changes to the FTP client. One thing that I have
always done, which makes my life much easier is to add a DownloadToString
and LocalStringName property. At the moment the FTP client can download
data to a file or to a stream. In my application it is much more convenient
to download to a String.

DownloadToString : boolean
LocalStringName : String

Set DownloadToString = true, execute some command, LIST RETR etc. and get
the result from LocalStringName

Can this be added? I can always send you what I have done although it's not
exactly difficult to implement.

Regards
  Graham

-Original Message-
From: twsocket-boun...@elists.org [mailto:twsocket-boun...@elists.org] On
Behalf Of Angus Robertson - Magenta Systems Ltd
Sent: 18 December 2009 14:13
To: twsocket@elists.org
Subject: Re: [twsocket] Missing part  suggestion to FTPClient

If you think new methods are needed, you need ...
 Hmm, quite complicated. Okay, I'll do it some time later.

Not complicated atall, it's exactly what Francois, Arno and myself have to
do when making additions and fixes to ICS.  

Angus

--
To unsubscribe or change your settings for TWSocket mailing list please goto
http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] Missing part suggestion to FTPClient

2009-12-18 Thread Francois PIETTE

Hello Graham,

We cannot implement every possible variation. The component would become 
huge and difficult to maintain.
I think this kind of change could easily be done in a derived component: 
create your own class inheriting from ICS component and add the required 
properties method and event.
Change that can be done, if ever required, is something which would permit 
the implementation in a derived component, such as making a method virtual, 
adding setter/getter and similar.


--
francois.pie...@overbyte.be
The author of the freeware multi-tier middleware MidWare
The author of the freeware Internet Component Suite (ICS)
http://www.overbyte.be


- Original Message - 
From: Graham Powell gra...@deephaven.co.uk

To: 'ICS support mailing' twsocket@elists.org
Sent: Friday, December 18, 2009 3:25 PM
Subject: Re: [twsocket] Missing part  suggestion to FTPClient



As we are in the mode for changes to the FTP client. One thing that I have
always done, which makes my life much easier is to add a 
DownloadToString

and LocalStringName property. At the moment the FTP client can download
data to a file or to a stream. In my application it is much more 
convenient

to download to a String.

DownloadToString : boolean
LocalStringName : String

Set DownloadToString = true, execute some command, LIST RETR etc. and get
the result from LocalStringName

Can this be added? I can always send you what I have done although it's 
not

exactly difficult to implement.

Regards
 Graham

-Original Message-
From: twsocket-boun...@elists.org [mailto:twsocket-boun...@elists.org] On
Behalf Of Angus Robertson - Magenta Systems Ltd
Sent: 18 December 2009 14:13
To: twsocket@elists.org
Subject: Re: [twsocket] Missing part  suggestion to FTPClient


If you think new methods are needed, you need ...

Hmm, quite complicated. Okay, I'll do it some time later.


Not complicated atall, it's exactly what Francois, Arno and myself have to
do when making additions and fixes to ICS.

Angus

--
To unsubscribe or change your settings for TWSocket mailing list please 
goto

http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be 


--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be