Re: [twsocket] ICS for MacOS target

2017-10-05 Thread Angus Robertson - Magenta Systems Ltd
> After a few minor modifications (see below), it compiles 
> successfully on MacOS.
> 
> OverbyteIcsCryptuiApi:34
> - move {$IFDEF MSWINDOWS} to after "interface"
> 
> OverbyteIcsFtpSvr.pas:2120
> - use System.SysUtils.DirectoryExists(Dir)
> 
> OverbyteIcsSmtpProt.pas:2219:
> - use ErrorCode instead of Error.
> - ERROR_SUCCESS does not exist; I've replaced it with a hardcoded 
> 0 (educated guess) for now
> 
> OverbyteIcsPop3Prot.pas:1067:
> - ERROR_SUCCESS does not exist; I've replaced it with a hardcoded 
> 0 (educated guess) for now

Thanks, all my mistakes and all now fixed in SVN.  One final check? 

Noticed the email units are now 20 years old, written in September 1997
by Francois.  I started using them in early 1998. 

Angus

-- 
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] ICS for MacOS target

2017-10-04 Thread Jan Bakuwel

Hi Angus,

Many thanks for getting back to me.

On 04/10/17 23:45, Angus Robertson - Magenta Systems Ltd wrote:

I downloaded the SVN trunk of ICS and tried to compile the first
package (IcsCommonDXE5Run.bpl) with XE5. Both Windows targets
compile fine, however the OSX target does not. It tries to
compile OverbyteIcsCryptUiApi:

That unit supports Windows APIs, so fails on MacOS.  It allows access
to the Windows SSL certificate store instead of applications providing
their own root store (which is a pain to maintain).

I added it to the IcsCommon packages two years ago for V8.18, another
user tested MacOS in June and found some issues all of which were fixed
then, but not with OverbyteIcsCryptUiApi.

Guess I should have put these Windows only units in IcsVCL packages,
but that means dozens of files to update so I've used conditions to
make sure Windows stuff only builds on windows.

In SVN now, but not yet in the overnight zip.  Can you please confirm
V8.50 builds again on MacOS?


After a few minor modifications (see below), it compiles successfully on 
MacOS.


OverbyteIcsCryptuiApi:34
- move {$IFDEF MSWINDOWS} to after "interface"

OverbyteIcsFtpSvr.pas:2120
- use System.SysUtils.DirectoryExists(Dir)

OverbyteIcsSmtpProt.pas:2219:
- use ErrorCode instead of Error.
- ERROR_SUCCESS does not exist; I've replaced it with a hardcoded 0 
(educated guess) for now


OverbyteIcsPop3Prot.pas:1067:
- ERROR_SUCCESS does not exist; I've replaced it with a hardcoded 0 
(educated guess) for now


kind regards,
Jan

--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be


Re: [twsocket] ICS for MacOS target

2017-10-04 Thread Angus Robertson - Magenta Systems Ltd
> I downloaded the SVN trunk of ICS and tried to compile the first 
> package (IcsCommonDXE5Run.bpl) with XE5. Both Windows targets 
> compile fine, however the OSX target does not. It tries to 
> compile OverbyteIcsCryptUiApi:

That unit supports Windows APIs, so fails on MacOS.  It allows access
to the Windows SSL certificate store instead of applications providing
their own root store (which is a pain to maintain).  

I added it to the IcsCommon packages two years ago for V8.18, another
user tested MacOS in June and found some issues all of which were fixed
then, but not with OverbyteIcsCryptUiApi.  

Guess I should have put these Windows only units in IcsVCL packages,
but that means dozens of files to update so I've used conditions to
make sure Windows stuff only builds on windows. 

In SVN now, but not yet in the overnight zip.  Can you please confirm
V8.50 builds again on MacOS?

Angus

-- 
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be