On Sun, 2009-08-23 at 21:30 +, Robert Collins wrote:
=== modified file 'txaws/client/gui/gtk.py'
--- txaws/client/gui/gtk.py 2009-08-18 22:53:53 +
+++ txaws/client/gui/gtk.py 2009-08-20 19:14:32 +
@@ -8,7 +8,7 @@
import gobject
import gtk
-from txaws.credentials
On Thu, 2009-08-20 at 19:25 +, Duncan McGreggor wrote:
Duncan McGreggor has proposed merging
lp:~oubiwann/txaws/416109-arbitrary-endpoints into lp:txaws.
Requested reviews:
txAWS Team (txawsteam)
This branch adds support for a service object that manages host
endpoints as well as
+1
--
https://code.launchpad.net/~oubiwann/txaws/415491-instance-object/+merge/10505
Your team txAWS Team is subscribed to branch lp:txaws.
___
Mailing list: https://launchpad.net/~txawsteam
Post to : txawsteam@lists.launchpad.net
Unsubscribe :
Wow, code explosion. Uhm, This perhaps would be easier to review in
parts...
Firstly, the module should be txaws.storage.simulator, I think. Or
storage.server.simulator.
Secondly, copyright headers. txaws does a much leaner one;
# Copyright (C) 2009 $PUT_YOUR_NAMES_HERE
# Licenced under the
On Thu, 2009-08-20 at 02:06 +, Duncan McGreggor wrote:
On Wed, Aug 19, 2009 at 10:46 PM, Robert
Collinsrobe...@robertcollins.net wrote:
Uhm, I'm not sure :)
The only remaining thing was import sorting. I don't think you replied
to my reply on that.
Hrm, well I don't know what
On Thu, 2009-08-20 at 03:36 +, Elliot Murphy wrote:
Thanks a lot for the quick review. The code is very much in the state
it was being used internally, and I think your comments all make sense
and will improve the code. I differ on the license header thing - I
explicitly chose not to
6 matches
Mail list logo
