> in which case,
> review +1
Thanks!
--
https://code.edge.launchpad.net/~oubiwann/txaws/413738-method-name-cleanup/+merge/10245
Your team txAWS Team is subscribed to branch lp:txaws.
___
Mailing list: https://launchpad.net/~txawsteam
Post to : txaw
in which case,
review +1
--
https://code.launchpad.net/~oubiwann/txaws/413738-method-name-cleanup/+merge/10245
Your team txAWS Team is subscribed to branch lp:txaws.
___
Mailing list: https://launchpad.net/~txawsteam
Post to : txawsteam@lists.laun
A quick ping on this branch... I've got dependent branches starting to pile
up...
Thanks!
--
https://code.edge.launchpad.net/~oubiwann/txaws/413738-method-name-cleanup/+merge/10245
Your team txAWS Team is subscribed to branch lp:txaws.
___
Mailing li
> On Thu, 2009-08-20 at 02:06 +, Duncan McGreggor wrote:
> > On Wed, Aug 19, 2009 at 10:46 PM, Robert
> > Collins wrote:
> > > Uhm, I'm not sure :)
> > >
> > > The only remaining thing was import sorting. I don't think you replied
> > > to my reply on that.
> >
> > Hrm, well I don't know what y
On Wed, Aug 19, 2009 at 11:04 PM, Duncan McGreggor wrote:
> On Wed, Aug 19, 2009 at 10:46 PM, Robert
> Collins wrote:
>> Uhm, I'm not sure :)
>>
>> The only remaining thing was import sorting. I don't think you replied
>> to my reply on that.
>
> Hrm, well I don't know what you're sorting one... ca
On Thu, 2009-08-20 at 02:06 +, Duncan McGreggor wrote:
> On Wed, Aug 19, 2009 at 10:46 PM, Robert
> Collins wrote:
> > Uhm, I'm not sure :)
> >
> > The only remaining thing was import sorting. I don't think you replied
> > to my reply on that.
>
> Hrm, well I don't know what you're sorting one
On Wed, Aug 19, 2009 at 10:46 PM, Robert
Collins wrote:
> Uhm, I'm not sure :)
>
> The only remaining thing was import sorting. I don't think you replied
> to my reply on that.
Hrm, well I don't know what you're sorting one... can you explain it?
d
--
https://code.launchpad.net/~oubiwann/txaws/4
Uhm, I'm not sure :)
The only remaining thing was import sorting. I don't think you replied
to my reply on that.
-Rob
--
https://code.launchpad.net/~oubiwann/txaws/413738-method-name-cleanup/+merge/10245
Your team txAWS Team is subscribed to branch lp:txaws.
___
Hey Rob, you've got your review labeled as "needs fixing" -- is that still the
case?
Thanks!
--
https://code.edge.launchpad.net/~oubiwann/txaws/413738-method-name-cleanup/+merge/10245
Your team txAWS Team is subscribed to branch lp:txaws.
___
Mailing
On Tue, 2009-08-18 at 17:48 +, Duncan McGreggor wrote:
>
> [1]
>
> So PEP-8 states the following:
>
> 1. standard library imports
> 2. related third party imports
> 3. local application/library specific imports
>
> Both lines are local application, and there's no further
> On Mon, 2009-08-17 at 13:00 +, Duncan McGreggor wrote:
> >
> > +from txaws.util import XML, calculate_md5
> > from txaws.credentials import AWSCredentials
> > -from txaws.util import XML
>
> PEP8 mandates sorting this:
> from txaws.credentials should be the first line.
[1]
So PEP-8 state
Review: Needs Fixing
On Mon, 2009-08-17 at 13:00 +, Duncan McGreggor wrote:
>
> +from txaws.util import XML, calculate_md5
> from txaws.credentials import AWSCredentials
> -from txaws.util import XML
PEP8 mandates sorting this:
from txaws.credentials should be the first line.
> +
> +
> +NS
12 matches
Mail list logo
