Re: [U-Boot] [PATCH 1/1] add u-boot/types to simplify HOST support

2008-08-16 Thread Jean-Christophe PLAGNIOL-VILLARD
> > + > > + > > +#endif /* __U_BOOT_TYPES_H__ */ > > My initial reaction was "what a good idea", bt after looking at the > resulting code I find that it bocmes even less readable. With this > patch applied, I lost the last bit of track I had which define was > coming where from. > > For example,

Re: [U-Boot] [PATCH 1/1] add u-boot/types to simplify HOST support

2008-08-16 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <[EMAIL PROTECTED]> you wrote: > add fix MacOS HOST support > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> > --- > include/elf.h | 15 + > include/environment.h |6 + > include/image.h

Re: [U-Boot] [PATCH 1/3] [RFC] Add support for early serial debug console

2008-08-16 Thread Wolfgang Denk
Dear Peter Tyser, In message <[EMAIL PROTECTED]> you wrote: > > If the debug console is being used, it would generally mean that the > board is not bootable. Thus the absolute worst (and somewhat unlikely) > outcome of using the debug console would be to render the already > unbootable board fur

[U-Boot] [PATCH 1/1] add u-boot/types to simplify HOST support

2008-08-16 Thread Jean-Christophe PLAGNIOL-VILLARD
add fix MacOS HOST support Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> --- include/elf.h | 15 + include/environment.h |6 + include/image.h|1 + include/libfdt_env.h |3 +- include/u-boot/md5.h |2 +- include/u-boot/

[U-Boot] [PATCH] Makefile: fix posix support on find

2008-08-16 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> diff --git a/Makefile b/Makefile index 00ae9ca..de255d6 100644 --- a/Makefile +++ b/Makefile @@ -3101,9 +3101,9 @@ clobber: clean @rm -f $(obj)tools/{fdt_wip.c,libfdt_internal.h} @rm -f $(obj)cpu/mpc824x/bedbug_60

Re: [U-Boot] [PATCH 1/3] [RFC] Add support for early serial debug console

2008-08-16 Thread Peter Tyser
Thanks for the comments. Response inline: On Sat, 2008-08-16 at 09:49 +0200, Wolfgang Denk wrote: > Dear Peter, > > In message <[EMAIL PROTECTED]> you wrote: > > > > I attempted to account for this fact. I followed the program flow of > > run_command() and readline() in particular looking for

Re: [U-Boot] [PATCH] Replace references to extern console_buffer with a function call

2008-08-16 Thread Wolfgang Denk
Dear Peter Tyser, In message <[EMAIL PROTECTED]> you wrote: > > > But this is a boot loader, and size matters. > > I had assumed gcc/ld would be smart enough to optimize the function call > away, seeing as there is no conditional code in it. I just tested, and > the size was increased by 48 byte

Re: [U-Boot] [PATCH 1/3] [RFC] Add support for early serial debug console

2008-08-16 Thread Wolfgang Denk
Dear Peter, In message <[EMAIL PROTECTED]> you wrote: > > I attempted to account for this fact. I followed the program flow of > run_command() and readline() in particular looking for global data > writes and bss reads. For the instances where global data was being Indeed you did this, but onl