Re: [U-Boot] [PATCH v3 02/10] armv7: add miscellaneous utility macros

2011-06-16 Thread Graeme Russ
Hi Aneesh, On Thu, Jun 16, 2011 at 3:39 PM, Aneesh V ane...@ti.com wrote: Hi Grame, On Wednesday 15 June 2011 06:12 PM, Graeme Russ wrote: On 15/06/11 22:04, Wolfgang Denk wrote: Dear Aneesh V, In message4df89102.9040...@ti.com  you wrote: Will you accept something like this? a_val =

Re: [U-Boot] [RFC][Timer API] Revised Specification - Implementation details

2011-06-16 Thread Graeme Russ
Hi Simon, On Thu, Jun 16, 2011 at 3:53 PM, Simon Glass s...@chromium.org wrote: Hi Graeme, On Wed, Jun 15, 2011 at 4:09 PM, Graeme Russ graeme.r...@gmail.com wrote: [snip] BTW should the deltas return a signed value? No - times are unsigned utilising the entire range of the u32 so (to -

[U-Boot] SPL framework re-design

2011-06-16 Thread Aneesh V
Dear Wolfgang, This is in continuation of our discussion in the following threads: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/99795 http://article.gmane.org/gmane.comp.boot-loaders.u-boot/99785 I think this discussion now needs a dedicated thread. To make sure I understand your

Re: [U-Boot] [PATCH v3 02/10] armv7: add miscellaneous utility macros

2011-06-16 Thread Wolfgang Denk
Dear Graeme Russ, In message banlktik3cxemzu0qpxdlsqmtk-abeod...@mail.gmail.com you wrote: Now, that being said, I see no reason not to do the following if I had, for example, multiple serial port configuration registers which are all identical: /* num data bits is stored in bits 2-4 of

[U-Boot] [PATCH] ARM: add marvell specific cache operation

2011-06-16 Thread Lei Wen
For Marvell sheeva 88SV331xV5 core, it has one special cache asm code to do the clean and valid in one line. Signed-off-by: Lei Wen lei...@marvell.com --- arch/arm/lib/cache.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c

Re: [U-Boot] [PATCH] ARM: add marvell specific cache operation

2011-06-16 Thread Prafulla Wadaskar
-Original Message- From: Lei Wen [mailto:lei...@marvell.com] Sent: Thursday, June 16, 2011 2:34 PM To: u-boot@lists.denx.de; Prafulla Wadaskar; wadas...@marvell.com; Prafulla Wadaskar; adrian.w...@gmail.com Subject: [PATCH] ARM: add marvell specific cache operation For Marvell

Re: [U-Boot] [PATCH] ARM: add marvell specific cache operation

2011-06-16 Thread Lei Wen
Hi Prafulla, On Thu, Jun 16, 2011 at 5:31 PM, Prafulla Wadaskar prafu...@marvell.com wrote: -Original Message- From: Lei Wen [mailto:lei...@marvell.com] Sent: Thursday, June 16, 2011 2:34 PM To: u-boot@lists.denx.de; Prafulla Wadaskar; wadas...@marvell.com; Prafulla Wadaskar;

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Wolfgang Denk
Dear Aneesh, In message 4df9b9e0.8020...@ti.com you wrote: To make sure I understand your new proposals, let me consolidate them here. Please correct me if I am wrong. Also, in the end I have some questions about your new proposal. Some of the questions are getting into the details. But I

Re: [U-Boot] OpenRD Ultimate SATA SD

2011-06-16 Thread Philip Hands
On Wed, 15 Jun 2011 22:10:30 -0700, Prafulla Wadaskar prafu...@marvell.com wrote: -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Philip Hands Sent: Wednesday, June 15, 2011 3:24 PM To: u-boot@lists.denx.de Subject:

Re: [U-Boot] [PATCH v3 02/10] armv7: add miscellaneous utility macros

2011-06-16 Thread Graeme Russ
On 15/06/11 22:51, Wolfgang Denk wrote: Dear Graeme Russ, In message 4df8a8cf.5000...@gmail.com you wrote: And to set the value then you have: reg = ~a_mask; /* Clear a_val */ reg |= (a_val a_shift) a_mask; /* Set new a_val */ This could be done

Re: [U-Boot] [PATCH v3 02/10] armv7: add miscellaneous utility macros

2011-06-16 Thread Graeme Russ
On 16/06/11 18:15, Wolfgang Denk wrote: Dear Graeme Russ, In message banlktik3cxemzu0qpxdlsqmtk-abeod...@mail.gmail.com you wrote: Now, that being said, I see no reason not to do the following if I had, for example, multiple serial port configuration registers which are all identical: /*

Re: [U-Boot] [PATCH v2 1/2] arm/kirkwood: if CONFIG_SOFT_I2C is set don't set CONFIG_I2C_MVTWSI

2011-06-16 Thread Prafulla Wadaskar
-Original Message- From: Holger Brunck [mailto:holger.bru...@keymile.com] Sent: Wednesday, June 15, 2011 1:42 PM To: u-boot@lists.denx.de Cc: Holger Brunck; Valentin Longchamp; Prafulla Wadaskar; Heiko Schocher Subject: [PATCH v2 1/2] arm/kirkwood: if CONFIG_SOFT_I2C is set don't

Re: [U-Boot] [PATCH v2 2/2] arm/km: fix u-boot.kwb build breakage

2011-06-16 Thread Prafulla Wadaskar
-Original Message- From: Holger Brunck [mailto:holger.bru...@keymile.com] Sent: Wednesday, June 15, 2011 1:42 PM To: u-boot@lists.denx.de Cc: Holger Brunck; Valentin Longchamp; Prafulla Wadaskar; Heiko Schocher Subject: [PATCH v2 2/2] arm/km: fix u-boot.kwb build breakage commit

Re: [U-Boot] [PATCH v3 5/5] arm/km: add support for portl2 board

2011-06-16 Thread Prafulla Wadaskar
-Original Message- From: Holger Brunck [mailto:holger.bru...@keymile.com] Sent: Wednesday, June 15, 2011 8:12 PM To: u-boot@lists.denx.de Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar; Heiko Schocher Subject: [PATCH v3 5/5] arm/km: add support for portl2 board From:

[U-Boot] Pull request u-boot-marvell.git

2011-06-16 Thread Prafulla Wadaskar
Hi Albert Please kindly pull The following changes since commit 7b2fac7654f7420c2787f74ec3b1540fa3b343e9: Aneesh V (1): omap730p2: fix build breaks are available in the git repository at: u-boot-marvell.git next branch. Holger Brunck (4): arm/kirkwood: if CONFIG_SOFT_I2C is

[U-Boot] YOUR EMAIL ACCOUNT VERIFICATION

2011-06-16 Thread notice
Attn... We regret to announce to you that we will be making some vital maintainance on your email account/general web upgrade. During this process you might have login problems in signing into your online account, but to prevent this you have to confirm your account immediately after you

Re: [U-Boot] [PATCH v3 02/10] armv7: add miscellaneous utility macros

2011-06-16 Thread Wolfgang Denk
Dear Graeme Russ, In message 4df9e409.1060...@gmail.com you wrote: is equivalent except that, as already pointed out, clrsetbits and friends: a) Are not portable because only ARM and PPC define them which makes them, by definition, non-standard They should be added to _any_

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Aneesh V
Dear Wolfgang, On Thursday 16 June 2011 04:17 PM, Wolfgang Denk wrote: Dear Aneesh, In message4df9b9e0.8020...@ti.com you wrote: To make sure I understand your new proposals, let me consolidate them here. Please correct me if I am wrong. Also, in the end I have some questions about your

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Wolfgang Denk
Dear Aneesh V, In message 4df9ee03.8010...@ti.com you wrote: we are also duplicating the structure across different boot media. I think we should re-organize this as follows: spl/ spl/common/ spl/mmc/ spl/nand/ spl/onenand/ Can you please extend this to

Re: [U-Boot] OpenRD Ultimate SATA SD

2011-06-16 Thread Alexei Ozhigov
2011/6/16 Philip Hands p...@hands.com: On Wed, 15 Jun 2011 22:10:30 -0700, Prafulla Wadaskar prafu...@marvell.com wrote: -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Philip Hands Sent: Wednesday, June 15, 2011 3:24 PM

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Daniel Schwierzeck
Hi all, for my MIPS based boards I tested a approach similar to Wolfgang's one in the last weeks. My goal was to create a SPL image, that is able to boot from a SPI flash. The basic idea is to have a spl directory that is used as remote build directory for all object files needed for the SPL

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Andreas Bießmann
Dear all, Am 16.06.2011 14:55, schrieb Daniel Schwierzeck: snip On Thu, Jun 16, 2011 at 12:47 PM, Wolfgang Denk w...@denx.de wrote: Dear Aneesh, snip We should try to get rid of the need to create symbolic links. If we use the same source files as for the normal, then we should also use

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Aneesh V
On Thursday 16 June 2011 05:45 PM, Wolfgang Denk wrote: Dear Aneesh V, In message4df9ee03.8010...@ti.com you wrote: we are also duplicating the structure across different boot media. I think we should re-organize this as follows: spl/ spl/common/ spl/mmc/ spl/nand/

[U-Boot] [PATCH] MMC: add erase function to both mmc and sd

2011-06-16 Thread Lei Wen
Erase is a very basic function since the begin of sd specification is announced. Although we could write a bulk of full 0xff memory to the range to take place of erase, it is more convenient and safe to implement the erase function itself. Signed-off-by: Lei Wen lei...@marvell.com ---

Re: [U-Boot] [RFC][Timer API] Revised Specification - Implementation details

2011-06-16 Thread Simon Glass
On Wed, Jun 15, 2011 at 11:27 PM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, On Thu, Jun 16, 2011 at 3:53 PM, Simon Glass s...@chromium.org wrote: Hi Graeme, On Wed, Jun 15, 2011 at 4:09 PM, Graeme Russ graeme.r...@gmail.com wrote: [snip] BTW should the deltas return a signed

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Aneesh V
Hi Daniel, This looks like an interesting alternative. On Thursday 16 June 2011 06:25 PM, Daniel Schwierzeck wrote: Hi all, for my MIPS based boards I tested a approach similar to Wolfgang's one in the last weeks. My goal was to create a SPL image, that is able to boot from a SPI flash.

Re: [U-Boot] [PATCH v3 03/10] armv7: cache maintenance operations for armv7

2011-06-16 Thread Simon Glass
Hi, I am picking up on this old thread. My main point is that I think the armv7 cache implementation is a good start and should go into U-Boot. Aneesh are you planning another patch set? Also see below: On Tue, May 17, 2011 at 2:58 AM, Aneesh V ane...@ti.com wrote: Hi Wolfgang, On Tuesday 17

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Daniel Schwierzeck
On Thu, Jun 16, 2011 at 3:57 PM, Aneesh V ane...@ti.com wrote: Hi Daniel, This looks like an interesting alternative. On Thursday 16 June 2011 06:25 PM, Daniel Schwierzeck wrote: Hi all, for my MIPS based boards I tested a approach similar to Wolfgang's one in the last weeks. My goal

[U-Boot] Nested Makefiles

2011-06-16 Thread Simon Glass
Hi, Is it possible for U-Boot to use a system similar to Linux from 2.6 where it prints out the full pathname of each file it is building, and doesn't change in and out of directories as it builds. Perhaps including the subdirectory Makefiles instead using make -C? I haven't looked at how Linux

[U-Boot] [PATCH 1/2] MMC: add sdhci generic framework

2011-06-16 Thread Lei Wen
Nowdays, there are plenty of mmc driver in uboot adopt the sd standard host design, aka as sdhci. It is better to centralize the common logic together to better maintenance. Signed-off-by: Lei Wen lei...@marvell.com --- drivers/mmc/Makefile |1 + drivers/mmc/sdhci.c | 433

[U-Boot] [PATCH 2/2] MMC: add marvell sdhci driver

2011-06-16 Thread Lei Wen
This could support both armada100 and pantheon serial in the mainline, while this driver also be tested to support upcoming mg, mmp2 and mmp3 hardware. Signed-off-by: Lei Wen lei...@marvell.com --- drivers/mmc/Makefile |1 + drivers/mmc/sdhci-mv.c | 21 + 2 files

Re: [U-Boot] [PATCH V2] memcpy/memmove: Do not copy to same address

2011-06-16 Thread Matthias Weisser
Am 14.06.2011 08:18, schrieb Matthias Weißer: Hello Wolfgang Am 23.05.2011 11:03, schrieb Matthias Weisser: In some cases (e.g. bootm with a elf payload which is already at the right position) there is a in place copy of data to the same address. Catching this saves some ms while booting.

Re: [U-Boot] [PATCH 1/1] Fix hang when entering udelay after GPTIMER2 overflows (about 22 minutes on AM37x)

2011-06-16 Thread Igor Grinberg
On 05/17/11 00:52, r...@efn.org wrote: Signed-off-by: Rick Bronson r...@efn.org --- arch/arm/cpu/armv7/omap-common/timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/cpu/armv7/omap-common/timer.c b/arch/arm/cpu/armv7/omap-common/timer.c index

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Scott Wood
On Thu, 16 Jun 2011 13:38:00 +0530 Aneesh V ane...@ti.com wrote: New Design Proposed by Wolfgang: * Have a top-level Makefile in the SPL root-directory - for instance 'nand_spl/Makefile' * nand_spl/Makefile builds a generic library with the generic source files at this level. What is a

Re: [U-Boot] [PATCH v3] NAND: Add 16bit NAND support for the NDFC

2011-06-16 Thread Scott Wood
On Wed, Jun 08, 2011 at 01:29:12PM -0400, Alex Waterman wrote: diff --git a/nand_spl/nand_boot.c b/nand_spl/nand_boot.c index 9545a9a..1d847ef 100644 --- a/nand_spl/nand_boot.c +++ b/nand_spl/nand_boot.c @@ -122,10 +122,15 @@ static int nand_is_bad_block(struct mtd_info *mtd, int block)

[U-Boot] misc patches and cleanup

2011-06-16 Thread Christopher Harvey
I recently dabbled in u-boot and kept track of a few points I found confusing. I fixed them up to the best of my ability and created some patches for consideration. From 9802439149594948e3862b9609ca0e68ab793ecc Mon Sep 17 00:00:00 2001 From: Christopher Harvey char...@matrox.com Date: Wed, 15

Re: [U-Boot] [PATCH 1/1] Fix hang when entering udelay after GPTIMER2 overflows (about 22 minutes on AM37x)

2011-06-16 Thread Rick Bronson
Hi Igor, Yes, I have tested this on the AM3715 but not on any other parts. Cheers, Rick On 05/17/11 00:52, r...@efn.org wrote: Signed-off-by: Rick Bronson r...@efn.org --- arch/arm/cpu/armv7/omap-common/timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [U-Boot] OpenRD Ultimate SATA SD

2011-06-16 Thread Philip Hands
On Thu, 16 Jun 2011 16:18:46 +0400, Alexei Ozhigov alexei.ozhi...@gmail.com wrote: ... I am experiencing the same problem with SATA right now with v2011.06-rc2 (tried also the latest master). If MVSATA_STATUS_TIMEOUT in mvsata_ide_initialize_port is ignored, SATA drive is found on the

Re: [U-Boot] [PATCH v3] NAND: Add 16bit NAND support for the NDFC

2011-06-16 Thread Alex Waterman
From 99efc91f7a3d55bcf0e839ae30c286fd08166010 Mon Sep 17 00:00:00 2001 From: Alex Waterman awater...@dawning.com Date: Thu, 19 May 2011 15:08:36 -0400 Subject: [PATCH] NAND: Add 16bit NAND support for the NDFC This patch adds support for 16 bit NAND devices attached to the NDFC on ppc4xx

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message banlktim9ae2aszklidh53vd+hjpz7gv...@mail.gmail.com you wrote: The relocate_code and board_init_r functions must not be compiled, they are not needed anyway. This can be simply controlled with -DCONFIG_UBOOT_SPL_BUILD. This is very much wrong. In the

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Wolfgang Denk
Dear Aneesh V, In message 4dfa0759.2060...@ti.com you wrote: Can you please extend this to show the SoC/board directories etc. I guess they will go under spl/ and not under each media. Correct, i. e. please add for example: spl/board/freescale/mx31pdk/

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Wolfgang Denk
Dear Aneesh V, In message 4dfa0be1.4060...@ti.com you wrote: In the last few mails Wolfgang was suggesting re-use of object files themselves, not the source files. In this respect his approach may be different from yours. But I think his objective was to avoid the symbolic link business,

Re: [U-Boot] Nested Makefiles

2011-06-16 Thread Wolfgang Denk
Dear Simon Glass, In message BANLkTinE=tpvzfdbdje5m79wedznfyv...@mail.gmail.com you wrote: Is it possible for U-Boot to use a system similar to Linux from 2.6 where it prints out the full pathname of each file it is building, and doesn't change in and out of directories as it builds. Perhaps

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Wolfgang Denk
Dear Scott Wood, In message 20110616114556.7d3c2...@schlenkerla.am.freescale.net you wrote: What is a generic SPL library, or even a generic NAND SPL library? There is no code that is shared by all NAND SPLs. The files directly under nand_spl/ are alternatives that the board makefile can

Re: [U-Boot] misc patches and cleanup

2011-06-16 Thread Wolfgang Denk
Dear Christopher Harvey, In message 4dfa4764.9040...@matrox.com you wrote: I recently dabbled in u-boot and kept track of a few points I found confusing. I fixed them up to the best of my ability and created some patches for consideration. Please read

Re: [U-Boot] SPL framework re-design

2011-06-16 Thread Scott Wood
On Fri, 17 Jun 2011 00:09:00 +0200 Wolfgang Denk w...@denx.de wrote: Dear Scott Wood, In message 20110616114556.7d3c2...@schlenkerla.am.freescale.net you wrote: What is a generic SPL library, or even a generic NAND SPL library? There is no code that is shared by all NAND SPLs. The

Re: [U-Boot] Nested Makefiles

2011-06-16 Thread Måns Rullgård
Wolfgang Denk w...@denx.de writes: Dear Simon Glass, In message BANLkTinE=tpvzfdbdje5m79wedznfyv...@mail.gmail.com you wrote: Is it possible for U-Boot to use a system similar to Linux from 2.6 where it prints out the full pathname of each file it is building, and doesn't change in and

[U-Boot] [PATCH V4 0/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-16 Thread Tom Warren
This patchset adds a GPIO driver for Tegra2 SoC, and enables it for all boards Changes in V2: - use 'gpio_pin' enum in gpio.h (Simon Glass review request) - change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request) - change 'offset' to 'pin' globally - enable

[U-Boot] [PATCH V4 2/2] arm: Tegra2: GPIO: enable GPIO for Tegra2 boards

2011-06-16 Thread Tom Warren
Signed-off-by: Tom Warren twar...@nvidia.com --- Changes in V2: - enable GPIO for all boards (tegra2-common.h) Changes in V3: - enable use of common cmd_gpio include/configs/tegra2-common.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[U-Boot] [PATCH V4 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-16 Thread Tom Warren
Signed-off-by: Tom Warren twar...@nvidia.com --- Changes in V2: - use 'gpio_pin' enum in gpio.h (Simon Glass review request) - change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request) - change 'offset' to 'pin' globally Changes in V3: - use common cmd_gpio;

Re: [U-Boot] [PATCH v3 02/10] armv7: add miscellaneous utility macros

2011-06-16 Thread Graeme Russ
Hi Wolfgang, On Thu, Jun 16, 2011 at 9:46 PM, Wolfgang Denk w...@denx.de wrote: Dear Graeme Russ, In message 4df9e409.1060...@gmail.com you wrote: is equivalent except that, as already pointed out, clrsetbits and friends:  a) Are not portable because only ARM and PPC define them which

Re: [U-Boot] [PATCH V4 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-16 Thread Mike Frysinger
On Thursday, June 16, 2011 19:51:33 Tom Warren wrote: +int gpio_request(int gp, const char *label) +{ + if (gp = MAX_NUM_GPIOS) + return -1; + + strncpy(gpio_names[gp].name, label, GPIO_NAME_SIZE); if the label is =GPIO_NAME_SIZE, the result will not be NUL terminated.

Re: [U-Boot] Nested Makefiles

2011-06-16 Thread Mike Frysinger
On Thursday, June 16, 2011 18:03:07 Wolfgang Denk wrote: Simon Glass wrote: Is it possible for U-Boot to use a system similar to Linux from 2.6 where it prints out the full pathname of each file it is building, and doesn't change in and out of directories as it builds. Perhaps including

Re: [U-Boot] [PATCH V4 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-16 Thread Tom Warren
Mike, On Thu, Jun 16, 2011 at 5:06 PM, Mike Frysinger vap...@gentoo.org wrote: On Thursday, June 16, 2011 19:51:33 Tom Warren wrote: +int gpio_request(int gp, const char *label) +{ +     if (gp = MAX_NUM_GPIOS) +             return -1; + +     strncpy(gpio_names[gp].name, label,

Re: [U-Boot] Nested Makefiles

2011-06-16 Thread Mike Frysinger
On Thursday, June 16, 2011 19:03:21 Måns Rullgård wrote: Aside from the pros and cons of the terse output, getting rid of the recursive makefiles should speed up the u-boot build dramatically. In a typical build, it spends a huge amount of time going in and out of directories only to

[U-Boot] Possible bug in UBIFS function ubifs_finddir

2011-06-16 Thread Rod Boyce
All, Hello again it has been a while since I was here. I am working on u-boot once again and think I may have found a bug in the UBIFS sub-system. The function is ubifs_finddir and the issue is that there seems to be a free of a pointer in a structure that has already been freed. This is

Re: [U-Boot] Booting uncompressed uImages

2011-06-16 Thread Mike Frysinger
On Wednesday, June 15, 2011 13:00:32 David Peverley wrote: I've got an interesting issue with a MIPS board I'm working on. The uncompressed uImage has been created with a Load Address of 0x8050 and an Entry Point of 0x80504590. This gets TFTP's into RAM at 0x8055b728. if it's

Re: [U-Boot] [PATCH v10] Add support for Network Space v2 and parents

2011-06-16 Thread Mike Frysinger
On Wednesday, June 15, 2011 10:39:53 Simon Guinot wrote: Hi Prafulla, please dont top post It appears that this v10 patch is also wrong. The specified email encoding is UTF-8. It should be ISO-8859-1 which is the MAINTAINERS file encoding. It is the reason why the patch is discarded by

Re: [U-Boot] About the CRC of u-boot.bin

2011-06-16 Thread Mike Frysinger
On Monday, June 13, 2011 04:11:57 Andreas Bießmann wrote: The build-timestamp is an quite usable parameter, if it is configurable it should be opt-out. goes without saying When I looked for the char *version_string I found out this is defined in respective architecture board.c. Shouldn't

Re: [U-Boot] [PATCH] MMC: add erase function to both mmc and sd

2011-06-16 Thread Mike Frysinger
On Thursday, June 16, 2011 09:47:56 Lei Wen wrote: + } else if (strcmp(argv[1], erase) == 0) { + u32 cnt = simple_strtoul(argv[3], NULL, 16); + u32 n; + struct mmc *mmc = find_mmc_device(dev); + + int blk = simple_strtoul(argv[2], NULL,

Re: [U-Boot] [PATCH] MMC: add erase function to both mmc and sd

2011-06-16 Thread Lei Wen
Hi Mike, On Fri, Jun 17, 2011 at 8:57 AM, Mike Frysinger vap...@gentoo.org wrote: On Thursday, June 16, 2011 09:47:56 Lei Wen wrote: +     } else if (strcmp(argv[1], erase) == 0) { +             u32 cnt = simple_strtoul(argv[3], NULL, 16); +             u32 n; +             struct mmc *mmc =

Re: [U-Boot] [PATCH] MMC: add erase function to both mmc and sd

2011-06-16 Thread Mike Frysinger
On Thursday, June 16, 2011 23:09:40 Lei Wen wrote: On Fri, Jun 17, 2011 at 8:57 AM, Mike Frysinger wrote: this logic really needs to get cleaned up rather than every sub-mmc command doing the same thing over and over ... Agree, I would sort it out as a seperate patch. thanks. this