Re: [U-Boot] [PATCH 0/7] common/lcd cleanup

2012-06-08 Thread Igor Grinberg
gentle ping... On 05/24/12 14:42, Igor Grinberg wrote: From: Nikita Kiryanov nik...@compulab.co.il This patch series attempts to simplify #ifdef complexity in common/lcd.c. It preceeds my future work of adding splash screen support for omap. It was compile tested on Arm and PowerPC using

Re: [U-Boot] [PATCH v3] ATMEL/PIO: Enable new feature of PIO on Atmel device

2012-06-08 Thread Bo Shen
On 6/1/2012 17:12, Bo Shen wrote: Hi All, On 5/29/2012 16:06, Andreas Bießmann wrote: Dear Bo Shen, On 28.05.2012 09:43, Bo Shen wrote: Hi All, On 5/21/2012 9:50, Bo Shen wrote: Enable new PIO feature supported by Atmel SoC. Using CPU_HAS_PIO3 micro to enable PIO new feature.

Re: [U-Boot] U-boot failed

2012-06-08 Thread Marek Vasut
Dear Zeyad A, Ok, let's first adjust your posting so it's easier for everyone around to read and reply. Firstly please, always CC the u-boot mailing list. Secondly, fix the quoting in your mailer please. Thank you very much for your reply. Please read the my answers below.. On Wed, Jun 6,

Re: [U-Boot] [PATCH v3] [resend] kwboot: boot kirkwood SoCs over a serial link

2012-06-08 Thread Prafulla Wadaskar
-Original Message- From: Luka Perkov [mailto:ub...@lukaperkov.net] Sent: 07 June 2012 18:57 To: u-boot@lists.denx.de Cc: Prafulla Wadaskar Subject: Re: [U-Boot] [PATCH v3] [resend] kwboot: boot kirkwood SoCs over a serial link Hi all, On Sun, May 27, 2012 at 11:44:51PM

Re: [U-Boot] [PATCH 2/7] common lcd: simplify #ifdefs

2012-06-08 Thread Anatolij Gustschin
Hi, On Thu, 24 May 2012 14:42:39 +0300 Igor Grinberg grinb...@compulab.co.il wrote: From: Nikita Kiryanov nik...@compulab.co.il Simplify #ifdefs by slightly changing the order of operations Signed-off-by: Nikita Kiryanov nik...@compulab.co.il Signed-off-by: Igor Grinberg

Re: [U-Boot] [PATCH 3/7] common lcd: simplify bitmap_plot

2012-06-08 Thread Anatolij Gustschin
Hi, On Thu, 24 May 2012 14:42:40 +0300 Igor Grinberg grinb...@compulab.co.il wrote: From: Nikita Kiryanov nik...@compulab.co.il Simplify bitmap_plot in terms of number of #ifdefs by making some of the code into an external macro Signed-off-by: Nikita Kiryanov nik...@compulab.co.il

Re: [U-Boot] [PATCH 7/7] common lcd: simplify lcd_display_bitmap

2012-06-08 Thread Anatolij Gustschin
Hi, On Thu, 24 May 2012 14:42:44 +0300 Igor Grinberg grinb...@compulab.co.il wrote: From: Nikita Kiryanov nik...@compulab.co.il Move highly platform dependant code into its own functions to reduce the number of #ifdefs in lcd_display_bitmap Signed-off-by: Nikita Kiryanov

Re: [U-Boot] U-boot failed

2012-06-08 Thread Marek Vasut
Dear Zeyad A, Dear Mark, Yeah sure, I'll do the CC and what you mean by 'fix the quote in my mailer'?? When you reply on an email, you usually get the old email you reply to prefixed with these (quotes). And I guess your mailed doesn't do that. If my u-boot is broken then what will I do?

Re: [U-Boot] [PATCH 1/7] common lcd: minor coding style changes

2012-06-08 Thread Anatolij Gustschin
Hi, On Thu, 24 May 2012 14:42:38 +0300 Igor Grinberg grinb...@compulab.co.il wrote: From: Nikita Kiryanov nik...@compulab.co.il No functional changes Signed-off-by: Nikita Kiryanov nik...@compulab.co.il Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- checkpatch reports a

[U-Boot] [PATCH 0/6] Support for CPSW switch

2012-06-08 Thread Ilya Yanok
These patches add CPSW switch driver and enable support for it on TI AM335x based boards. We need to detect the board type to configure pins correctly so these patches also include small fix to OMAP I2C driver. CC: Tom Rini tr...@ti.com Signed-off-by: Ilya Yanok ilya.ya...@cogentembedded.com

[U-Boot] [PATCH 1/6] omap24xx_i2c: add 2-byte address support

2012-06-08 Thread Ilya Yanok
Various devices like EEPROMs require 2-byte address support to be properly accessed. This patch adds this support for OMAP2/3/4 I2C controller driver. I've tested it with EEPROM (16 bit address) and TPS65217 chip (8 bit address) on TI Beaglebone board. Unfortunately I don't have access to any

[U-Boot] [PATCH 2/6] cpsw: add driver for cpsw ethernet device

2012-06-08 Thread Ilya Yanok
From: Cyril Chemparathy cy...@ti.com CPSW is an on-chip ethernet switch that is found on various SoCs from Texas Instruments. This patch adds a simple driver (based on the Linux driver) for this hardware module. This patch also adds support to clean and flush dcache during packet send and

[U-Boot] [PATCH 3/6] am33xx: CPSW init and definitions

2012-06-08 Thread Ilya Yanok
This patch adds platform-specific initialization for CPSW switch on TI AM33XX SoCs. CC: Tom Rini tr...@ti.com Signed-off-by: Ilya Yanok ilya.ya...@cogentembedded.com --- arch/arm/cpu/armv7/am33xx/clock.c |8 +++- arch/arm/include/asm/arch-am33xx/cpu.h | 12

[U-Boot] [PATCH 4/6] am33xx: pin mux defintions for CPSW switch

2012-06-08 Thread Ilya Yanok
This patch adds pin mux settings for CPSW switch found on TI AM335X based boards (MII and RGMII modes). CC: Tom Rini tr...@ti.com Signed-off-by: Ilya Yanok ilya.ya...@cogentembedded.com --- arch/arm/include/asm/arch-am33xx/common_def.h |2 ++ board/ti/am335x/mux.c |

[U-Boot] [PATCH 5/6] am335x_evm: read the on-board EEPROM

2012-06-08 Thread Ilya Yanok
Read the on-board EEPROM during startup to detect the version of the board we are running on (as for now only BeagleBone vs EVM detection is supported). CC: Tom Rini tr...@ti.com Signed-off-by: Ilya Yanok ilya.ya...@cogentembedded.com --- board/ti/am335x/evm.c | 72

[U-Boot] [PATCH 6/6] am335x_evm: CPSW support

2012-06-08 Thread Ilya Yanok
This patch adds board-specific initialization for CPSW on TI AM335X based boards. Tested on BeagleBone. CC: Tom Rini tr...@ti.com Signed-off-by: Ilya Yanok ilya.ya...@cogentembedde.com --- board/ti/am335x/evm.c| 86 ++

Re: [U-Boot] [PATCH 4/7] common lcd: simplify lcd_logo

2012-06-08 Thread Anatolij Gustschin
Hi, On Thu, 24 May 2012 14:42:41 +0300 Igor Grinberg grinb...@compulab.co.il wrote: From: Nikita Kiryanov nik...@compulab.co.il Simplify lcd_logo by extracting bmp unzip into its own function. Signed-off-by: Nikita Kiryanov nik...@compulab.co.il Signed-off-by: Igor Grinberg

Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.

2012-06-08 Thread Scott Wood
On 06/07/2012 09:55 PM, Xie Shaohui-B21989 wrote: On 06/06/2012 10:16 PM, Xie Shaohui-B21989 wrote: -Original Message- From: Wood Scott-B07421 Sent: Thursday, June 07, 2012 2:19 AM To: Xie Shaohui-B21989 Cc: Wood Scott-B07421; u-boot@lists.denx.de; Tabi Timur-B04825 Subject: Re:

[U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Marek Vasut
Quote from the manpage: [...] void *calloc(size_t nmemb, size_t size); [...] DESCRIPTION [...] The calloc() function allocates memory for an array of nmemb elements of size bytes each and returns a pointer to the allocated memory. The memory is set to zero. If

[U-Boot] [PATCH 0/8] EXT2 cleanup

2012-06-08 Thread Marek Vasut
Now I'm angry ... So, I cleaned up the ext2 filesystem code a bit. I tried to separate the changes to increase the reviewability. Marek Vasut (8): EXT2: Indent cleanup of dev.c EXT2: Indent cleanup ext2fs.c EXT2: Rework ext2fs_blockgroup() function EXT2: Rework ext2fs_read_file() EXT2:

[U-Boot] [PATCH 1/8] EXT2: Indent cleanup of dev.c

2012-06-08 Thread Marek Vasut
Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/dev.c | 74 +++-- 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/fs/ext2/dev.c b/fs/ext2/dev.c index 315ff53..f8cb8b7 100644 ---

[U-Boot] [PATCH 2/8] EXT2: Indent cleanup ext2fs.c

2012-06-08 Thread Marek Vasut
* Mostly cleanup problems reported by checkpatch.pl -f * Minor tweaks where it simplified the code Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 264 ++ 1 file changed, 128 insertions(+), 136

[U-Boot] [PATCH 3/8] EXT2: Rework ext2fs_blockgroup() function

2012-06-08 Thread Marek Vasut
Rework the function, constify every possible component. Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c index

[U-Boot] [PATCH 4/8] EXT2: Rework ext2fs_read_file()

2012-06-08 Thread Marek Vasut
* Fix indentation * Move all definitions of variables to the begining of the function Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 65 -- 1 file changed, 34 insertions(+), 31 deletions(-)

[U-Boot] [PATCH 6/8] EXT2: Rework ext2fs_find_file1()

2012-06-08 Thread Marek Vasut
* Fix indent * Pull variables defined deep in the code at the begining Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 101 +++--- 1 file changed, 50 insertions(+), 51 deletions(-) diff --git

[U-Boot] [PATCH 7/8] EXT2: Rework ext2fs_iterate_dir()

2012-06-08 Thread Marek Vasut
* Indent cleanup * Pull most variables defined inside the code to the begining (note: there are variables marked with FIXME now, those will be processed in subsequent patch) Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 139

[U-Boot] [PATCH 5/8] EXT2: Rework ext2fs_read_symlink()

2012-06-08 Thread Marek Vasut
* Fix indent * Read inode size only once, as it can be reused Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/fs/ext2/ext2fs.c

[U-Boot] [PATCH 8/8] EXT2: Rework ext2fs_read_block()

2012-06-08 Thread Marek Vasut
Fix indentation complains from checkpatch.pl Signed-off-by: Marek Vasut ma...@denx.de Cc: Wolfgang Denk w...@denx.de --- fs/ext2/ext2fs.c | 130 ++ 1 file changed, 63 insertions(+), 67 deletions(-) diff --git a/fs/ext2/ext2fs.c

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Albert ARIBAUD
Le 07/06/2012 18:02, Tom Warren a écrit : Albert, On Thu, May 31, 2012 at 9:47 AM, Tom Warrentwarren.nvi...@gmail.com wrote: Albert, Please pull u-boot-tegra/master into ARM master. Thanks! Haven't seen a reply, so repinging you. Hi Tom, Sorry for taking so long. Testing the branch right

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Albert ARIBAUD
Hi Tom, Le 31/05/2012 18:47, Tom Warren a écrit : Albert, Please pull u-boot-tegra/master into ARM master. Thanks! The following changes since commit 2ca4a209a5b961ad1be8782c68dabe326d77dfaf: SRICHARAN R (1): OMAP4/5: Change omap4_sdp, omap4_panda, omap5_evm maintainer are

[U-Boot] Pull request: nand flash

2012-06-08 Thread Scott Wood
The following changes since commit fedab338f3459315cb69627fcf46032ec8df1753: Merge branch 'master' of git://git.denx.de/u-boot-video (2012-06-07 23:42:17 +0200) are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master Steve Sakoman (1): cmd_nand: fix

Re: [U-Boot] [PATCH v2 1/7] tegra: Rework Tamonten support

2012-06-08 Thread Allen Martin
On Fri, May 25, 2012 at 06:46:22AM -0700, Thierry Reding wrote: This commit uses the common Tegra board implementation instead of duplicating a lot of the code. In addition, the Plutux and Medcom specific board files can be removed as the MMC/SD setup is common among all Tamonten-based boards.

Re: [U-Boot] [PATCH v3 7/7] tegra: Add Tamonten Evaluation Carrier support

2012-06-08 Thread Allen Martin
On Mon, Jun 04, 2012 at 11:02:30PM -0700, Thierry Reding wrote: The Tamonten Evaluation Carrier is an evaluation board for the Tamonten processor board. More information is available here:

Re: [U-Boot] [PATCH v2 1/7] tegra: Rework Tamonten support

2012-06-08 Thread Stephen Warren
On 06/08/2012 02:01 PM, Allen Martin wrote: On Fri, May 25, 2012 at 06:46:22AM -0700, Thierry Reding wrote: This commit uses the common Tegra board implementation instead of duplicating a lot of the code. In addition, the Plutux and Medcom specific board files can be removed as the MMC/SD

[U-Boot] [PATCH v3 09/14] tegra20: add u-boot.t2 target

2012-06-08 Thread Allen Martin
Add target for tegra20 u-boot image. This is a concatenation of tegra spl and normal u-boot binaries. Signed-off-by: Allen Martin amar...@nvidia.com --- .gitignore |1 + Makefile| 11 +++ board/nvidia/seaboard/config.mk |1 + 3

[U-Boot] [PATCH v3 10/14] tegra: move SDRAM param save to later in boot

2012-06-08 Thread Allen Martin
Move warmboot_save_sdram_params() to later in the boot sequence. This code relies on devicetree to get the address of the memory controller and with upcoming changes for SPL boot it gets called early in the boot process when devicetree is not initialized yet. Signed-off-by: Allen Martin

[U-Boot] [PATCH v3 04/14] mkconfig: add support for SPL CPU

2012-06-08 Thread Allen Martin
Add support for specifying a different CPU for main u-boot and SPL u-boot builds. This is done by adding an optional SPL CPU after the main CPU in boards.cfg as follows: normal_cpu:spl_cpu This this case CPU will be set to normal_cpu during the main u-boot build and spl_cpu during the SPL

[U-Boot] [PATCH v3 06/14] tegra20: remove timer_init from SPL build

2012-06-08 Thread Allen Martin
Don't use timer_init from tegra board.c. This comes out of arm720t for the SPL build. Signed-off-by: Allen Martin amar...@nvidia.com --- board/nvidia/common/board.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c index

[U-Boot] [PATCH v3 13/14] tegra20: plutux: change obj directory mkdir commands

2012-06-08 Thread Allen Martin
Change the mkdir commands for the object directories to be more general purpose. This fixes an issue when building for SPL where SRCTREE and OBJTREE are the same, but $(obj) is under SPLTREE. Signed-off-by: Allen Martin amar...@nvidia.com --- board/avionic-design/plutux/Makefile |7 +--

[U-Boot] [PATCH v3 03/14] tegra20: rename CONFIG_MACH_TEGRA_GENERIC

2012-06-08 Thread Allen Martin
Rename CONFIG_MACH_TEGRA_GENERIC to the less confusing CONFIG_TEGRA. The meaning of the config options is now: CONFIG_TEGRA - Any tegra chip CONFIG_TEGRA20 - A tegra20 family chip CONFIG_TEGRA30 - A tegra30 family chip (not added yet) Signed-off-by: Allen Martin amar...@nvidia.com ---

[U-Boot] [PATCH v3 11/14] tegra20: Remove CPU init code from tegra20 u-boot

2012-06-08 Thread Allen Martin
This code is now included in the tegra20 SPL Signed-off-by: Allen Martin amar...@nvidia.com --- arch/arm/cpu/armv7/start.S |2 - arch/arm/cpu/tegra20-common/ap20.c | 258 +-- arch/arm/cpu/tegra20-common/board.c | 23 +---

[U-Boot] [PATCH v3 05/14] ARM: Fix arm720t SPL build

2012-06-08 Thread Allen Martin
Take a few SPL fixes from armv7 and apply them to arm720t: -Use dummy exception handlers for SPL build -Initialize relocation register r9 to 0 for the case of no relocation -ifdef out interrupt handler code Signed-off-by: Allen Martin amar...@nvidia.com --- arch/arm/cpu/arm720t/start.S | 13

[U-Boot] [PATCH v3 14/14] tegra20: tec: add tegra20-common-post.h

2012-06-08 Thread Allen Martin
Add tegra20-common-post.h to be consistent with other tegra20 boards. Signed-off-by: Allen Martin amar...@nvidia.com --- include/configs/tec.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/tec.h b/include/configs/tec.h index 39400d9..9b3f88d 100644 ---

[U-Boot] [PATCH v3 02/14] tegra20: move tegra20 SoC code to arch/arm/cpu/tegra20-common

2012-06-08 Thread Allen Martin
In preparation for splitting out the armv4t code from tegra20, move the tegra20 SoC code to arch/arm/cpu/tegra20-common. This code will be compiled armv4t for the arm7tdmi and armv7 for the cortex A9. Signed-off-by: Allen Martin amar...@nvidia.com --- Makefile

[U-Boot] [PATCH v3 0/14] split tegra20 arm7 code into separate SPL

2012-06-08 Thread Allen Martin
This patch series fixes a long standing problem with the tegra20 u-boot build. Tegra20 contains an ARM7TDMI boot processor and a Cortex A9 main processor. Prior to this patch series this was accomplished by #ifdefing out any armv7 code from the early boot sequence and creating a single binary

[U-Boot] [PATCH v3 08/14] tegra20: add SPL config options for tegra20 boards

2012-06-08 Thread Allen Martin
Add SPL options to tegra20 config files and enable SPL build for tegra20 boards in boards.cfg Signed-off-by: Allen Martin amar...@nvidia.com --- boards.cfg| 18 - include/configs/tegra20-common-post.h | 65 +

[U-Boot] [PATCH v3 12/14] tegra20: Remove armv4t build flags

2012-06-08 Thread Allen Martin
These flags were necessary when building tegra20 as a single binary that supported ARM7TDMI and Cortex A9. Now that the ARM7TDMI support is split into a separate SPL, this is no longer necessary. Signed-off-by: Allen Martin amar...@nvidia.com --- arch/arm/cpu/armv7/tegra20/config.mk | 12

[U-Boot] [PATCH v3 07/14] ARM: add tegra20 support to arm720t

2012-06-08 Thread Allen Martin
Add support for tegra20 arm7 boot processor. This processor is used to power on the Cortex A9 and transfer control to it. Signed-off-by: Allen Martin amar...@nvidia.com --- arch/arm/cpu/arm720t/cpu.c |2 + arch/arm/cpu/arm720t/interrupts.c |4 +

Re: [U-Boot] [PATCH v2 1/7] tegra: Rework Tamonten support

2012-06-08 Thread Allen Martin
On Fri, Jun 08, 2012 at 02:07:25PM -0700, Stephen Warren wrote: On 06/08/2012 02:01 PM, Allen Martin wrote: On Fri, May 25, 2012 at 06:46:22AM -0700, Thierry Reding wrote: This commit uses the common Tegra board implementation instead of duplicating a lot of the code. In addition, the

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Albert ARIBAUD
Hi Tom, Le 31/05/2012 18:47, Tom Warren a écrit : Albert, Please pull u-boot-tegra/master into ARM master. Thanks! The following changes since commit 2ca4a209a5b961ad1be8782c68dabe326d77dfaf: SRICHARAN R (1): OMAP4/5: Change omap4_sdp, omap4_panda, omap5_evm maintainer are

Re: [U-Boot] [PATCH v3 07/14] ARM: add tegra20 support to arm720t

2012-06-08 Thread Tom Warren
-Original Message- From: Allen Martin [mailto:amar...@nvidia.com] Sent: Friday, June 08, 2012 2:16 PM To: Tom Warren; swar...@wwwdotorg.org; s...@chromium.org; thierry.red...@avionic-design.de Cc: u-boot@lists.denx.de; Allen Martin Subject: [PATCH v3 07/14] ARM: add tegra20

Re: [U-Boot] [PATCH v3 01/14] tegra20: rename tegra2 - tegra20

2012-06-08 Thread Tom Warren
Allen, -Original Message- From: Allen Martin [mailto:amar...@nvidia.com] Sent: Friday, June 08, 2012 2:16 PM To: Tom Warren; swar...@wwwdotorg.org; s...@chromium.org; thierry.red...@avionic-design.de Cc: u-boot@lists.denx.de; Allen Martin Subject: [PATCH v3 01/14] tegra20: rename

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:44 PM, Albert ARIBAUD wrote: Hi Tom, Le 31/05/2012 18:47, Tom Warren a écrit : Albert, Please pull u-boot-tegra/master into ARM master. Thanks! The following changes since commit 2ca4a209a5b961ad1be8782c68dabe326d77dfaf: SRICHARAN R (1): OMAP4/5: Change

[U-Boot] [PATCH] fdt: send all dtc output to stderr

2012-06-08 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Commit 896bbb5 fdt: avoid bad MAKEALL status added logic to capture the result code from dtc by echoing $? to stdout and capturing it using $(). However, dtc emits some diagnostics to stderr and some to stdout. The diagnostics send to stdout ended up

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Stephen Warren
On 06/08/2012 04:00 PM, Stephen Warren wrote: On 06/08/2012 03:44 PM, Albert ARIBAUD wrote: Hi Tom, Le 31/05/2012 18:47, Tom Warren a écrit : Albert, Please pull u-boot-tegra/master into ARM master. Thanks! The following changes since commit 2ca4a209a5b961ad1be8782c68dabe326d77dfaf:

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Stephen Warren
On 06/08/2012 04:36 PM, Stephen Warren wrote: On 06/08/2012 04:00 PM, Stephen Warren wrote: On 06/08/2012 03:44 PM, Albert ARIBAUD wrote: Hi Tom, Le 31/05/2012 18:47, Tom Warren a écrit : Albert, Please pull u-boot-tegra/master into ARM master. Thanks! The following changes since commit

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Wolfgang Denk
Dear Marek Vasut, In message 1339176514-13137-1-git-send-email-ma...@denx.de you wrote: -#define kzalloc(size, flags) calloc(size, 1) +#define kzalloc(size, flags) calloc(1, size) Does this make any practical difference? I mean, are you aware of any problem that gets fixed by this patch, or

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Marek Vasut
Dear Wolfgang Denk, Dear Marek Vasut, In message 1339176514-13137-1-git-send-email-ma...@denx.de you wrote: -#define kzalloc(size, flags) calloc(size, 1) +#define kzalloc(size, flags) calloc(1, size) Does this make any practical difference? I mean, are you aware of any

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Wolfgang Denk
Dear Marek Vasut, In message 201206090148.40933.ma...@denx.de you wrote: Multiplication being commutative, I see zero effect in this patch? Well, not in every algebraic system. It has zero effect, it's only about correctness [1]. Will applying this break anything? In which way is a *

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Marek Vasut
Dear Wolfgang Denk, Dear Marek Vasut, In message 201206090148.40933.ma...@denx.de you wrote: Multiplication being commutative, I see zero effect in this patch? Well, not in every algebraic system. It has zero effect, it's only about correctness [1]. Will applying this break

Re: [U-Boot] pull request for u-boot-tegra/master

2012-06-08 Thread Simon Glass
Hi Stephen, On Fri, Jun 8, 2012 at 3:52 PM, Stephen Warren swar...@wwwdotorg.orgwrote: On 06/08/2012 04:36 PM, Stephen Warren wrote: On 06/08/2012 04:00 PM, Stephen Warren wrote: On 06/08/2012 03:44 PM, Albert ARIBAUD wrote: Hi Tom, Le 31/05/2012 18:47, Tom Warren a écrit : Albert,

Re: [U-Boot] [PATCH v3 07/14] ARM: add tegra20 support to arm720t

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:16 PM, Allen Martin wrote: Add support for tegra20 arm7 boot processor. This processor is used to power on the Cortex A9 and transfer control to it. diff --git a/arch/arm/cpu/tegra20-common/Makefile b/arch/arm/cpu/tegra20-common/Makefile -COBJS-$(CONFIG_TEGRA2_LP0) +=

Re: [U-Boot] [PATCH v3 08/14] tegra20: add SPL config options for tegra20 boards

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:16 PM, Allen Martin wrote: Add SPL options to tegra20 config files and enable SPL build for tegra20 boards in boards.cfg diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h @@ -183,7 +183,7 @@ #define PHYS_SDRAM_1 TEGRA20_SDRC_CS0

Re: [U-Boot] [PATCH v3 09/14] tegra20: add u-boot.t2 target

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:16 PM, Allen Martin wrote: Add target for tegra20 u-boot image. This is a concatenation of tegra spl and normal u-boot binaries. diff --git a/board/nvidia/seaboard/config.mk b/board/nvidia/seaboard/config.mk +PAD_TO=0x00208000 Can we use $(CONFIG_SYS_TEXT_BASE) or similar

Re: [U-Boot] [PATCH v3 12/14] tegra20: Remove armv4t build flags

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:16 PM, Allen Martin wrote: These flags were necessary when building tegra20 as a single binary that supported ARM7TDMI and Cortex A9. Now that the ARM7TDMI support is split into a separate SPL, this is no longer necessary. diff --git a/arch/arm/cpu/tegra20-common/Makefile

Re: [U-Boot] [PATCH v2 1/7] tegra: Rework Tamonten support

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:27 PM, Allen Martin wrote: On Fri, Jun 08, 2012 at 02:07:25PM -0700, Stephen Warren wrote: On 06/08/2012 02:01 PM, Allen Martin wrote: On Fri, May 25, 2012 at 06:46:22AM -0700, Thierry Reding wrote: This commit uses the common Tegra board implementation instead of duplicating

Re: [U-Boot] [PATCH v3 13/14] tegra20: plutux: change obj directory mkdir commands

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:16 PM, Allen Martin wrote: Change the mkdir commands for the object directories to be more general purpose. This fixes an issue when building for SPL where SRCTREE and OBJTREE are the same, but $(obj) is under SPLTREE. Aside from my comments in the thread re: v2 of this

Re: [U-Boot] [PATCH v3 0/14] split tegra20 arm7 code into separate SPL

2012-06-08 Thread Stephen Warren
On 06/08/2012 03:15 PM, Allen Martin wrote: This patch series fixes a long standing problem with the tegra20 u-boot build. Tegra20 contains an ARM7TDMI boot processor and a Cortex A9 main processor. Prior to this patch series this was accomplished by #ifdefing out any armv7 code from the

Re: [U-Boot] [PATCH 0/8] EXT2 cleanup

2012-06-08 Thread Jorgen Lundman
Marek Vasut wrote: Now I'm angry ... So, I cleaned up the ext2 filesystem code a bit. I tried to separate the changes to increase the reviewability. If you are angry, that makes me not want to comment, especially since I don't belong here. But one question that springs to mind is, the