Re: [U-Boot] [PATCH v3 0/4] sun7i: PSCI enhancements

2015-01-11 Thread Jan Kiszka
On 2015-01-11 11:30, Hans de Goede wrote: Hi, On 11-01-15 10:59, Ian Campbell wrote: I've applied #1 and #3. I'd like to hear from Hans on the v0.2 stuff. I've no real opinion on this, I do NOT like the introduction of a third version of the i2c / rsb and axp code (we already have both a

Re: [U-Boot] [PATCH] sunxi: axp221: correct ALDO2 description for sun6i

2015-01-11 Thread Ian Campbell
On Sun, 2015-01-11 at 17:41 +0800, Chen-Yu Tsai wrote: On Sun, Jan 11, 2015 at 5:38 PM, Ian Campbell i...@hellion.org.uk wrote: On Sat, 2015-01-03 at 10:17 +0800, Chen-Yu Tsai wrote: ALDO2 is used to power LPDDR2 SDRAM on both the reference design and the Hummingbird A31, when this type of

Re: [U-Boot] [PATCH] sunxi: axp221: correct ALDO2 description for sun6i

2015-01-11 Thread Ian Campbell
On Sat, 2015-01-03 at 10:17 +0800, Chen-Yu Tsai wrote: ALDO2 is used to power LPDDR2 SDRAM on both the reference design and the Hummingbird A31, when this type of RAM is present. Signed-off-by: Chen-Yu Tsai w...@csie.org I think this one needs Hans' opinion more than mine, but looks OK to me

Re: [U-Boot] [PATCH v3 0/4] sun7i: PSCI enhancements

2015-01-11 Thread Ian Campbell
I've applied #1 and #3. I'd like to hear from Hans on the v0.2 stuff. Also, the other patches are touching generic arm code, so ought to be CC-d to (and perhaps go via) the core ARM maintainer (Albert Aribaud). IMHO it would be better if the common code changes involved platform-selectable

Re: [U-Boot] [PATCH] sun8i: remove extra whitespace in dram initialization support code

2015-01-11 Thread Ian Campbell
On Sun, 2015-01-11 at 09:48 +0800, Chen-Yu Tsai wrote: This removes an extra whitespace introduced in an earlier commit a474d11 (sun8i: Add dram initialization support). Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Ian Campbell i...@hellion.org.uk The patch introducing the whitespace

Re: [U-Boot] [PATCH V2] add README.distro file

2015-01-11 Thread Ian Campbell
On Sun, 2014-12-28 at 09:26 +, Ian Campbell wrote: +boot_scripts: + + The name of U-Boot style boot.scr files that $bootcmd searches for. + + Example: boot.scr.uimg boot.scr + + (Typically we expect extlinux.conf to be used, but execution of boot.scr is + maintained for

Re: [U-Boot] [PATCH] sunxi: axp221: correct ALDO2 description for sun6i

2015-01-11 Thread Chen-Yu Tsai
On Sun, Jan 11, 2015 at 5:38 PM, Ian Campbell i...@hellion.org.uk wrote: On Sat, 2015-01-03 at 10:17 +0800, Chen-Yu Tsai wrote: ALDO2 is used to power LPDDR2 SDRAM on both the reference design and the Hummingbird A31, when this type of RAM is present. Signed-off-by: Chen-Yu Tsai w...@csie.org

Re: [U-Boot] [PATCH v3 0/4] sun7i: PSCI enhancements

2015-01-11 Thread Hans de Goede
Hi, On 11-01-15 10:59, Ian Campbell wrote: I've applied #1 and #3. I'd like to hear from Hans on the v0.2 stuff. I've no real opinion on this, I do NOT like the introduction of a third version of the i2c / rsb and axp code (we already have both a u-boot and a kernel version to maintain of

Re: [U-Boot] [PATCH 0/8] video: Add support for SSD2828 (parallel LCD to MIPI bridge)

2015-01-11 Thread Siarhei Siamashka
On Fri, 09 Jan 2015 16:35:09 +0100 Hans de Goede hdego...@redhat.com wrote: Hi, On 09-01-15 11:01, Siarhei Siamashka wrote: Hello, This patchset adds support for the Solomon Systech SSD2828 bridge chip, which is used to convert parallel LCD interface into MIPI DSI interface and

Re: [U-Boot] [PATCH 2/8] include: Add header file with MIPI DSI constants from the Linux kernel

2015-01-11 Thread Siarhei Siamashka
On Fri, 9 Jan 2015 18:15:44 +0100 Anatolij Gustschin ag...@denx.de wrote: On Fri, 9 Jan 2015 12:01:10 +0200 Siarhei Siamashka siarhei.siamas...@gmail.com wrote: It provides some constants for DCS commands, which are needed to implement support for SSD2828. we usually ask for

Re: [U-Boot] [PATCH 1/8] sunxi: axp221: Add ELDO[1-3] support

2015-01-11 Thread Siarhei Siamashka
On Fri, 9 Jan 2015 18:05:35 +0100 Anatolij Gustschin ag...@denx.de wrote: On Fri, 9 Jan 2015 12:01:09 +0200 Siarhei Siamashka siarhei.siamas...@gmail.com wrote: ... +int axp221_set_eldo2(unsigned int mvolt) +{ + int ret; + u8 cfg = axp221_mvolt_to_cfg(mvolt, 700, 3300, 100); +

Re: [U-Boot] [PATCH 1/8] sunxi: axp221: Add ELDO[1-3] support

2015-01-11 Thread Hans de Goede
Hi, On 11-01-15 13:05, Siarhei Siamashka wrote: On Fri, 9 Jan 2015 18:05:35 +0100 Anatolij Gustschin ag...@denx.de wrote: On Fri, 9 Jan 2015 12:01:09 +0200 Siarhei Siamashka siarhei.siamas...@gmail.com wrote: ... +int axp221_set_eldo2(unsigned int mvolt) +{ + int ret; + u8 cfg =

Re: [U-Boot] [PATCH] tools/kwbimage.c: fix parser error handling

2015-01-11 Thread Andreas Bießmann
ping? It is http://patchwork.ozlabs.org/patch/403237/ On 13.11.14 22:42, Jeroen Hofstee wrote: Hello Andreas, On 27-10-14 13:06, Jeroen Hofstee wrote: Hello Andreas, On 24-10-14 23:25, andreas.de...@googlemail.com wrote: From: Andreas Bießmann andreas.de...@googlemail.com The two error

Re: [U-Boot] tools/kwbimage.c: fix parser error handling

2015-01-11 Thread Tom Rini
On Fri, Oct 24, 2014 at 11:25:52PM +0200, Andreas Bießmann wrote: From: Andreas Bießmann andreas.de...@googlemail.com The two error checks for image_boot_mode_id and image_nand_ecc_mode_id where wrong and would never fail, fix that! This was detected by Apple's clang compiler: Applied to

[U-Boot] [PATCH 01/17] sunxi: axp221: Protect axp221_init against multiple calls

2015-01-11 Thread Hans de Goede
The voltage setting code knows it needs to call axp221_init before calling the various voltage setting functions. But users of axp utility functions like axp221_get_sid() do not know this, so the utility functions always call axp221_init() to ensure that the p2wi / rsb setup magic has been done.

[U-Boot] [PATCH 02/17] sunxi: axp221: Add support for controlling the drivebus pin

2015-01-11 Thread Hans de Goede
The axp221 / axp223's N_VBUSEN pin can be configured as an output rather then an input, add axp_drivebus_enable() and _disable() functions to set the pin in output mode and control it. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/power/axp221.c | 36

[U-Boot] [PATCH 04/17] sunxi: usbc: Add support for usb0 to the common usbc code

2015-01-11 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/cpu/armv7/sunxi/usbc.c | 33 --- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 4 +++- arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 2 ++ board/sunxi/Kconfig | 7

[U-Boot] [PATCH 00/17] sunxi: musb otg controller support

2015-01-11 Thread Hans de Goede
Hi Marek, Ian, et al, I'm very happy to present this patch series, which is the last pieze of the puzzle to make it possible for people to use u-boot on sunxi devices without needing to resort to putting a soldering iron to their tablet :) With this series sunxi tablet owners can simply plug in

[U-Boot] [PATCH 07/17] usb: Add an interval parameter to create_int_queue

2015-01-11 Thread Hans de Goede
Currently create_int_queue is only implemented by the ehci code, and that does not honor interrupt intervals, but other drivers which might also want to implement create_int_queue may honor intervals, so add an interval param. Signed-off-by: Hans de Goede hdego...@redhat.com --- common/usb_kbd.c

[U-Boot] [PATCH 09/17] musb-new: Add register defines for different reg layout on sunxi

2015-01-11 Thread Hans de Goede
The sunxi SoCs also have a musb controller, but with a different register layout. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb-new/musb_regs.h | 92 1 file changed, 92 insertions(+) diff --git a/drivers/usb/musb-new/musb_regs.h

[U-Boot] [PATCH 03/17] sunxi: Move usb-controller init code out of ehci-sunxi.c for reuse for otg

2015-01-11 Thread Hans de Goede
Most of the usb-controller init code found in ehci-sunxi.c also is necessary to init the otg usb controller, so move it to a common place. While at it also update various #ifdefs / defines for sun8i support. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/cpu/armv7/sunxi/Makefile

[U-Boot] [PATCH 05/17] sunxi: usbc: Add support for usb-vbus0 controller by axp drivebus pin

2015-01-11 Thread Hans de Goede
The axp221 / axp223's N_VBUSEN pin can be configured as an output rather then an input, and this is used on some boards to control usb-vbus0, add support for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/cpu/armv7/sunxi/usbc.c | 26 ++ 1 file

[U-Boot] [PATCH 08/17] usb: Do not log an error when no devices is plugged into a root-hub-less hcd

2015-01-11 Thread Hans de Goede
Before this commit u-boot would print the following on boot with musb and no usb device plugged in: starting USB... USB0: Port not available. USB error: all controllers failed lowlevel init This commit changes this to: starting USB... USB0: Port not available. Which is the correct thing to

[U-Boot] [PATCH 06/17] usb: Fix usb_kbd_deregister when console-muxing is used

2015-01-11 Thread Hans de Goede
When iomuxing is used we must not only deregister the device with stdio.c, but also remove the reference to the device in the console_devices array used by console-muxing. Add a call to iomux_doenv to usb_kbd_deregister to update console_devices, which will drop the reference. This fixes the

[U-Boot] [PATCH 11/17] musb-new: Use time based timeouts rather then cpu-cycles based timeouts

2015-01-11 Thread Hans de Goede
CPU cycle based timeouts are no good, because how long they use depends on CPU speed. Instead use time based timeouts, and wait one second for a device connection to show up (per the USB spec), and wait USB_TIMEOUT_MS for various urbs to complete. This fixes usb start taking for ever when no

[U-Boot] [PATCH 12/17] musb-new: Fix interrupt transfers not working

2015-01-11 Thread Hans de Goede
For bulk and ctrl transfers common/usb.c sets udev-status = USB_ST_NOT_PROC, but it does not do so for interrupt transfers. musb_uboot.c: submit_urb() however was waiting for USB_ST_NOT_PROC to become 0, and thus without anyone setting USB_ST_NOT_PROC would exit immediately for interrupt urbs,

[U-Boot] [PATCH 14/17] musb-new: Properly remove a transfer from the schedule on timeout

2015-01-11 Thread Hans de Goede
If a transfer / urb times-out, properly remove it from the schedule, rather then letting it sit on the ep head. This stops the musb code from getting confused and refusing to queue further transfers after a timeout. Tested by unplugging a usb-keyboard, replugging it and doing a usb-reset, before

[U-Boot] [PATCH v2] usb: Add an interval parameter to create_int_queue

2015-01-11 Thread Hans de Goede
Currently create_int_queue is only implemented by the ehci code, and that does not honor interrupt intervals, but other drivers which might also want to implement create_int_queue may honor intervals, so add an interval param. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2:

[U-Boot] [PATCH 15/17] musb-new: Add urb and hep parameters to construct_urb

2015-01-11 Thread Hans de Goede
Make construct_urb take an urb and hep parameter, rather then having it always operate on the file global urb and hep structs. This is a preperation patch for adding interrupt queue support. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb-new/musb_uboot.c | 63

[U-Boot] [PATCH 17/17] sunxi: Hookup OTG USB controller support

2015-01-11 Thread Hans de Goede
Hookup OTG USB controller support and enable the otg controller + USB-keyb on various tablets. This allows tablet owners to interact with u-boot without needing to solder a serial console onto their tablet PCB. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[U-Boot] [PATCH 13/17] musb-new: Fix reset sequence when in host mode

2015-01-11 Thread Hans de Goede
This commit fixes a number of issues with the reset sequence of musb-new in host mode: 1) Our usb device probe relies on a second device reset being done after the first descriptors read. Factor the musb reset code into a usb_reset_root_port function (and add this as an empty define for other

[U-Boot] [PATCH 10/17] musb-new: Add sunxi musb controller support

2015-01-11 Thread Hans de Goede
This is based on Jussi Kivilinna's work for the linux-sunxi-3.4 kernel to use the kernels musb driver instead of Allwinners own custom driver. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb-new/Makefile | 1 + drivers/usb/musb-new/sunxi.c | 279

[U-Boot] [PATCH 16/17] musb-new: Add interrupt queue support

2015-01-11 Thread Hans de Goede
Add interrupt queue support, so that a usb keyboard can be used without causing huge latencies. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb-new/musb_uboot.c | 65 +++ include/usb.h | 3 +- 2 files changed, 67

Re: [U-Boot] [PATCH V2] add README.distro file

2015-01-11 Thread Tom Rini
On Sun, Jan 11, 2015 at 10:54:03AM -0700, Stephen Warren wrote: On 01/11/2015 02:45 AM, Ian Campbell wrote: On Sun, 2014-12-28 at 09:26 +, Ian Campbell wrote: +boot_scripts: + + The name of U-Boot style boot.scr files that $bootcmd searches for. + + Example: boot.scr.uimg

Re: [U-Boot] [PATCH V2] add README.distro file

2015-01-11 Thread Stephen Warren
On 01/11/2015 02:45 AM, Ian Campbell wrote: On Sun, 2014-12-28 at 09:26 +, Ian Campbell wrote: +boot_scripts: + + The name of U-Boot style boot.scr files that $bootcmd searches for. + + Example: boot.scr.uimg boot.scr + + (Typically we expect extlinux.conf to be used, but execution

Re: [U-Boot] [PATCH 2/2] sunxi: Enable pre-console buffer

2015-01-11 Thread Simon Glass
Hi Siarhei, On 11 January 2015 at 16:28, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Sat, 10 Jan 2015 08:24:52 -0700 Simon Glass s...@chromium.org wrote: Hi, On 10 January 2015 at 03:50, Ian Campbell i...@hellion.org.uk wrote: On Fri, 2015-01-09 at 13:13 +0200, Siarhei

Re: [U-Boot] [PATCH 00/17] sunxi: musb otg controller support

2015-01-11 Thread Marek Vasut
On Sunday, January 11, 2015 at 08:34:38 PM, Hans de Goede wrote: Hi Marek, Ian, et al, I'm very happy to present this patch series, which is the last pieze of the puzzle to make it possible for people to use u-boot on sunxi devices without needing to resort to putting a soldering iron to

Re: [U-Boot] [PATCH 1/3] samsung: board: support eMMC reset using DT

2015-01-11 Thread Joonyoung Shim
On 01/12/2015 10:45 AM, Jaehoon Chung wrote: On 01/11/2015 02:46 AM, Simon Glass wrote: Hi, On 9 January 2015 at 23:53, Joonyoung Shim jy0922.s...@samsung.com wrote: On 01/09/2015 08:13 PM, Jaehoon Chung wrote: On 01/09/2015 04:31 PM, Joonyoung Shim wrote: +Cc Jaehoon, On 01/09/2015

Re: [U-Boot] [PATCH 2/2] sunxi: Enable pre-console buffer

2015-01-11 Thread Siarhei Siamashka
On Sat, 10 Jan 2015 08:24:52 -0700 Simon Glass s...@chromium.org wrote: Hi, On 10 January 2015 at 03:50, Ian Campbell i...@hellion.org.uk wrote: On Fri, 2015-01-09 at 13:13 +0200, Siarhei Siamashka wrote: If yes then I think it is confusing to modify this comment, and the comment

Re: [U-Boot] [PATCH 1/3] samsung: board: support eMMC reset using DT

2015-01-11 Thread Jaehoon Chung
On 01/11/2015 02:46 AM, Simon Glass wrote: Hi, On 9 January 2015 at 23:53, Joonyoung Shim jy0922.s...@samsung.com wrote: On 01/09/2015 08:13 PM, Jaehoon Chung wrote: On 01/09/2015 04:31 PM, Joonyoung Shim wrote: +Cc Jaehoon, On 01/09/2015 03:18 AM, Simon Glass wrote: Hi Joonyoung, On

Re: [U-Boot] [PATCH v2] usb: Add an interval parameter to create_int_queue

2015-01-11 Thread Marek Vasut
On Sunday, January 11, 2015 at 08:38:28 PM, Hans de Goede wrote: Currently create_int_queue is only implemented by the ehci code, and that does not honor interrupt intervals, but other drivers which might also want to implement create_int_queue may honor intervals, so add an interval param.

Re: [U-Boot] [PATCH 2/2] sunxi: Enable pre-console buffer

2015-01-11 Thread Siarhei Siamashka
On Sat, 10 Jan 2015 10:50:05 + Ian Campbell i...@hellion.org.uk wrote: On Fri, 2015-01-09 at 13:13 +0200, Siarhei Siamashka wrote: If yes then I think it is confusing to modify this comment, and the comment before the pre-console #defines should mention that the buffer is boottime

Re: [U-Boot] [PATCH v3 0/9] sf: Update flash params for supported read commands and sector size

2015-01-11 Thread Bin Meng
Hi Jagan, On Wed, Dec 17, 2014 at 4:39 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On 17 December 2014 at 13:32, Bin Meng bmeng...@gmail.com wrote: Hi Jagan, On Wed, Dec 17, 2014 at 3:59 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On 15 December 2014 at 19:21, Bin Meng

Re: [U-Boot] [PATCH v3 2/9] sf: Update Atmel flash params

2015-01-11 Thread Bin Meng
Hi Bo, On Fri, Jan 9, 2015 at 5:27 PM, Bo Shen voice.s...@atmel.com wrote: Hi Meng, On 12/10/2014 08:51 PM, Bin Meng wrote: Update flash sector size to 4KiB as long as flash supports sector erase (20h) command. Correct AT25DF321 JEDEC ID and bulk erase command to 50h instead of D8h. Also

Re: [U-Boot] [PATCH] cmd_sf: Fix problem with sf update and unaligned length

2015-01-11 Thread Wolfgang Denk
Dear Stefan, In message 1420810762-10712-1-git-send-email...@denx.de you wrote: The new code is even simpler and copies the source data into the temp buffer and now uses the temp buffer to write the complete sector. So only one SPI sector write is used now instead of 2 in the old version. ...

Re: [U-Boot] Regarding patch: http://patchwork.ozlabs.org/patch/373593/

2015-01-11 Thread Ramneek Mehresh
-Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Thursday, December 18, 2014 4:46 PM To: u-boot Cc: Mehresh Ramneek-B31383 Subject: Re: Regarding patch: http://patchwork.ozlabs.org/patch/373593/ On Thursday, December 18, 2014 at 09:32:56 AM, Ramneek Mehresh

Re: [U-Boot] [PATCH v3 0/9] sf: Update flash params for supported read commands and sector size

2015-01-11 Thread Jagan Teki
On 12 January 2015 at 09:12, Bin Meng bmeng...@gmail.com wrote: Hi Jagan, On Wed, Dec 17, 2014 at 4:39 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On 17 December 2014 at 13:32, Bin Meng bmeng...@gmail.com wrote: Hi Jagan, On Wed, Dec 17, 2014 at 3:59 PM, Jagan Teki

Re: [U-Boot] [PATCH] cmd_sf: Fix problem with sf update and unaligned length

2015-01-11 Thread Stefan Roese
Hi Wolfgang, On 12.01.2015 08:17, Wolfgang Denk wrote: The new code is even simpler and copies the source data into the temp buffer and now uses the temp buffer to write the complete sector. So only one SPI sector write is used now instead of 2 in the old version. ... if (len !=

Re: [U-Boot] [PATCH] cmd_sf: Fix problem with sf update and unaligned length

2015-01-11 Thread Gerlando Falauto
Hi Stefan, thanks for the patch. Please compare it with my v1 revision of the patch: http://patchwork.ozlabs.org/patch/150468/ Back then, Simon suggested to use two separate SPI flash operations to avoid the memcpy() operation. I guess noone would have guessed about QSPI devices at the time.

Re: [U-Boot] [PATCH] cmd_sf: Fix problem with sf update and unaligned length

2015-01-11 Thread Stefan Roese
Hi Gerlando, On 12.01.2015 08:51, Gerlando Falauto wrote: thanks for the patch. Please compare it with my v1 revision of the patch: http://patchwork.ozlabs.org/patch/150468/ Back then, Simon suggested to use two separate SPI flash operations to avoid the memcpy() operation. This again could