Re: [U-Boot] [RFC/PATCH 1/2] ni: zynq: Add support for NI Ettus Research Project Sulfur Rev2 SDR

2017-07-06 Thread Michal Simek
>>> +#ifdef CONFIG_DISPLAY_BOARDINFO >>> +int checkboard(void) >>> +{ >>> + puts("Board: NI Sulfur SDR Board\n"); >> >> We should probably patch this and read this from DT instead. > > The 'model' property? yes >>> diff --git a/include/configs/ni_sulfur_rev2.h >>>

Re: [U-Boot] [PATCH 1/3] dm: ahci: Add a generic PCI-based AHCI driver

2017-07-06 Thread Bin Meng
Hi Simon, On Wed, Jun 21, 2017 at 1:00 PM, Bin Meng wrote: > Hi Simon, > > On Wed, Jun 21, 2017 at 11:29 AM, Simon Glass wrote: >> Hi Bin, >> >> On 17 June 2017 at 07:35, Bin Meng wrote: >>> This adds support for PCI-based AHCI

Re: [U-Boot] [PATCH v3] watchdog: Introduce watchdog driver for Intel Tangier

2017-07-06 Thread Bin Meng
On Thu, Jul 6, 2017 at 1:33 AM, Andy Shevchenko wrote: > From: Felipe Balbi > > Add watchdog driver for Intel Tangier based platforms. > > Signed-off-by: Vincent Tinelli > Signed-off-by: Felipe Balbi

Re: [U-Boot] [PATCH v1 3/3] wdt: Unify option of timeout value

2017-07-06 Thread Simon Glass
On 5 July 2017 at 11:44, Andy Shevchenko wrote: > There is no need to duplicate same option with different name. > > Kill HW_WATCHDOG_TIMEOUT_MS in favor of WATCHDOG_TIMEOUT_MSECS. > > Signed-off-by: Andy Shevchenko > --- >

Re: [U-Boot] [PATCH 1/6] sunxi: A64: dts: replace EMAC .dtsi with symlink

2017-07-06 Thread Simon Glass
Hi Andre, On 2 July 2017 at 18:59, Andre Przywara wrote: > Currently we add the U-Boot specific Ethernet MAC DT nodes for the > Pine64 via a board-specific add-on .dtsi. > However these nodes and properties in there are actually pretty generic > for all A64 boards which

Re: [U-Boot] [PATCH v2 1/3] x86: Add dma-mapping.h to architectural code

2017-07-06 Thread Simon Glass
On 5 July 2017 at 14:56, Andy Shevchenko wrote: > Some cross-platform drivers rely on this header present. > Make it so for x86. > > It's just a copy'n'paste of arch/arm/include/asm/dma-mapping.h. > > Suggested-by: Bin Meng > Reviewed-by:

Re: [U-Boot] [PATCH v2] mkimage: fix display of image types list

2017-07-06 Thread Simon Glass
On 29 June 2017 at 11:37, Baruch Siach wrote: > Since commit 5b9d44df2307f (mkimage: Display a better list of available image > types) mkimage usage text suggest to "use -T to see a list of available image > types". Unfortunately, commit 02221f29deb8 (mkimage: Convert to use

Re: [U-Boot] [PATCH 00/12] tegra: nyan-big: Support chainloading and add documentation

2017-07-06 Thread Simon Glass
Hi Tom, On 27 June 2017 at 14:09, Thomas Hoff wrote: > Thanks a bunch Simon (and everyone else who contributed)! > > I followed the instructions and was able to get uboot to boot successfully. > :D > > Now I just got to figure out how to get the kernel to boot in HYP

Re: [U-Boot] [PATCH v3 3/3] x86: Add Intel Edison board files

2017-07-06 Thread Simon Glass
On 6 July 2017 at 05:41, Andy Shevchenko wrote: > Add Intel Edison board which is using U-Boot. > > The patch is based on work done by the following people (in alphabetical > order): > Aiden Park > Dukjoon Jeon

Re: [U-Boot] [PATCH] net: gmac_rockchip: Add support for pinctrl

2017-07-06 Thread Simon Glass
+Philipp Hi Romain, On 3 July 2017 at 01:13, Romain Perier wrote: > Currently, selecting state simple is done by the device driver model, > prior probing the driver. The problem is that it's done and called on > the pinctrl node with "gmac" as the "periph" struct

Re: [U-Boot] [PATCH] net: usb: r8152: fix "duplicate 'const' declaration specifier"

2017-07-06 Thread Simon Glass
On 25 June 2017 at 14:47, Philipp Tomsich wrote: > After upgrading to GCC 7.1, the duplicate const specifies in the > r8152 driver trigger the following build warnings with buildman > (observed on a 'buildman rockchip' test):: >

Re: [U-Boot] [PATCHv6 1/3] ARM64: dts: hi3798cv200-poplar: add device tree bindings

2017-07-06 Thread Simon Glass
On 26 June 2017 at 07:52, Jorge Ramirez-Ortiz wrote: > Pulled from Linux 4.12-rc3 > > Signed-off-by: Jorge Ramirez-Ortiz > --- > arch/arm/dts/hi3798cv200-poplar.dts | 162 + > arch/arm/dts/hi3798cv200.dtsi

Re: [U-Boot] [PATCH] Makefile: add dependencies to regenerate u-boot.cfg when lost

2017-07-06 Thread Simon Glass
On 5 July 2017 at 09:30, Philipp Tomsich wrote: > When running a 'make clean' or carelessly removing u-boot.cfg, all > future make invocations (until autoconf is regenerated) will print > an error for a missing u-boot.cfg due to missing rules and

Re: [U-Boot] [PATCH 4/6] sunxi: GPIO: introduce sunxi_gpio_setup_dt_pins()

2017-07-06 Thread Simon Glass
Hi Andre, On 2 July 2017 at 18:59, Andre Przywara wrote: > Instead of hard-coding GPIO pins used for a certain peripheral, we > should just use the pinctrl information from the DT. > The sun8i-emac driver has some simple implementation of that, so > let's just generalize

Re: [U-Boot] CONFIG_USB_EHCI_HCD breaks xHCI drivers even on DM

2017-07-06 Thread Simon Glass
Hi, On 4 July 2017 at 03:15, Masahiro Yamada wrote: > Hi Marek, > > > 2017-07-03 17:13 GMT+09:00 Marek Vasut : >> On 07/03/2017 08:12 AM, Masahiro Yamada wrote: >>> Hi Marek, Simon. >>> >>> >>> Basically, Driver Mode allows us to enable multiple

Re: [U-Boot] [PATCH v1 2/3] wdt: Timeout better to be in microseconds

2017-07-06 Thread Simon Glass
Hi Andy, On 5 July 2017 at 11:44, Andy Shevchenko wrote: > Timeout in some abstract ticks is not what we are applying to get > deterministic behaviour. A tick is always milliseconds in U-Boot, as I understand it. > > Convert name to show explicitly that we

Re: [U-Boot] [PATCH v1 1/3] wdt: Fix spelling Resettting -> Resetting

2017-07-06 Thread Simon Glass
On 5 July 2017 at 11:44, Andy Shevchenko wrote: > Fix spelling Resettting -> Resetting. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > drivers/watchdog/wdt-uclass.c | 2 +- > 1 file changed, 1

Re: [U-Boot] [U-Boot,03/13] rockchip: rk3066: add sysreset driver

2017-07-06 Thread Simon Glass
On 4 July 2017 at 11:41, Philipp Tomsich wrote: > > Looks like we're ending up with a lot of sysreset_rk3***.o drivers here that > all have more or less the same logic in them. This one looks like a > verbatim copy of the RK3188 one... > > Can we start

Re: [U-Boot] [PATCH 2/5] libfdt_env.h: Add in libfdt environment

2017-07-06 Thread Simon Glass
On 30 June 2017 at 10:22, Pantelis Antoniou wrote: > Overlays require malloc so add it in the libfdt environment. > > Signed-off-by: Pantelis Antoniou > --- > include/libfdt_env.h | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [U-Boot] [PATCH 6/6] net: sun8i-emac: add support for new DT binding

2017-07-06 Thread Simon Glass
Hi Andre, On 2 July 2017 at 18:59, Andre Przywara wrote: > The Ethernet MAC used in newer Allwinner SoCs (H3, A64, H5) is about to > get an upstream Linux driver very soon (it's already lurking in -next). > This one uses a slightly different binding from the original one

Re: [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe

2017-07-06 Thread Simon Glass
On 22 June 2017 at 01:51, Masahiro Yamada wrote: > These are only used in drivers/mis/i2c_eeprom.c > > Signed-off-by: Masahiro Yamada > --- > > drivers/misc/i2c_eeprom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [U-Boot] [PATCH 3/5] fdt: Allow stacked overlays phandle references

2017-07-06 Thread Simon Glass
On 30 June 2017 at 10:23, Pantelis Antoniou wrote: > This patch enables an overlay to refer to a previous overlay's > labels by performing a merge of symbol information at application > time. > > In a nutshell it allows an overlay to refer to a symbol that a

Re: [U-Boot] [PATCH 07/16] usb: hub: Translate USB 3.0 hub port status into old version

2017-07-06 Thread Simon Glass
On 5 July 2017 at 23:56, Bin Meng wrote: > > Hi Marek, > > On Thu, Jun 29, 2017 at 1:25 AM, Marek Vasut wrote: > > On 06/28/2017 10:28 AM, Bin Meng wrote: > >> Hi Marek, > >> > >> On Tue, Jun 27, 2017 at 7:57 AM, Bin Meng wrote: > >>> Hi

Re: [U-Boot] [PATCH v4 01/18] cmd: nand: abstract global variable usage for dm conversion

2017-07-06 Thread Simon Glass
Hi, On 26 June 2017 at 18:12, Grygorii Strashko wrote: > From: Mugunthan V N > > nand_info is used all over the file so abstract it with > get_nand_dev_by_index() which will help for DM conversion. > > Signed-off-by: Mugunthan V N

Re: [U-Boot] [PATCH 1/5] libfdt.h: Introduce FDT_PATH_MAX

2017-07-06 Thread Simon Glass
Hi, On 1 July 2017 at 08:01, Marek Vasut wrote: > On 06/30/2017 06:22 PM, Pantelis Antoniou wrote: >> Introduce FDT_PATH_MAX > > Because ... why ? The commit message is crap, please fix. A better way of saying this is, please add a motivation to the commit message :-) Apart from

Re: [U-Boot] [PATCHv6 2/3] driver: mmc: update debug info

2017-07-06 Thread Simon Glass
On 26 June 2017 at 07:52, Jorge Ramirez-Ortiz wrote: > This driver is used in another board; remove board information from > the driver debug log. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > drivers/mmc/hi6220_dw_mmc.c | 2 +- >

Re: [U-Boot] [PATCH 4/5] test: overlay: Add unit test for stacked overlay

2017-07-06 Thread Simon Glass
Hi, On 30 June 2017 at 10:23, Pantelis Antoniou wrote: > Verify that stacked overlays work. > > Signed-off-by: Pantelis Antoniou > --- > test/overlay/Makefile | 1 + > test/overlay/cmd_ut_overlay.c

Re: [U-Boot] [PATCH 3/6] libfdt: add fdtdec_lookup_phandle_index()

2017-07-06 Thread Simon Glass
Hi Andre, On 2 July 2017 at 18:59, Andre Przywara wrote: > In some bindings a property points to multiple nodes, using a list of > phandles. A prominent example are UART pinctrl nodes, which use one node > to contain the RX/TX pins and another node to describe the lines

Re: [U-Boot] [PATCH 2/3] pinctrl: meson: add GPIO support

2017-07-06 Thread Simon Glass
On 25 June 2017 at 09:55, Beniamino Galvani wrote: > This commit adds GPIO support to the Amlogic Meson pin controller > driver, based on code from Linux kernel. > > Signed-off-by: Beniamino Galvani > --- > drivers/pinctrl/meson/pinctrl-meson-gxbb.c |

Re: [U-Boot] [PATCH v10 06/10] usb: host: ehci-generic: add error path and .remove callback

2017-07-06 Thread Simon Glass
On 6 July 2017 at 01:42, wrote: > From: Patrice Chotard > > Use an array to save enabled clocks reference and deasserted resets > in order to respectively disabled and asserted them in case of error > during probe() or during driver removal. > >

Re: [U-Boot] [PATCH 1/3] arm: dts: meson: import dts files from Linux 4.12-rc6

2017-07-06 Thread Simon Glass
On 25 June 2017 at 09:55, Beniamino Galvani wrote: > Import Amlogic Meson DTS files from Linux kernel version 4.12-rc6. > > Signed-off-by: Beniamino Galvani > --- > arch/arm/dts/meson-gx.dtsi| 97 -- >

Re: [U-Boot] [PATCH 4/5] dm: ofnode: rename dev_read_prop() to dev_get_property()

2017-07-06 Thread Simon Glass
Hi Masahiro, On 5 July 2017 at 22:49, Simon Glass wrote: > On 22 June 2017 at 01:54, Masahiro Yamada > wrote: >> The previous commit renamed ofnode_read_prop() to ofnode_get_propery() >> and fixed its return type. Likewise, rename

Re: [U-Boot] [PATCH 10/16] usb: xhci: Program 'route string' in the input slot context

2017-07-06 Thread Simon Glass
Hi Marek, On 27 June 2017 at 03:31, Marek Vasut wrote: > On 06/27/2017 07:23 AM, Stefan Roese wrote: >> Hi Bin, >> >> On 27.06.2017 02:01, Bin Meng wrote: >>> On Tue, Jun 27, 2017 at 2:07 AM, Marek Vasut wrote: On 06/24/2017 03:57 AM, Bin Meng wrote: > Hi

Re: [U-Boot] [PATCH v3 25/35] dm: tegra: pci: Convert to livetree

2017-07-06 Thread Simon Glass
Hi Stephen, On 6 July 2017 at 12:55, Stephen Warren wrote: > > On 07/06/2017 11:36 AM, s...@google.com wrote: >> >> Update the tegra pci driver to support a live device tree. Fix the check >> for nvidia,num-lanes so that an error will actually be detected. > > > Simon, > >

Re: [U-Boot] [PATCH] dtc: mkimage: Add the possibility to specify DTC

2017-07-06 Thread Simon Glass
On 25 June 2017 at 01:43, Emmanuel Vadot wrote: > FreeBSD recently switch to it's BSDL dtc. While it support most of the > features of the GPL one it still lacks the incbin directive. > Add the possibility to specify which dtc we want to use for compiling dts > and

Re: [U-Boot] [PATCH] EFI: find EFI system partition by legacy MBR partition type

2017-07-06 Thread Simon Glass
Hi Andre, On 6 July 2017 at 07:07, Andre Przywara wrote: > Hi, > > On 06/07/17 11:19, Thomas Schmitt wrote: >> Hi, >> >> i am the upstream developer of program xorriso which packs up Debian arm64 >> ISOs. >> >> Here is my minority opinion from a discussion with Andre

Re: [U-Boot] [PATCH v10 09/10] usb: host: ohci-generic: add RESET support

2017-07-06 Thread Simon Glass
On 6 July 2017 at 01:42, wrote: > From: Patrice Chotard > > use array to save deasserted resets reference in order to > assert them in case of error during probe() or during driver > removal. > > Signed-off-by: Patrice Chotard

Re: [U-Boot] [PATCH v10 04/10] dm: core: add ofnode_count_phandle_with_args()

2017-07-06 Thread Simon Glass
On 6 July 2017 at 01:42, wrote: > From: Patrice Chotard > > This function is usefull to get phandle number contained > in a property list. > For example, this allows to allocate the right amount > of memory to keep clock's reference contained

Re: [U-Boot] [PATCH v10 08/10] usb: host: ohci-generic: add CLOCK support

2017-07-06 Thread Simon Glass
On 6 July 2017 at 01:42, wrote: > From: Patrice Chotard > > use array to save enabled clocks reference in order to > disabled them in case of error during probe() or during > driver removal. > > Signed-off-by: Patrice Chotard

Re: [U-Boot] [PATCH] dm: include from drivers/core/util.c

2017-07-06 Thread Simon Glass
Hi Masahiro, On 6 July 2017 at 19:26, Masahiro Yamada wrote: > Hi Simon, > > > > 2017-07-06 13:49 GMT+09:00 Simon Glass : >> Hi Masahiro, >> >> On 22 June 2017 at 01:50, Masahiro Yamada >> wrote: >>> Fix sparse

Re: [U-Boot] [PATCH] dm: include from drivers/core/util.c

2017-07-06 Thread Masahiro Yamada
Hi Simon, 2017-07-06 13:49 GMT+09:00 Simon Glass : > Hi Masahiro, > > On 22 June 2017 at 01:50, Masahiro Yamada > wrote: >> Fix sparse warnings "... was not declared. Should it be static?" >> >> Also, fix redefinition of dm_warn/dm_dbg. >> >>

Re: [U-Boot] [U-Boot,3/3] odroid-c2: enable GPIO

2017-07-06 Thread Tom Rini
On Sun, Jun 25, 2017 at 05:55:11PM +0200, Beniamino Galvani wrote: > GPIOs are now supported on Meson GXBB, enable driver and command in > the config. > > Signed-off-by: Beniamino Galvani > --- > configs/odroid-c2_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [U-Boot] [RFC] efi_loader: memory leak in bootefi

2017-07-06 Thread Alexander Graf
On 06.07.17 20:23, Heinrich Schuchardt wrote: On 07/06/2017 05:52 PM, Alexander Graf wrote: Hi Heinrich, On 07/06/2017 05:43 PM, Heinrich Schuchardt wrote: Hello Alex, in bootefi.c do_bootefi_exec we build the efi_obj_list. This includes allocation of memory for some handlers (e.g. in

Re: [U-Boot] [PATCH v3 25/35] dm: tegra: pci: Convert to livetree

2017-07-06 Thread Stephen Warren
On 07/06/2017 11:36 AM, s...@google.com wrote: Update the tegra pci driver to support a live device tree. Fix the check for nvidia,num-lanes so that an error will actually be detected. Simon, Something in the latest u-boot-dm/master branch breaks PCI or Ethernet on Jeton TK1 and TX1. I don't

Re: [U-Boot] [RFC] efi_loader: memory leak in bootefi

2017-07-06 Thread Heinrich Schuchardt
On 07/06/2017 05:52 PM, Alexander Graf wrote: > Hi Heinrich, > > On 07/06/2017 05:43 PM, Heinrich Schuchardt wrote: >> Hello Alex, >> >> in bootefi.c do_bootefi_exec we build the efi_obj_list. This includes >> allocation of memory for some handlers (e.g. in efi_gop_register). >> >> After

Re: [U-Boot] [PATCH v3 24/35] dm: tegra: mmc: Convert to livetree

2017-07-06 Thread sjg
Update the tegra mmc driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/mmc/tegra_mmc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 07/35] dm: Fix error handling when unflattening the DT

2017-07-06 Thread sjg
The error handling code does not current detect an error right away. Adjust it to return immediately. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None lib/of_live.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Applied to u-boot-dm,

Re: [U-Boot] [PATCH v3 08/35] tegra: nyan-big: Enable bootstage

2017-07-06 Thread sjg
Enable full bootstage support so we can time SPL and U-Boot. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Add new patch to enable bootstage for nyan-big configs/nyan-big_defconfig | 5 + 1 file changed, 5 insertions(+) Applied to u-boot-dm,

Re: [U-Boot] [PATCH v3 17/35] dm: video: tegra124: Convert to livetree

2017-07-06 Thread sjg
Update these drives to support a live device tree. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v3: None Changes in v2: None drivers/video/tegra124/display.c | 8 +++- drivers/video/tegra124/dp.c | 3 +--

Re: [U-Boot] [PATCH v3 05/35] tegra: video: Time the LCD init

2017-07-06 Thread sjg
Calculate the time taken to set up the LCD. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/video/tegra124/display.c | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks! ___ U-Boot

Re: [U-Boot] [PATCH v3 13/35] tegra: spl: Enable debug UART

2017-07-06 Thread sjg
Enable the debug UART in SPL to allow early serial output even if the standard UART does not work (e.g. due to driver model problem). Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/mach-tegra/spl.c | 4 1 file changed, 4 insertions(+)

Re: [U-Boot] [PATCH v3 02/35] dm: core: Add dev_read_resource() to read device resources

2017-07-06 Thread sjg
Add a function which reads resources from a device, such as the device hardware address. This uses the "reg" property in the device. Unlike other functions there is little sense in inlining this when livetree is not being used because it has some logic in it and this would just bloat the code

Re: [U-Boot] [PATCH v3 30/35] dm: serial: Separate out the core serial-device finding code

2017-07-06 Thread sjg
This function is quite long. Move the core code into a separate function in preparation for adding livetree support. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/serial/serial-uclass.c | 84 ++ 1 file

Re: [U-Boot] [PATCH v3 06/35] tegra: nyan-big: Enable the debug UART

2017-07-06 Thread sjg
Enable this to allow debugging when the serial UART driver is misconfigured. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None configs/nyan-big_defconfig | 4 1 file changed, 4 insertions(+) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 21/35] dm: tegra: spi: Convert to livetree

2017-07-06 Thread sjg
Update the tegra114 spi driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/spi/tegra114_spi.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 09/35] dm: video: Sync display on backspace

2017-07-06 Thread sjg
We should sync the display (e.g. flush cache) when backspace is pressed to ensure that the character is erased correctly. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v3: None Changes in v2: None drivers/video/vidconsole-uclass.c |

Re: [U-Boot] [PATCH v3 11/35] video: simple-panel: Add a little more debugging

2017-07-06 Thread sjg
Add some debugging to show when the backlight is enabled. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v3: None Changes in v2: None drivers/video/simple_panel.c | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 15/35] dm: tegra: Convert USB setup to livetree

2017-07-06 Thread sjg
Adjust this code to support a live device tree. This should be implemented as a PHY driver but that is left as an exercise for the maintainer. Signed-off-by: Simon Glass --- Changes in v3: - Fix up the implementation which had node instead of subnode in one place Changes in

Re: [U-Boot] [PATCH v3 23/35] dm: tegra: pwm: Convert to livetree

2017-07-06 Thread sjg
Update the tegra pwm driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/pwm/tegra_pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH] dm: include from drivers/core/util.c

2017-07-06 Thread sjg
Hi Masahiro, On 22 June 2017 at 01:50, Masahiro Yamada wrote: > Fix sparse warnings "... was not declared. Should it be static?" > > Also, fix redefinition of dm_warn/dm_dbg. > > Signed-off-by: Masahiro Yamada > --- > >

Re: [U-Boot] [PATCH v3 04/35] dm: core: Add functions to obtain node's address/size cells

2017-07-06 Thread sjg
The of_n_addr_cells() and of_n_size_cells() functions are useful for getting the size of addresses in a node, but in a few places U-Boot needs to obtain the actual property value for a node without walking up the stack. Add functions for this and just the existing code to use it. Add a comment

Re: [U-Boot] [PATCH v3 03/35] dm: core: Add dev_read_enabled() to check if a device is enabled

2017-07-06 Thread sjg
This function allows a device's status to be read. This indicates whether the device should be enabled or disabled. Note: In normal operation disabled devices will not be present in the driver-model tree. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to add

Re: [U-Boot] [PATCH v3 33/35] fdtdec: Drop old compatible values

2017-07-06 Thread sjg
These are not needed now since the drivers now use driver model. Drop them. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None include/fdtdec.h | 6 -- lib/fdtdec.c | 6 -- 2 files changed, 12 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 14/35] tegra: tegra124: Add a PMC syscon driver

2017-07-06 Thread sjg
The PMC can be modelled as a syscon peripheral. Add a driver for this so that it can be accessed by drivers when needed. Enable it for tegra124 boards. Signed-off-by: Simon Glass --- Changes in v3: - Update commit message, enable for all tegra124 boards not just nyan-big

Re: [U-Boot] [PATCH] dm: ofnode: use fdt32_t for DT property value to fix sparse warning

2017-07-06 Thread sjg
On 22 June 2017 at 02:57, Masahiro Yamada wrote: > DTB is encoded in big endian. When we retrieve property values, > we need to use fdt32_to_cpu (aka be32_to_cpu) for endian conversion. > This is a bit error-prone, but sparse is useful to detect endian > mismatch.

Re: [U-Boot] [PATCH v3 10/35] dm: video: Update pwm_backlight to support livetree

2017-07-06 Thread sjg
Update this driver to support a live device tree. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v3: None Changes in v2: None drivers/video/pwm_backlight.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-)

Re: [U-Boot] [PATCH v3 22/35] dm: tegra: i2c: Convert to livetree

2017-07-06 Thread sjg
Update the tegra i2c driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/i2c/tegra_i2c.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 12/35] tegra: Fix up include file ordering

2017-07-06 Thread sjg
Update these two files so include files in the right order. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/mach-tegra/board2.c | 22 -- arch/arm/mach-tegra/clock.c | 4 ++-- 2 files changed, 10 insertions(+), 16

Re: [U-Boot] [PATCH v3 20/35] dm: tegra: usb: Convert to livetree

2017-07-06 Thread sjg
Update the Tegra EHCI driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/usb/host/ehci-tegra.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) Applied to u-boot-dm,

Re: [U-Boot] [PATCH v3 19/35] dm: tegra: gpio: Convert to support livetree

2017-07-06 Thread sjg
Update the GPIO driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/gpio/tegra_gpio.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 29/35] dm: serial: ns16550: Convert to livetree

2017-07-06 Thread sjg
Update this driver to support a live device tree. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/serial/ns16550.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 16/35] dm: tegra: Convert clock_decode_periph_id() to support livetree

2017-07-06 Thread sjg
Adjust this to take a device as a parameter instead of a node. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/include/asm/arch-tegra/clock.h | 2 +- arch/arm/mach-tegra/clock.c | 5 ++--- drivers/spi/tegra114_spi.c |

Re: [U-Boot] [PATCH] fdt: Check for NULL return from fdt_getprop in 'fdt set'

2017-07-06 Thread sjg
On 13 June 2017 at 05:10, Tom Rini wrote: > While the previous pass through fixed one place where we knew that > fdt_getprop would be given a positive len, in the case of 'fdt set' we > do not, so check that we did no get NULL from fdt_getprop(). > > Cc: Simon Glass

Re: [U-Boot] [PATCH v3 25/35] dm: tegra: pci: Convert to livetree

2017-07-06 Thread sjg
Update the tegra pci driver to support a live device tree. Fix the check for nvidia,num-lanes so that an error will actually be detected. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to convert tegra PCI to device tree Changes in v2: None

Re: [U-Boot] [PATCH 1/5] dm: ofnode: use ofnode_read_bool() to check property existence

2017-07-06 Thread sjg
On 22 June 2017 at 01:54, Masahiro Yamada wrote: > This will clarify the code. > > Signed-off-by: Masahiro Yamada > --- > > drivers/core/ofnode.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Acked-by: Simon

Re: [U-Boot] [PATCH v3 31/35] dm: serial: Add livetree support

2017-07-06 Thread sjg
Add support for a live device tree to the core serial uclass. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/serial/serial-uclass.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v3 18/35] tegra: dts: Move stdout-path to /chosen

2017-07-06 Thread sjg
This property should be in the /chosen node, not /aliases. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/dts/tegra124-nyan-big.dts | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH 2/5] dm: ofnode: simplify ofnode_read_prop()

2017-07-06 Thread sjg
On 22 June 2017 at 01:54, Masahiro Yamada wrote: > The code inside the if-block is the same as of_get_property(). > > Signed-off-by: Masahiro Yamada > --- > > drivers/core/ofnode.c | 12 +++- > 1 file changed, 3

Re: [U-Boot] [PATCH v3 32/35] tegra: Show a debug message if the LCD PMIC fails to start

2017-07-06 Thread sjg
This error condition should have a debug() message. Add it. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/arm/mach-tegra/board2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH 3/5] dm: ofnode: rename ofnode_read_prop() to ofnode_get_property()

2017-07-06 Thread sjg
On 22 June 2017 at 01:54, Masahiro Yamada wrote: > This function returns the pointer to the value of a node property. > The current name ofnode_read_prop() is confusing. Follow the naming > of_get_property() from Linux. > > The return type (const u32 *) is wrong.

Re: [U-Boot] [PATCH 5/5] dm: ofnode: simplify ofnode_read_bool()

2017-07-06 Thread sjg
On 22 June 2017 at 01:54, Masahiro Yamada wrote: > Reuse ofnode_get_property() to simplify the implementation. > > Signed-off-by: Masahiro Yamada > --- > > drivers/core/ofnode.c | 14 +- > 1 file changed, 5 insertions(+),

Re: [U-Boot] [PATCH] dm: include from driver/core/dump.c

2017-07-06 Thread sjg
On 22 June 2017 at 02:10, Masahiro Yamada wrote: > Include to fix sparse warnings: > symbol 'dm_dump_all' was not declared. Should it be static? > symbol 'dm_dump_uclass' was not declared. Should it be static? > > Signed-off-by: Masahiro Yamada

Re: [U-Boot] [PATCH v3 00/35] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-07-06 Thread Simon Glass
Hi, On 14 June 2017 at 10:57, Simon Glass wrote: > Hi Stephen, > > On 14 June 2017 at 10:48, Stephen Warren wrote: >> On 06/14/2017 10:32 AM, Stephen Warren wrote: >>> >>> On 06/14/2017 05:30 AM, Simon Glass wrote: >>> ... At this point I'm

Re: [U-Boot] [PATCH v3] powerpc, 8xx: Add support for MCR3000 board from CSSI

2017-07-06 Thread Heiko Schocher
Hello Christophe, Am 06.07.2017 um 16:45 schrieb Christophe Leroy: CS Systemes d'Information (CSSI) manufactures two boards, named MCR3000 and CMPC885 which are respectively based on MPC866 and MPC885 processors. This patch adds support for the first board. Signed-off-by: Christophe Leroy

Re: [U-Boot] [PATCH] EFI: find EFI system partition by legacy MBR partition type

2017-07-06 Thread Andre Przywara
Hi, On 06/07/17 15:31, Alexander Graf wrote: > On 07/06/2017 04:16 PM, Thomas Schmitt wrote: >> Hi, >> >> Andre Przywara wrote: >>> U-Boot does not really have an >>> understanding yet of whether it is acting as an EFI implementation >> If you use it to boot an ISO by its GRUB or SYSLINUX EFI

Re: [U-Boot] [PATCH v2b 04/10] powerpc, 8xx: Implement GLL2 ERRATA

2017-07-06 Thread Heiko Schocher
Hello Christophe, Am 06.07.2017 um 16:49 schrieb Christophe Leroy: Signed-off-by: Christophe Leroy --- Takes into account comments received from Wolfgang and Heiko. Superseeds the one included in v2 of the serie 'powerpc, 8xx: Modernise the 8xx'. Not resending

Re: [U-Boot] [RFC] efi_loader: memory leak in bootefi

2017-07-06 Thread Alexander Graf
Hi Heinrich, On 07/06/2017 05:43 PM, Heinrich Schuchardt wrote: Hello Alex, in bootefi.c do_bootefi_exec we build the efi_obj_list. This includes allocation of memory for some handlers (e.g. in efi_gop_register). After returning from the efi appliation we have no clean up code to release

[U-Boot] [RFC] efi_loader: memory leak in bootefi

2017-07-06 Thread Heinrich Schuchardt
Hello Alex, in bootefi.c do_bootefi_exec we build the efi_obj_list. This includes allocation of memory for some handlers (e.g. in efi_gop_register). After returning from the efi appliation we have no clean up code to release these objects. We do not remove the list elements from efi_obj_list.

Re: [U-Boot] [PATCH v3] powerpc, 8xx: Add support for MCR3000 board from CSSI

2017-07-06 Thread Wolfgang Denk
Dear Christophe, In message <20170706144516.9df0269...@pc13941vm.idsi0.si.c-s.fr> you wrote: > CS Systemes d'Information (CSSI) manufactures two boards, named MCR3000 > and CMPC885 which are respectively based on MPC866 and MPC885 processors. > > This patch adds support for the first board. > >

Re: [U-Boot] [PATCH v2 02/15] dm: mmc: Allow disabling driver model in SPL

2017-07-06 Thread Jean-Jacques Hiblot
Hi Simon, On 04/07/2017 21:31, Simon Glass wrote: At present if U-Boot proper uses driver model for MMC, then SPL has to also. While this is desirable, it places a significant barrier to moving to driver model in some cases. For example, with a space-constrained SPL it may be necessary to

Re: [U-Boot] [PATCH v2b 04/10] powerpc, 8xx: Implement GLL2 ERRATA

2017-07-06 Thread Wolfgang Denk
Dear Christophe, In message <20170706144956.31ff769...@pc13941vm.idsi0.si.c-s.fr> you wrote: > Signed-off-by: Christophe Leroy > --- > Takes into account comments received from Wolfgang and Heiko. > Superseeds the one included in v2 of the serie 'powerpc, 8xx: >

Re: [U-Boot] [PATCH 1/3] moveconfig: Allow piping in 'git show --stat' output

2017-07-06 Thread sjg
It is useful to be able to process only a subset of boards to save time. Often that subset is defined by the defconfig files in a git commit. This change allows things like: # Build the database ./tools.moveconfig.py -b # Find some implying configs ./tools/moveconfig.py -i CONFIG_X

Re: [U-Boot] [PATCH 03/11] dtoc: Split out the main class into its own file

2017-07-06 Thread sjg
To simplify running tests we should move this class into its own file. This allows the tests to import it without having to import dtoc.py, which runs the tests. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 411 +

Re: [U-Boot] [PATCH v3 4/6] console: Use map_sysmem() for the pre-relocation console

2017-07-06 Thread sjg
On Fri, Jun 16, 2017 at 11:37 AM, Simon Glass wrote: > At present this feature casts the address to a pointer. Use the > map_sysmem() function so that it will work correctly on sandbox. > > Signed-off-by: Simon Glass > --- > > Changes in v3: > - Add new

Re: [U-Boot] [PATCH 10/11] sandbox: Stop printing platdata at the start of SPL

2017-07-06 Thread sjg
Currently we have code which prints out platform data at the start of SPL. Now that we have tests for dtoc this is probably not necessary. Drop it. Update test_ofplatdata to check for empty output since it is useful to check that sandbox_spl works as expected. Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 01/11] dtoc: Use self._options instead of the global options

2017-07-06 Thread sjg
This class should use the options object passed to it rather than finding the global one. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/dtoc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH 09/11] dtoc: Add a comment about string replace in conv_name_to_c()

2017-07-06 Thread sjg
This function uses several separate string replaces where a regular expression might seem more reasonable. Add a comment justifying the way it is currently done. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 3 +++ 1 file changed, 3 insertions(+) Applied to

Re: [U-Boot] [PATCH 3/3] moveconfig: Allow automatic location and adding of 'imply'

2017-07-06 Thread sjg
By using a Kconfig parser we can find the location of each option in the Kconfig tree. Using the information from the database we can then automatically add an 'imply' option into the right place if requested by the user. Add a -a option to support adding 'imply' options. Display the location of

Re: [U-Boot] [PATCH 07/11] dtoc: Move static functions out of the class

2017-07-06 Thread sjg
Rather than using static functions within the class, move them out of the class. This will make it slightly easier for tests to call them. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 125 +++-- 1 file changed, 63

Re: [U-Boot] [PATCH 06/11] dtoc: Pass include_disabled explicitly

2017-07-06 Thread sjg
This option is the only one actually used by the dtb_platdata class. Pass it explicitly to avoid needing to pass the whole option object to the constructor. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 8 tools/dtoc/dtoc.py | 2 +- 2 files

  1   2   3   >