Re: [U-Boot] [PATCH 5/7] mach-snapdragon: Introduce pinctrl driver

On Tue, May 15, 2018 at 7:15 PM, Simon Glass wrote: > Hi Ramon, > > On 16 May 2018 at 02:09, Ramon Fried wrote: >> >> >> On Tue, May 15, 2018, 7:03 PM Simon Glass wrote: >>> >>> Hi Ramon, >>> >>> On 15 May 2018 at 07:23, Ramon Fried

Re: [U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4

Hi Eugeniu, > 2018-05-13 2:13 GMT+09:00 Eugeniu Rosca : > > Align Kconfig to Linux 4.17-rc4 with minimal impact on non-kconfig files. > > Previous Kconfig sync was done by commit bf7ab1e70fd762 ("kconfig: > > re-sync with Linux 4.10") and it achieved almost perfect

Re: [U-Boot] [PATCH v4 13/14] mmc: Separate "mmc swrite" from fastboot

On Wed, May 16, 2018 at 12:20 AM Joe Hershberger wrote: > On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > > Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc > > swrite" command is separated from the fastboot code. > > > >

Re: [U-Boot] [PATCH 2/2] ARM: dts: exynos5: add the interrupt-parent property

Hi, 2018년 1월 15일 (월) 20:50, Anand Moon 님이 작성: > Hi Jaehoo, > > On 12 January 2018 at 16:37, Jaehoon Chung wrote: > > Add the interrupt-parent property as gic. > > > > Signed-off-by: Jaehoon Chung > > --- > Please add my > >

Re: [U-Boot] [PATCH 1/2] ARM: dts: exynos5: remove the duplicated nodes

2018년 5월 9일 (수) 12:53, Anand Moon 님이 작성: > Hi Jaehoon, > > On 12 January 2018 at 16:37, Jaehoon Chung wrote: > > Remove the duplicated gic and combiner nodes in exynos5.dtsi. > > > > Signed-off-by: Jaehoon Chung > > --- > >

Re: [U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4

2018-05-13 2:13 GMT+09:00 Eugeniu Rosca : > Align Kconfig to Linux 4.17-rc4 with minimal impact on non-kconfig files. > > Previous Kconfig sync was done by commit bf7ab1e70fd762 ("kconfig: > re-sync with Linux 4.10") and it achieved almost perfect alignment with > a few

[U-Boot] [PATCH 11/12] binman: Add support for adding a name prefix to entries

Sometimes we have several sections which repeat the same entries (e.g. for a read-only and read-write version of the same section). It is useful to be able to tell these entries apart by name. Add a new 'name-prefix' property for sections, which causes all entries within that section to have a

[U-Boot] [PATCH 07/12] binman: Add documentation for pos-unset property

This property is not documented. Add a note to the README. Signed-off-by: Simon Glass --- tools/binman/README | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/binman/README b/tools/binman/README index 5ef1246f296..32d89194dd0 100644 --- a/tools/binman/README

[U-Boot] [PATCH 09/12] binman: Tidy up some docs and comments

Fix a few missing comments and tidy up some existing ones. Signed-off-by: Simon Glass --- tools/binman/README | 6 +++--- tools/binman/ftest.py | 29 +++-- tools/binman/image.py | 5 + 3 files changed, 27 insertions(+), 13 deletions(-) diff

[U-Boot] [PATCH 12/12] binman: Mark 'align-end' as implemented

The documentation says this is not implemented, but it is. Update the documentation, and clarify its operation. Signed-off-by: Simon Glass --- tools/binman/README | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/binman/README

Re: [U-Boot] [PATCH v2 3/6] scripts/dtc: Update to upstream version v1.4.5-6-gc1e55a5513e9

2018-05-13 2:13 GMT+09:00 Eugeniu Rosca : > From: Rob Herring > > Pickup the fix for handling unresolved phandles in overlays. > > This adds the following commits from upstream: > > c1e55a5513e9 checks: fix handling of unresolved phandles for dts plugins >

[U-Boot] [PATCH 10/12] binman: Add support for outputing a map file

It is useful to be able to see a list of regions in each image produced by binman. Add a -m option to output this information in a '.map' file alongside the image file. Signed-off-by: Simon Glass --- tools/binman/README | 20 +++-

[U-Boot] [PATCH 08/12] binman: Allow a single test to be executed

Provide an easy way to execute a single binman test by specifying it on the command line. Signed-off-by: Simon Glass --- tools/binman/binman.py | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tools/binman/binman.py

[U-Boot] [PATCH 02/12] binman: Refactor much of the image code into 'section'

We want to support multiple sections within a single image. To do this, move most of the Image class implementation into a new Section class. An Image contains only a single Section, but at some point we will support a new 'section' entry, thus allowing Sections within Sections. Use the name

[U-Boot] [PATCH 06/12] binman: Add support for sections

It is useful to be able to split an image into multiple sections, each with its own size and position, for cases where a flash device has read-only and read-write portions. Add support for this. Signed-off-by: Simon Glass --- tools/binman/README | 41

[U-Boot] [PATCH 05/12] binman: Avoid setting sys.path globally

At present we set the Python path at the start of binman so we can read modules in the 'etype' directory. This is a bit messy since it affects 'import' statements through binman. Adjust the code to set the path locally, just where it is needed. Move the 'entry' module in with the other base

[U-Boot] [PATCH 04/12] binman: Rename Entry property to 'section'

Entries are now passed a Section object rather than an Image. Rename this property to avoid confusion. Signed-off-by: Simon Glass --- tools/binman/etype/_testing.py| 4 ++-- tools/binman/etype/blob.py| 4 ++-- tools/binman/etype/entry.py

[U-Boot] [PATCH 01/12] binman: Allow unit addresses for binaries

Allow the same binary to appear multiple times in an image by using the device-tree unit-address feature (u-boot@0, u-boot@1). Signed-off-by: Simon Glass --- tools/binman/README | 4 tools/binman/etype/entry.py | 5 +

[U-Boot] [PATCH 03/12] binman: Rename ELF parameters to 'section'

We now pass a Section object to these functions rather than an Image. Rename the parameters to avoid confusion. Signed-off-by: Simon Glass --- tools/binman/elf.py | 10 +- tools/binman/elf_test.py | 28 ++--

[U-Boot] [PATCH 00/12] binman: A few more features

This series ads a few more features to binman, principally the ability to nest entries within other entries, to form hierarchical images. Also included are support for a map file and some docs tidy-ups. Simon Glass (12): binman: Allow unit addresses for binaries binman: Refactor much of the

Re: [U-Boot] [PATCH v2 4/6] scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987

2018-05-13 2:13 GMT+09:00 Eugeniu Rosca : > From: Rob Herring > > This adds the following commits from upstream: > > aadd0b65c987 checks: centralize printing of property names in failure messages > 88960e398907 checks: centralize printing of node path in

Re: [U-Boot] [PATCH v2 5/6] scripts/dtc: Re-sync with Linux 4.17-rc4

2018-05-15 23:06 GMT+09:00 Eugeniu Rosca : > Dear Masahiro, Simon, > > I think this patch logically belongs and is tightly coupled to the Linux > 4.17-rc4 Kconfig re-sync. Since you skipped it, I wonder if you have a > different view on this. > > Most of the Linux commits

Re: [U-Boot] [PATCH v4 13/14] mmc: Separate "mmc swrite" from fastboot

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc > swrite" command is separated from the fastboot code. > > Move image-sparse from common to lib so it's clear it's library code. > > Signed-off-by:

Re: [U-Boot] [PATCH v4 12/14] fs: Add fs_get_type_name to return current filesystem name

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Add fs_get_type_name so we can get the current filesystem type. > > Signed-off-by: Alex Kiernan > Reviewed-by: Simon Glass Reviewed-by: Joe Hershberger

Re: [U-Boot] [PATCH v4 10/14] fastboot: Extract common definitions from USB fastboot

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code > we only have one definition. > > Signed-off-by: Alex Kiernan Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH v4 09/14] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Rename fb_set_reboot_flag to fastboot_set_reboot_flag so it matches > all other fastboot code in the global name space. Fix the guards around > them so that they're dependent on FASTBOOT, not just

Re: [U-Boot] [PATCH v4 08/14] fastboot: Fix parameter types in _fb_nand_write

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Compiling on a 64 bit target the arguments to _fb_nand_write are > incompatible: > > drivers/fastboot/fb_nand.c: In function ‘_fb_nand_write’: > drivers/fastboot/fb_nand.c:101:42: warning: passing argument 3 of >

Re: [U-Boot] [PATCH v4 07/14] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined > by Kconfig if you're compiling this code, so remove these redundant > defaults. > > Signed-off-by: Alex Kiernan >

Re: [U-Boot] [PATCH v4 02/14] fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Anyone who wants FASTBOOT before this series wants USB_FUNCTION_FASTBOOT. > Split USB_FUNCTION_FASTBOOT from FASTBOOT so they retain their existing > behaviour. > > Signed-off-by: Alex Kiernan

Re: [U-Boot] [PATCH v4 01/14] fastboot: Move fastboot to drivers/fastboot

On Tue, May 15, 2018 at 9:48 AM, Alex Kiernan wrote: > Separate CMD_FASTBOOT from FASTBOOT and move code and configuration to > drivers/fastboot. > > Signed-off-by: Alex Kiernan > Reviewed-by: Simon Glass Nit below, but

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: > Hi Marek, > > > On 04/05/2018 21:06, Marek Vasut wrote: >> >> Shouldnt the driver turn this on? > AFAIK there is no clock driver for the OMAP. So we have to do it > before > the driver is probed. Maybe it's time to

Re: [U-Boot] [PATCH v1 16/21] display5: net: Add function to read ethaddr from iMX6 fuses

Hi Lukasz, On Fri, May 11, 2018 at 9:51 AM, Lukasz Majewski wrote: > Signed-off-by: Lukasz Majewski > --- > > board/liebherr/display5/display5.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/board/liebherr/display5/display5.c >

Re: [U-Boot] [PATCH] net: include/phy.h: add new mode for internal phy

On Fri, May 11, 2018 at 4:51 AM, Kunihiko Hayashi wrote: > Add the new mode to indicate a built-in PHY. > This will be used by UniPhier AVE ethernet driver. > > Signed-off-by: Kunihiko Hayashi Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH v3 3/3] net: designware: Add reset ctrl to driver

On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan wrote: > Add code to reset all reset signals as in Ethernet DT node. A reset property > is an optional feature, > so only print out a warning and do not fail if a reset property is not > present. > > If a reset property is

Re: [U-Boot] [RESEND][PATCH] cmd: nvedit: add whitelist option for env import

Hi Alex, On 15 May 2018 at 12:43, Alex Kiernan wrote: > On Tue, May 15, 2018 at 7:25 PM Joe Hershberger > wrote: > >> On Tue, May 15, 2018 at 5:03 AM, Quentin Schulz >> wrote: >> > While the `env export` can take as

Re: [U-Boot] [RESEND][PATCH] cmd: nvedit: add whitelist option for env import

On Tue, May 15, 2018 at 7:25 PM Joe Hershberger wrote: > On Tue, May 15, 2018 at 5:03 AM, Quentin Schulz > wrote: > > While the `env export` can take as parameters variables to be exported, > > `env import` does not have such a mechanism of

Re: [U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

(Tom can you please comment on the CamelCase question?) Hi Igor, On 15 May 2018 at 11:31, Igor Opaniuk wrote: > On 15 May 2018 at 19:26, Simon Glass wrote: >> Hi Igor, >> >> On 16 May 2018 at 01:44, Igor Opaniuk wrote: >>>

Re: [U-Boot] [PATCH] PCI: Document pciauto_region_allocate()

On 15 May 2018 at 06:50, Tuomas Tynkkynen wrote: > Add a doc comment for pciauto_region_allocate(). > > Signed-off-by: Tuomas Tynkkynen > --- > This patch depends on [PATCH 2/2] PCI: autoconfig: Don't allocate 64-bit > addresses to 32-bit only

Re: [U-Boot] [RESEND][PATCH] cmd: nvedit: add whitelist option for env import

Hi Quentin, On 15 May 2018 at 20:03, Quentin Schulz wrote: > While the `env export` can take as parameters variables to be exported, > `env import` does not have such a mechanism of variable selection. > > Let's add a `-w` option that asks `env import` to look for the

Re: [U-Boot] [RESEND][PATCH] cmd: nvedit: add whitelist option for env import

On Tue, May 15, 2018 at 5:03 AM, Quentin Schulz wrote: > While the `env export` can take as parameters variables to be exported, > `env import` does not have such a mechanism of variable selection. > > Let's add a `-w` option that asks `env import` to look for the >

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

+Lokesh On 15/05/2018 18:10, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to implement it instead of piling up

[U-Boot] [PATCH v3 0/2] arm: print instructions pointed to by pc

If an exception occurs in a loaded image and the relocation offset is unknown, it is helful to know the instructions pointed to by the program counter. The first patch adds the missing output. The second patch provides the decodecode script from the Linux kernel which can be used to disassemble

[U-Boot] [PATCH v3 1/2] arm: print instructions pointed to by pc

If an exception occurs in a loaded image and the relocation offset is unknown, it is helful to know the instructions pointed to by the program counter. This patch adds the missing output. A possible output is: Code: e1c560d0 e12fff1e e120077b e12fff1e (e7f7defb) The parentheses indicate the

[U-Boot] [PATCH v3 2/2] scripts: add decodecode from Linux

The script decodecode can be used to disassemble the 'Code:' line written when an exception occurs. The script is copied from Linux v4.16. Signed-off-by: Heinrich Schuchardt --- v3: new patch --- scripts/decodecode | 125

Re: [U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

On 15 May 2018 at 19:26, Simon Glass wrote: > Hi Igor, > > On 16 May 2018 at 01:44, Igor Opaniuk wrote: >> Hi Simon, >> >> I've dug into DriverModel documentation and even created a PoC for >> existing avb commands. The problem is that (maybe I missed

Re: [U-Boot] [PATCH 0/8] Initial integration of AVB2.0

Hi Igor, On Tue, May 15, 2018 at 07:58:51PM +0300, Igor Opaniuk wrote: > Hi Eugeniu, > > You're totally right regarding avb internal headers, they all > should remain in lib/libavb. > v2 patchset (planning to send it by the end of this week) will > include these changes you're talking about (+

Re: [U-Boot] [PATCH v4 26/32] tpm: add the possibility to reset the chip with a gpio

On Tue, May 15, 2018 at 06:32:43PM +0200, Miquel Raynal wrote: > Simon, Tom, > > On Wed, 16 May 2018 02:05:01 +1000, Simon Glass > wrote: > > > On 15 May 2018 at 19:57, Miquel Raynal wrote: > > > On some designs, the reset line could not be

Re: [U-Boot] [PATCH 0/8] Initial integration of AVB2.0

Hi Eugeniu, You're totally right regarding avb internal headers, they all should remain in lib/libavb. v2 patchset (planning to send it by the end of this week) will include these changes you're talking about (+ will include libavb updates from [1]). > My final question is what's your opinion

Re: [U-Boot] [PATCH v4 26/32] tpm: add the possibility to reset the chip with a gpio

Simon, Tom, On Wed, 16 May 2018 02:05:01 +1000, Simon Glass wrote: > On 15 May 2018 at 19:57, Miquel Raynal wrote: > > On some designs, the reset line could not be connected to the SoC reset > > line, in this case, request the GPIO and ensure the

Re: [U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

Hi Igor, On 16 May 2018 at 01:44, Igor Opaniuk wrote: > Hi Simon, > > I've dug into DriverModel documentation and even created a PoC for > existing avb commands. The problem is that (maybe I missed out some > key concepts) I'm still > not sure if it makes sense to follow

Re: [U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules

On 16 May 2018 at 02:20, Miquel Raynal wrote: > Hi Simon, > > On Wed, 16 May 2018 02:04:58 +1000, Simon Glass > wrote: > >> Hi Miquel, >> >> On 15 May 2018 at 19:57, Miquel Raynal wrote: >> > Add the tpm2_tis_spi driver

Re: [U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules

Hi Simon, On Wed, 16 May 2018 02:04:58 +1000, Simon Glass wrote: > Hi Miquel, > > On 15 May 2018 at 19:57, Miquel Raynal wrote: > > Add the tpm2_tis_spi driver that should support any TPMv2 compliant > > (SPI) module. > > > > Signed-off-by: Miquel

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to implement it instead of piling up those hacks ? I was thinking along the same lines at some

Re: [U-Boot] [PATCH 5/7] mach-snapdragon: Introduce pinctrl driver

Hi Ramon, On 16 May 2018 at 02:09, Ramon Fried wrote: > > > On Tue, May 15, 2018, 7:03 PM Simon Glass wrote: >> >> Hi Ramon, >> >> On 15 May 2018 at 07:23, Ramon Fried wrote: >> > On Mon, May 14, 2018 at 10:51 PM, Simon Glass

Re: [U-Boot] [PATCH v2 4/6] scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987

Hi, On 15 May 2018 at 23:46, Eugeniu Rosca wrote: > Hi Simon, > > On Mon, May 14, 2018 at 01:52:09PM -0600, Simon Glass wrote: >> Hi, >> >> On 13 May 2018 at 16:45, Eugeniu Rosca wrote: >> > Hi Simon, >> > >> > On Mon, May 14, 2018 at 08:00:40AM

Re: [U-Boot] [PATCH v3 05/11] pmic: dm: Add support for MC34708 for PMIC DM

On 15 May 2018 at 08:26, Lukasz Majewski wrote: > This patch adds support for MC34708 PMIC, to be used with driver model > (DM). > > Signed-off-by: Lukasz Majewski > > --- > > Changes in v3: > - Rename dm_pmic_info with uc_pmic_priv > - Sort alphabetically includes

Re: [U-Boot] [PATCH v4 03/32] tpm: substitute deprecated uint_t types with their u equivalent

On 15 May 2018 at 19:56, Miquel Raynal wrote: > Fix following checkpatch.pl issues in TPM-related code: > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > CHECK: Prefer kernel type 'u16' over 'uint16_t' > CHECK: Prefer kernel type 'u32' over 'uint32_t' > >

Re: [U-Boot] [PATCH 5/7] mach-snapdragon: Introduce pinctrl driver

On Tue, May 15, 2018, 7:03 PM Simon Glass wrote: > Hi Ramon, > > On 15 May 2018 at 07:23, Ramon Fried wrote: > > On Mon, May 14, 2018 at 10:51 PM, Simon Glass wrote: > >> Hi Ramon, > >> > >> On 14 May 2018 at 01:10, Ramon Fried

Re: [U-Boot] [PATCH v4 27/32] doc: device-tree-bindings: add TIS TPMv2.0 SPI module info

On Tue, May 15, 2018 at 11:57:23AM +0200, Miquel Raynal wrote: > Add TIS TPMv2.0 SPI module bindings. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [U-Boot] [PATCH v4 01/32] tpm: remove redundant blank line

On 15 May 2018 at 19:56, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > CHECK: Please don't use multiple blank lines > > Signed-off-by: Miquel Raynal > --- > lib/tpm.c | 1 - > 1 file changed, 1

Re: [U-Boot] [PATCH v4 23/32] tpm: add TPM2_HierarchyChangeAuth command support

On Tue, May 15, 2018 at 11:57:19AM +0200, Miquel Raynal wrote: > Add support for the TPM2_HierarchyChangeAuth command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by:

Re: [U-Boot] [PATCH v2 5/6] scripts/dtc: Re-sync with Linux 4.17-rc4

Hi Eugeniu, On 16 May 2018 at 00:06, Eugeniu Rosca wrote: > Dear Masahiro, Simon, > > I think this patch logically belongs and is tightly coupled to the Linux > 4.17-rc4 Kconfig re-sync. Since you skipped it, I wonder if you have a > different view on this. > > Most of the

Re: [U-Boot] [PATCH v4 26/32] tpm: add the possibility to reset the chip with a gpio

On 15 May 2018 at 19:57, Miquel Raynal wrote: > On some designs, the reset line could not be connected to the SoC reset > line, in this case, request the GPIO and ensure the chip gets reset. > > Signed-off-by: Miquel Raynal > --- >

Re: [U-Boot] [PATCH v4 10/14] fastboot: Extract common definitions from USB fastboot

On 15 May 2018 at 08:48, Alex Kiernan wrote: > > Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code > we only have one definition. > > Signed-off-by: Alex Kiernan > --- > > Changes in v4: > - leave strcmp_l1() in USB fastboot

Re: [U-Boot] [PATCH v4 05/32] tpm: use the BIT() macro where applicable

On 15 May 2018 at 19:57, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > CHECK: Prefer using the BIT macro > > Signed-off-by: Miquel Raynal > --- > include/tpm.h | 14 +++--- > 1 file changed, 7

Re: [U-Boot] [PATCH 5/7] mach-snapdragon: Introduce pinctrl driver

Hi Ramon, On 15 May 2018 at 07:23, Ramon Fried wrote: > On Mon, May 14, 2018 at 10:51 PM, Simon Glass wrote: >> Hi Ramon, >> >> On 14 May 2018 at 01:10, Ramon Fried wrote: >>> On Mon, May 14, 2018 at 1:00 AM, Simon Glass

Re: [U-Boot] [PATCH v4 06/32] tpm: fix spelling

On 15 May 2018 at 19:57, Miquel Raynal wrote: > Fix following checkpatch.pl issues in TPM-related code: > > CHECK: '' may be misspelled - perhaps ''? > > Signed-off-by: Miquel Raynal > --- > include/tpm.h | 8 > lib/tpm.c |

Re: [U-Boot] [PATCH v4 02/32] tpm: remove extra spaces between a function and its opening bracket

On 15 May 2018 at 19:56, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > WARNING: space prohibited between function name and open > parenthesis '(' > > Signed-off-by: Miquel Raynal > --- > lib/tpm.c

Re: [U-Boot] [PATCH v4 16/32] tpm: add TPM2_Startup command support

On Tue, May 15, 2018 at 11:57:12AM +0200, Miquel Raynal wrote: > Add support for the TPM2_Startup command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini

Re: [U-Boot] arm: Raspberry Pi Compile warnings

Hi, On 15 May 2018 at 11:58, Duncan Hare wrote: > > Hi Simon > > Is this is problem? > > arch/arm/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing > property '#phy-cells' in node /phy or bad phandle (referred > from /soc/usb@7e98:phys[0]) > > repeated about 6 - 8

Re: [U-Boot] [PATCH v3 13/13] net: fastboot: Merge AOSP UDP fastboot

Hi Alex, On 15 May 2018 at 07:11, Alex Kiernan wrote: > On Mon, May 14, 2018 at 8:53 PM Simon Glass wrote: > >> Hi Alex, > >> On 14 May 2018 at 03:09, Alex Kiernan wrote: >> > Merge UDP fastboot support from AOSP: >> > >> > >

Re: [U-Boot] [PATCH v4 11/32] tpm: add missing parameter in private data structure description

On 15 May 2018 at 19:57, Miquel Raynal wrote: > Both parameters 'duration_ms' and 'retry_time_ms' of the tpm_chip_priv > structure are documented is the comment above the declaration but 'buf' > was forgotten. Add the missing description. > > Signed-off-by: Miquel

Re: [U-Boot] [PATCH v4 21/32] tpm: add TPM2_GetCapability command support

On Tue, May 15, 2018 at 11:57:17AM +0200, Miquel Raynal wrote: > Add support for the TPM2_GetCapability command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom

Re: [U-Boot] [PATCH v3 01/11] pmic: fsl: Provide some more definitions for MC34708 PMIC

On 15 May 2018 at 08:26, Lukasz Majewski wrote: > This commit adds some more defines for MC34708 PMIC. > > Signed-off-by: Lukasz Majewski > > --- > > Changes in v3: > - None > > Changes in v2: > - None > > include/fsl_pmic.h | 40

Re: [U-Boot] [PATCH v4 19/32] tpm: add TPM2_PCR_Extend command support

On Tue, May 15, 2018 at 11:57:15AM +0200, Miquel Raynal wrote: > Add support for the TPM2_PCR_Extend command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH v4 07/32] tpm: add extra blank lines between declarations and code

On 15 May 2018 at 19:57, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > WARNING: Missing a blank line after declarations > > Signed-off-by: Miquel Raynal > --- > lib/tpm.c | 3 +++ > 1 file changed, 3

Re: [U-Boot] [PATCH v4 29/32] tpm: add a Sandbox TPMv2.x driver

On Tue, May 15, 2018 at 11:57:25AM +0200, Miquel Raynal wrote: > This driver can emulate all the basic functionalities of a TPMv2.x > chip and should behave like them during regular testing. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules

On Tue, May 15, 2018 at 11:57:21AM +0200, Miquel Raynal wrote: > Add the tpm2_tis_spi driver that should support any TPMv2 compliant > (SPI) module. > > Signed-off-by: Miquel Raynal Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [U-Boot] [PATCH v4 20/32] tpm: add TPM2_PCR_Read command support

On Tue, May 15, 2018 at 11:57:16AM +0200, Miquel Raynal wrote: > Add support for the TPM2_PCR_Read command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH] image.h Allow booting Aarch64 from arm

On 15 May 2018 at 07:43, Ramon Fried wrote: > Snapdragon bootloader needs to jump from 32bit to 64bit > Allow booting in these cases when CONFIG_AARCH32_SUPPORT_ARM64 is > defined. > > Signed-off-by: Ramon Fried > --- > include/image.h | 6 ++ >

Re: [U-Boot] [PATCH v4 13/32] tpm: add macros to enhance TPM commands readability

On Tue, May 15, 2018 at 11:57:09AM +0200, Miquel Raynal wrote: > TPM commands are much easier to read/write with these macros that will > transform words or integers into byte strings. This way, there is no > need to call pack_byte_string() while all variable length in a command > are known (and

Re: [U-Boot] [PATCH v4 26/32] tpm: add the possibility to reset the chip with a gpio

On Tue, May 15, 2018 at 11:57:22AM +0200, Miquel Raynal wrote: > On some designs, the reset line could not be connected to the SoC reset > line, in this case, request the GPIO and ensure the chip gets reset. > > Signed-off-by: Miquel Raynal Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH v4 14/32] tpm: add possible traces to analyze buffers returned by the TPM

On Tue, May 15, 2018 at 11:57:10AM +0200, Miquel Raynal wrote: > When debugging, it is welcome to get more information about what the TPM > returns. Add the possibility to print the packets received to show their > exact content. > > Signed-off-by: Miquel Raynal >

Re: [U-Boot] [PATCH v4 18/32] tpm: add TPM2_Clear command support

On Tue, May 15, 2018 at 11:57:14AM +0200, Miquel Raynal wrote: > Add support for the TPM2_Clear command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH v4 28/32] test/py: add TPMv2.x test suite

On Tue, May 15, 2018 at 11:57:24AM +0200, Miquel Raynal wrote: > Add tests for the TPMv2.x commands. > These commands may run both on a physical TPM and with the sandbox > driver. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v4 22/32] tpm: add dictionary attack mitigation commands support

On Tue, May 15, 2018 at 11:57:18AM +0200, Miquel Raynal wrote: > Add support for the TPM2_DictionaryAttackParameters and > TPM2_DictionaryAttackLockReset commands. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by:

Re: [U-Boot] [PATCH v4 32/32] configs: add TPMv2.x support in Sandbox

On Tue, May 15, 2018 at 11:57:28AM +0200, Miquel Raynal wrote: > Enable the Sandbox TPMv2 driver in all possible configurations. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini -- Tom

Re: [U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules

Hi Miquel, On 15 May 2018 at 19:57, Miquel Raynal wrote: > Add the tpm2_tis_spi driver that should support any TPMv2 compliant > (SPI) module. > > Signed-off-by: Miquel Raynal > --- > drivers/tpm/Kconfig| 10 + >

Re: [U-Boot] [PATCH v4 11/32] tpm: add missing parameter in private data structure description

On Tue, May 15, 2018 at 11:57:07AM +0200, Miquel Raynal wrote: > Both parameters 'duration_ms' and 'retry_time_ms' of the tpm_chip_priv > structure are documented is the comment above the declaration but 'buf' > was forgotten. Add the missing description. > > Signed-off-by: Miquel Raynal

Re: [U-Boot] [PATCH v4 24/32] tpm: add PCR authentication commands support

On Tue, May 15, 2018 at 11:57:20AM +0200, Miquel Raynal wrote: > Add support for the TPM2_PCR_SetAuthPolicy and > TPM2_PCR_SetAuthValue commands. > > Change the command file and the help accordingly. > > Note: These commands could not be tested because the TPMs available > do not support them,

Re: [U-Boot] [PATCH v4 00/32] Introduce TPMv2.0 support

On Tue, May 15, 2018 at 11:56:56AM +0200, Miquel Raynal wrote: > Current U-Boot supports TPM v1.2 specification. The new specification > (v2.0) is not backward compatible and renames/introduces several > functions. This series introduces the support for TPMv2.x chips. > > First, some cleaning is

Re: [U-Boot] [PATCH v4 15/32] tpm: report driver error code to upper layer

On Tue, May 15, 2018 at 11:57:11AM +0200, Miquel Raynal wrote: > Instead of returning a generic 'library' error, report back the actual > error code so it can be displayed to the user by the regular error path. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon

Re: [U-Boot] [PATCH v4 30/32] doc: device-tree-bindings: add Sandbox TPMv2.0 module info

On Tue, May 15, 2018 at 11:57:26AM +0200, Miquel Raynal wrote: > Add Sandbox TPMv2.0 module bindings. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [U-Boot] [PATCH v4 04/32] tpm: align arguments with open parenthesis

On 15 May 2018 at 19:57, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Miquel Raynal > --- > cmd/tpm.c | 120 >

Re: [U-Boot] [PATCH v4 09/32] tpm: prepare introduction of TPMv2.x support in Kconfig

On Tue, May 15, 2018 at 11:57:05AM +0200, Miquel Raynal wrote: > Because both major revisions are not compatible at all, let's make them > mutually exclusive in Kconfig. This way we will be sure, when using a > command or a library function that it is supported by the right > revision. > >

Re: [U-Boot] [PATCH v4 12/32] tpm: prepare support for TPMv2.x commands

On Tue, May 15, 2018 at 11:57:08AM +0200, Miquel Raynal wrote: > Choice between v1 and v2 compliant functions is done with the > configuration. > > Create the various files that will receive TPMv2-only code on the same > scheme as for the TPMv1 code. > > Signed-off-by: Miquel Raynal

Re: [U-Boot] [PATCH v4 06/32] tpm: fix spelling

On Tue, May 15, 2018 at 11:57:02AM +0200, Miquel Raynal wrote: > Fix following checkpatch.pl issues in TPM-related code: > > CHECK: '' may be misspelled - perhaps ''? > > Signed-off-by: Miquel Raynal Reviewed-by: Tom Rini -- Tom

Re: [U-Boot] [PATCH v4 17/32] tpm: add TPM2_SelfTest command support

On Tue, May 15, 2018 at 11:57:13AM +0200, Miquel Raynal wrote: > Add support for the TPM2_Selftest command. > > Change the command file and the help accordingly. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH v4 31/32] sandbox: dts: add Sandbox TPMv2.x node

On Tue, May 15, 2018 at 11:57:27AM +0200, Miquel Raynal wrote: > This node declares the presence of the Sandbox TPMv2.x emulated chip, > available for testing. > > Signed-off-by: Miquel Raynal > Reviewed-by: Simon Glass Reviewed-by: Tom Rini

Re: [U-Boot] [PATCH v4 10/32] tpm: disociate TPMv1.x specific and generic code

On Tue, May 15, 2018 at 11:57:06AM +0200, Miquel Raynal wrote: > There are no changes in this commit but a new organization of the code > as follow. > > * cmd/ directory: > > move existing code from cmd/tpm.c in cmd/tpm-common.c > > move specific code in cmd/tpm-v1.c > >

  1   2   3   >