Re: [U-Boot] sandbox does not complete efi_selftest

2018-09-15 Thread Simon Glass
Hi Heinrich, On 15 September 2018 at 22:02, Heinrich Schuchardt wrote: > Hello Simon, > > in the chat with Alex you indicated that you see a problem with > efi_selftest expecting an input before resetting the board. > > I do not understand why this should be a problem with sandbox. There > never

[U-Boot] [PATCH 1/1] efi_loader: memory leak in efi_set_bootdev()

2018-09-15 Thread Heinrich Schuchardt
efi_set_bootdev() may be called repeatedly. Free the memory allocated for device paths in previous calls. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index 791db359f5..a890f414e8 100644 ---

[U-Boot] [PATCH 1/1] efi_loader: do not use local variable for handle

2018-09-15 Thread Heinrich Schuchardt
Do not use a local variable for the handle backing the memory device path. Adjust relate comments. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index

[U-Boot] [PULL] u-boot-socfpga/master

2018-09-15 Thread Marek Vasut
The following changes since commit ecb10a41c9adf2c499c3d19fff96a08bb9ad2aef: Revert "ARM: da850evm_direct_nor_defconfig: Enable DM_SERIAL" (2018-09-14 13:52:15 -0400) are available in the Git repository at: git://git.denx.de/u-boot-socfpga.git master for you to fetch changes up to

[U-Boot] [PULL] u-boot-usb/master

2018-09-15 Thread Marek Vasut
The following changes since commit ecb10a41c9adf2c499c3d19fff96a08bb9ad2aef: Revert "ARM: da850evm_direct_nor_defconfig: Enable DM_SERIAL" (2018-09-14 13:52:15 -0400) are available in the Git repository at: git://git.denx.de/u-boot-usb.git master for you to fetch changes up to

[U-Boot] [PULL] u-boot-sh/master

2018-09-15 Thread Marek Vasut
The following changes since commit ecb10a41c9adf2c499c3d19fff96a08bb9ad2aef: Revert "ARM: da850evm_direct_nor_defconfig: Enable DM_SERIAL" (2018-09-14 13:52:15 -0400) are available in the Git repository at: git://git.denx.de/u-boot-sh.git master for you to fetch changes up to

[U-Boot] [PATCH v2 2/2] arm: at91: wdt: Convert watchdog config to Kconfig

2018-09-15 Thread Prasanthi Chellakumar
Convert "CONFIG_AT91SAM9_WATCHDOG" to new "CONFIG_WDT_AT91" Kconfig option to support driver model and device tree. Signed-off-by: Prasanthi Chellakumar --- README| 3 --- arch/arm/dts/at91sam9260-smartweb.dts | 1 + arch/arm/dts/at91sam9g20-taurus.dts | 1 +

[U-Boot] [PULL] Please pull u-boot-coldfire/master

2018-09-15 Thread Angelo Dureghello
The following changes since commit 2976d3c1504960d3934a7404b0648edc28b52eb9: Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-09-14 13:54:37 -0400) are available in the Git repository at: git://git.denx.de/u-boot-coldfire.git master for you to fetch changes up to

[U-Boot] [PATCH 1/1] efi_loader: query serial console size reliably

2018-09-15 Thread Heinrich Schuchardt
Not all terminals understand CSI [18t for querying the console size. We should adhere to escape sequences documented in the console_codes manpage and the ECMA-48 standard. So here we follow a different approach. We position the cursor to the bottom right and query its position. Before leaving the

[U-Boot] [PATCH 1/1] efi_selftest: missing braces in efi_selftest_textinputex.c

2018-09-15 Thread Heinrich Schuchardt
gcc 4.8.4 wants to see all levels of braces when initializing a structure to zeros. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_textinputex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_selftest/efi_selftest_textinputex.c

[U-Boot] [PATCH v2 1/1] efi_loader: check parameter new_handle of efi_file_open()

2018-09-15 Thread Heinrich Schuchardt
We should not check parameter file twice. We should check parameter new_handle. Signed-off-by: Heinrich Schuchardt --- v2 remove spurious '#define DEBUG 1' --- lib/efi_loader/efi_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_file.c

Re: [U-Boot] [PATCH v3] drivers: spi: migrate cf_spi to DM

2018-09-15 Thread Jagan Teki
On Sat, Sep 15, 2018 at 2:43 PM, Angelo Dureghello wrote: > Hi Simon, > > On Fri, Sep 14, 2018 at 12:17:56PM +0200, Simon Glass wrote: >> Hi Angelo, >> >> On 28 June 2018 at 21:48, Angelo Dureghello wrote: >> > Hi Jagan, >> > >> > On Wed, Jun 27, 2018 at 02:54:42PM +0530, Jagan Teki wrote: >> >>

Re: [U-Boot] Pull request: u-boot-ubi/master

2018-09-15 Thread Tom Rini
On Fri, Sep 14, 2018 at 9:49 AM, Heiko Schocher wrote: > Hello Tom, > > please pull from u-boot-ubi-git master > > The following changes since commit d1e15041abf3ccd38169ae7aa8736f > 78200f8ee3: > > Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-09-11 > 08:50:10 -0400) > >

Re: [U-Boot] [PATCH] dm: uclass: Adding missing child_pre_probe description

2018-09-15 Thread Bin Meng
Hi Simon, On Fri, Sep 14, 2018 at 6:55 PM Simon Glass wrote: > > On 7 September 2018 at 16:51, Bin Meng wrote: > > The comment of child_pre_probe, one of the 'struct uclass_driver' > > members, is currently missing. > > > > Signed-off-by: Bin Meng > > --- > > > > include/dm/uclass.h | 1 + > >

Re: [U-Boot] [U-Boot,v5,05/10] sandbox: Allow to execute from RAM

2018-09-15 Thread Alexander Graf
> With efi_loader, we may want to execute payloads from RAM. By default, > permissions on the RAM region don't allow us to execute from there though. > > So let's change the default allocation scheme for RAM to also allow > execution from it. That way payloads that live in U-Boot RAM can be >

Re: [U-Boot] [U-Boot,v5,04/10] sandbox: Fix setjmp/longjmp

2018-09-15 Thread Alexander Graf
> In sandbox, longjmp returns to itself in an endless loop because > os_longjmp() calls into longjmp() which is provided by U-Boot which > again calls os_longjmp(). > > Setjmp on the other hand must not return because otherwise the > return freees up stack elements that we need during longjmp().

Re: [U-Boot] [PATCH v3] drivers: spi: migrate cf_spi to DM

2018-09-15 Thread Angelo Dureghello
Hi Simon, On Fri, Sep 14, 2018 at 12:17:56PM +0200, Simon Glass wrote: > Hi Angelo, > > On 28 June 2018 at 21:48, Angelo Dureghello wrote: > > Hi Jagan, > > > > On Wed, Jun 27, 2018 at 02:54:42PM +0530, Jagan Teki wrote: > >> On Wed, Jun 27, 2018 at 2:27 PM, Angelo Dureghello wrote: > >> > Hi

Re: [U-Boot] [PATCH v9 04/18] efi: sandbox: Enable EFI loader build for sandbox

2018-09-15 Thread Simon Glass
Hi Alex, On 15 September 2018 at 10:11, Alexander Graf wrote: > > > On 14.09.18 17:46, Simon Glass wrote: >> Hi Alex, >> >> On 26 August 2018 at 18:55, Alexander Graf wrote: >>> >>> >>> On 08.08.18 11:54, Simon Glass wrote: This allows this feature to build within sandbox. This is for

Re: [U-Boot] [PATCH v9 12/18] sandbox: Enhance map_to_sysmem() to handle foreign pointers

2018-09-15 Thread Simon Glass
Hi Alex, On 15 September 2018 at 10:16, Alexander Graf wrote: > > > On 14.09.18 17:46, Simon Glass wrote: >> Hi Alex, >> >> On 26 August 2018 at 19:11, Alexander Graf wrote: >>> >>> >>> On 08.08.18 11:54, Simon Glass wrote: At present map_sysmem() maps an address into the sandbox RAM

Re: [U-Boot] [PATCH v9 12/18] sandbox: Enhance map_to_sysmem() to handle foreign pointers

2018-09-15 Thread Alexander Graf
On 14.09.18 17:46, Simon Glass wrote: > Hi Alex, > > On 26 August 2018 at 19:11, Alexander Graf wrote: >> >> >> On 08.08.18 11:54, Simon Glass wrote: >>> At present map_sysmem() maps an address into the sandbox RAM buffer, >>> return a pointer, while map_to_sysmem() goes the other way. >>> >>>

Re: [U-Boot] [PATCH v9 04/18] efi: sandbox: Enable EFI loader build for sandbox

2018-09-15 Thread Alexander Graf
On 14.09.18 17:46, Simon Glass wrote: > Hi Alex, > > On 26 August 2018 at 18:55, Alexander Graf wrote: >> >> >> On 08.08.18 11:54, Simon Glass wrote: >>> This allows this feature to build within sandbox. This is for testing >>> purposes only since it is not possible for sandbox to load native

Re: [U-Boot] [PATCH 1/1] efi_loader: check parameter new_handle of efi_file_open()

2018-09-15 Thread Alexander Graf
On 14.09.18 22:59, Heinrich Schuchardt wrote: > We should not check parameter file twice. > We should check parameter new_handle. > > Signed-off-by: Heinrich Schuchardt > --- > fs/fat/fat_write.c| 2 ++ > lib/efi_loader/efi_file.c | 2 +- > 2 files changed, 3 insertions(+), 1

Re: [U-Boot] [U-Boot, v10, 03/10] sandbox: Align RAM buffer to the machine page size

2018-09-15 Thread Alexander Graf
> At present the sandbox RAM buffer is not aligned to any particular > address boundary. This makes the internal pointers somewhat random with > respect to the associated RAM buffer addresses. > > Align the buffer to the page size of the machine to help with this. Note > that there is a header at

Re: [U-Boot] [U-Boot, v10, 02/10] efi: sandbox: Enable EFI loader build for sandbox

2018-09-15 Thread Alexander Graf
> This allows this feature to build within sandbox. This is useful for > testing. > > Signed-off-by: Simon Glass Thanks, applied to efi-next Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v10, 09/10] efi: Correct the operation of efi_file_write()

2018-09-15 Thread Alexander Graf
> We should not directly cast between pointers and addresses since it breaks > sandbox. Fix this and simplify the code in file_read(). > > Signed-off-by: Simon Glass Thanks, applied to efi-next Alex ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [U-Boot, v10, 01/10] efi: sandbox: Add distroboot support

2018-09-15 Thread Alexander Graf
> With sandbox these values depend on the host system. Let's assume that it > is x86_64 for now. > > Signed-off-by: Simon Glass Thanks, applied to efi-next Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v10, 06/10] efi: Relocate FDT to 127MB instead of 128MB

2018-09-15 Thread Alexander Graf
> Sandbox only has 128MB of memory so we cannot relocate the device tree up > to start at 128MB. Use 127MB instead, which should be safe. > > Signed-off-by: Simon Glass Thanks, applied to efi-next Alex ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [U-Boot, v10, 05/10] sandbox: Enhance map_to_sysmem() to handle foreign pointers

2018-09-15 Thread Alexander Graf
> At present map_sysmem() maps an address into the sandbox RAM buffer, > return a pointer, while map_to_sysmem() goes the other way. > > The mapping is currently just 1:1 since a case was not found where a more > flexible mapping was needed. PCI does have a separate and more complex > mapping,

Re: [U-Boot] [U-Boot, v10, 10/10] efi: sandbox: Enable selftest command

2018-09-15 Thread Alexander Graf
> Enable this for sandbox since it almost passes now. > > Signed-off-by: Simon Glass Thanks, applied to efi-next Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v10, 04/10] sandbox: Add support for calling abort()

2018-09-15 Thread Alexander Graf
> This function is useful to signal that the application needs to exit > immediate. It can be caught with a debugger (e.g. gdb). Add a stub for it > so that it can be called from within sandbox when an internal error > occurs. > > Signed-off-by: Simon Glass Thanks, applied to efi-next Alex

Re: [U-Boot] [U-Boot, v10, 07/10] efi: sandbox: Tidy up copy_fdt() to work with sandbox

2018-09-15 Thread Alexander Graf
> At present this function takes a pointer as its argument, then passes this > to efi_allocate_pages(), which actually takes an address. It uses casts, > which are not supported on sandbox. > > Also the function calculates the FDT size rounded up to the neared EFI > page size, then its caller

Re: [U-Boot] [PATCH v10 00/10] efi: Enable sandbox support for EFI loader

2018-09-15 Thread Simon Glass
Hi Alex, On 15 September 2018 at 08:50, Simon Glass wrote: > A limitation of the EFI loader at present is that it does not build with > sandbox. This makes it hard to write tests, since sandbox is used for most > testing in U-Boot. > > This series enables the EFI loader feature. It allows

[U-Boot] [PATCH v10 08/10] efi_loader: Pass address to fs_read()

2018-09-15 Thread Simon Glass
From: Alexander Graf The fs_read() function wants to get an address rather than the pointer to a buffer. So let's convert the passed buffer from pointer back a the address to make efi_loader on sandbox happier. Signed-off-by: Alexander Graf Reviewed-by: Simon Glass Signed-off-by: Simon Glass

[U-Boot] [PATCH v10 09/10] efi: Correct the operation of efi_file_write()

2018-09-15 Thread Simon Glass
We should not directly cast between pointers and addresses since it breaks sandbox. Fix this and simplify the code in file_read(). Signed-off-by: Simon Glass --- Changes in v10: - Add new patch to correct the operation of efi_file_write() Changes in v9: None Changes in v8: None Changes in v7:

[U-Boot] [PATCH v10 10/10] efi: sandbox: Enable selftest command

2018-09-15 Thread Simon Glass
Enable this for sandbox since it almost passes now. Signed-off-by: Simon Glass --- Changes in v10: - Drop patches not essential to getting things working Changes in v9: None Changes in v8: - Rebase to master, bringing in all EFI changes - Drop 'efi: sandbox: Add relocation constants' - Drop

[U-Boot] [PATCH v10 05/10] sandbox: Enhance map_to_sysmem() to handle foreign pointers

2018-09-15 Thread Simon Glass
At present map_sysmem() maps an address into the sandbox RAM buffer, return a pointer, while map_to_sysmem() goes the other way. The mapping is currently just 1:1 since a case was not found where a more flexible mapping was needed. PCI does have a separate and more complex mapping, but uses its

[U-Boot] [PATCH v10 03/10] sandbox: Align RAM buffer to the machine page size

2018-09-15 Thread Simon Glass
At present the sandbox RAM buffer is not aligned to any particular address boundary. This makes the internal pointers somewhat random with respect to the associated RAM buffer addresses. Align the buffer to the page size of the machine to help with this. Note that there is a header at the start

[U-Boot] [PATCH v10 04/10] sandbox: Add support for calling abort()

2018-09-15 Thread Simon Glass
This function is useful to signal that the application needs to exit immediate. It can be caught with a debugger (e.g. gdb). Add a stub for it so that it can be called from within sandbox when an internal error occurs. Signed-off-by: Simon Glass --- Changes in v10: None Changes in v9: None

[U-Boot] [PATCH v10 07/10] efi: sandbox: Tidy up copy_fdt() to work with sandbox

2018-09-15 Thread Simon Glass
At present this function takes a pointer as its argument, then passes this to efi_allocate_pages(), which actually takes an address. It uses casts, which are not supported on sandbox. Also the function calculates the FDT size rounded up to the neared EFI page size, then its caller recalculates

[U-Boot] [PATCH v10 06/10] efi: Relocate FDT to 127MB instead of 128MB

2018-09-15 Thread Simon Glass
Sandbox only has 128MB of memory so we cannot relocate the device tree up to start at 128MB. Use 127MB instead, which should be safe. Signed-off-by: Simon Glass --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v4: None Changes

[U-Boot] [PATCH v10 01/10] efi: sandbox: Add distroboot support

2018-09-15 Thread Simon Glass
With sandbox these values depend on the host system. Let's assume that it is x86_64 for now. Signed-off-by: Simon Glass --- Changes in v10: - Try to use compiler pre-defines to get the right settings for sandbox Changes in v9: None Changes in v8: None Changes in v7: - Drop an unnecessary

[U-Boot] [PATCH v10 02/10] efi: sandbox: Enable EFI loader build for sandbox

2018-09-15 Thread Simon Glass
This allows this feature to build within sandbox. This is useful for testing. Signed-off-by: Simon Glass --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: - Update patch subject s/builder/build/ Changes in v6: None Changes in v4: None Changes in v3: - Init the

[U-Boot] [PATCH v10 00/10] efi: Enable sandbox support for EFI loader

2018-09-15 Thread Simon Glass
A limitation of the EFI loader at present is that it does not build with sandbox. This makes it hard to write tests, since sandbox is used for most testing in U-Boot. This series enables the EFI loader feature. It allows sandbox to build and run a trivial function which calls the EFI API to